Skip to content

Commit 40bddd9

Browse files
committed
MAGETWO-34363: Pull request processing
1 parent 86fa1df commit 40bddd9

File tree

8 files changed

+79
-7
lines changed

8 files changed

+79
-7
lines changed

app/code/Magento/Checkout/Test/Unit/Controller/Cart/IndexTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77

88
use Magento\Checkout\Controller\Cart\Index;
99

10+
/**
11+
* Class IndexTest
12+
*/
1013
class IndexTest extends \PHPUnit_Framework_TestCase
1114
{
1215
/**
@@ -64,6 +67,9 @@ class IndexTest extends \PHPUnit_Framework_TestCase
6467
*/
6568
protected $resultPageFactory;
6669

70+
/**
71+
* @return void
72+
*/
6773
public function setUp()
6874
{
6975
$this->request = $this->getMock('Magento\Framework\App\Request\Http', [], [], '', false);
@@ -120,6 +126,9 @@ public function setUp()
120126
);
121127
}
122128

129+
/**
130+
* @return void
131+
*/
123132
public function testExecuteWithMessages()
124133
{
125134
$phrase = $this->getMockBuilder('Magento\Framework\Phrase')

app/code/Magento/Customer/Test/Unit/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
/**
1111
* Customer personal information template block test.
12-
*
13-
* @package Magento\Customer\Block\Adminhtml\Edit\Tab\View
1412
*/
1513
class PersonalInfoTest extends \PHPUnit_Framework_TestCase
1614
{
@@ -44,6 +42,9 @@ class PersonalInfoTest extends \PHPUnit_Framework_TestCase
4442
*/
4543
protected $scopeConfig;
4644

45+
/**
46+
* @return void
47+
*/
4748
protected function setUp()
4849
{
4950
$customer = $this->getMock(
@@ -136,6 +137,9 @@ protected function setUp()
136137
);
137138
}
138139

140+
/**
141+
* @return void
142+
*/
139143
public function testGetStoreLastLoginDateTimezone()
140144
{
141145
$this->scopeConfig
@@ -155,6 +159,7 @@ public function testGetStoreLastLoginDateTimezone()
155159
* @param string|null $lastLoginAt
156160
* @param string|null $lastVisitAt
157161
* @param string|null $lastLogoutAt
162+
* @return void
158163
* @dataProvider getCurrentStatusDataProvider
159164
*/
160165
public function testGetCurrentStatus($status, $lastLoginAt, $lastVisitAt, $lastLogoutAt)
@@ -183,6 +188,7 @@ public function getCurrentStatusDataProvider()
183188
* @param string $result
184189
* @param string|null $lastLoginAt
185190
* @dataProvider getLastLoginDateDataProvider
191+
* @return void
186192
*/
187193
public function testGetLastLoginDate($result, $lastLoginAt)
188194
{
@@ -207,6 +213,7 @@ public function getLastLoginDateDataProvider()
207213
* @param string $result
208214
* @param string|null $lastLoginAt
209215
* @dataProvider getStoreLastLoginDateDataProvider
216+
* @return void
210217
*/
211218
public function testGetStoreLastLoginDate($result, $lastLoginAt)
212219
{

app/code/Magento/Customer/Test/Unit/Model/LogTest.php

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
/**
99
* Customer log model test.
10-
*
11-
* @package Magento\Customer\Model
1210
*/
1311
class LogTest extends \PHPUnit_Framework_TestCase
1412
{
@@ -29,6 +27,9 @@ class LogTest extends \PHPUnit_Framework_TestCase
2927
'last_logout_at' => '2015-03-04 12:05:00',
3028
];
3129

30+
/**
31+
* @return void
32+
*/
3233
protected function setUp()
3334
{
3435
$objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -44,21 +45,33 @@ protected function setUp()
4445
);
4546
}
4647

48+
/**
49+
* @return void
50+
*/
4751
public function testGetCustomerId()
4852
{
4953
$this->assertEquals($this->logData['customer_id'], $this->log->getCustomerId());
5054
}
5155

56+
/**
57+
* @return void
58+
*/
5259
public function testGetLastLoginAt()
5360
{
5461
$this->assertEquals($this->logData['last_login_at'], $this->log->getLastLoginAt());
5562
}
5663

64+
/**
65+
* @return void
66+
*/
5767
public function testGetLastVisitAt()
5868
{
5969
$this->assertEquals($this->logData['last_visit_at'], $this->log->getLastVisitAt());
6070
}
6171

72+
/**
73+
* @return void
74+
*/
6275
public function testGetLastLogoutAt()
6376
{
6477
$this->assertEquals($this->logData['last_logout_at'], $this->log->getLastLogoutAt());

app/code/Magento/Customer/Test/Unit/Model/LoggerTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
/**
99
* Customer log data logger test.
10-
*
11-
* @package Magento\Customer\Model
1210
*/
1311
class LoggerTest extends \PHPUnit_Framework_TestCase
1412
{
@@ -38,6 +36,9 @@ class LoggerTest extends \PHPUnit_Framework_TestCase
3836
*/
3937
protected $adapter;
4038

39+
/**
40+
* @return void
41+
*/
4142
protected function setUp()
4243
{
4344
$this->adapter = $this->getMock(
@@ -65,6 +66,7 @@ protected function setUp()
6566
* @param int $customerId
6667
* @param array $data
6768
* @dataProvider testLogDataProvider
69+
* @return void
6870
*/
6971
public function testLog($customerId, $data)
7072
{
@@ -107,6 +109,7 @@ public function testLogDataProvider()
107109
* @param int $customerId
108110
* @param array $data
109111
* @dataProvider testGetDataProvider
112+
* @return void
110113
*/
111114
public function testGet($customerId, $data)
112115
{

app/code/Magento/Customer/Test/Unit/Model/Observer/LogTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
use Magento\Framework\Event\Observer;
1111
use Magento\Customer\Model\Observer\Log;
1212

13+
/**
14+
* Class LogTest
15+
*/
1316
class LogTest extends \PHPUnit_Framework_TestCase
1417
{
1518
/**
@@ -27,13 +30,19 @@ class LogTest extends \PHPUnit_Framework_TestCase
2730
*/
2831
protected $dateTime;
2932

33+
/**
34+
* @return void
35+
*/
3036
public function setUp()
3137
{
3238
$this->loggerMock = $this->getMock('Magento\Customer\Model\Logger', [], [], '', false);
3339
$this->dateTime = $this->getMock('Magento\Framework\Stdlib\DateTime', [], [], '', false);
3440
$this->logObserver = new Log($this->loggerMock, $this->dateTime);
3541
}
3642

43+
/**
44+
* @return void
45+
*/
3746
public function testLogLastLoginAt()
3847
{
3948
$id = 1;
@@ -64,6 +73,9 @@ public function testLogLastLoginAt()
6473
$this->logObserver->logLastLoginAt($observerMock);
6574
}
6675

76+
/**
77+
* @return void
78+
*/
6779
public function testLogLastLogoutAt()
6880
{
6981
$id = 1;

app/code/Magento/Translation/Test/Unit/Model/Js/Config/Source/StrategyTest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,30 @@
88
use Magento\Translation\Model\Js\Config;
99
use Magento\Translation\Model\Js\Config\Source\Strategy;
1010

11+
/**
12+
* Class StrategyTest
13+
*/
1114
class StrategyTest extends \PHPUnit_Framework_TestCase
1215
{
1316
/**
1417
* @var Strategy
1518
*/
1619
protected $model;
1720

21+
/**
22+
* Set up
23+
* @return void
24+
*/
1825
protected function setUp()
1926
{
2027
$objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
2128
$this->model = $objectManager->getObject('Magento\Translation\Model\Js\Config\Source\Strategy');
2229
}
2330

31+
/**
32+
* Test for toOptionArray method
33+
* @return void
34+
*/
2435
public function testToOptionArray()
2536
{
2637
$expected = [

app/code/Magento/Translation/Test/Unit/Model/Js/DataProviderTest.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
use Magento\Translation\Model\Js\DataProvider;
1414
use Magento\Translation\Model\Js\Config;
1515

16-
16+
/**
17+
* Class DataProviderTest
18+
*/
1719
class DataProviderTest extends \PHPUnit_Framework_TestCase
1820
{
1921
/**
@@ -41,6 +43,9 @@ class DataProviderTest extends \PHPUnit_Framework_TestCase
4143
*/
4244
protected $rootDirectoryMock;
4345

46+
/**
47+
* @return void
48+
*/
4449
protected function setUp()
4550
{
4651
$this->appStateMock = $this->getMock('Magento\Framework\App\State', [], [], '', false);
@@ -60,6 +65,9 @@ protected function setUp()
6065
);
6166
}
6267

68+
/**
69+
* @return void
70+
*/
6371
public function testGetData()
6472
{
6573
$themePath = 'blank';

lib/internal/Magento/Framework/Test/Unit/Translate/Js/ConfigTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,24 @@
88

99
use Magento\Framework\Translate\Js\Config;
1010

11+
/**
12+
* Class ConfigTest
13+
*/
1114
class ConfigTest extends \PHPUnit_Framework_TestCase
1215
{
16+
/**
17+
* @return void
18+
*/
1319
public function testDefault()
1420
{
1521
$config = new Config();
1622
$this->assertFalse($config->dictionaryEnabled());
1723
$this->assertNull($config->getDictionaryFileName());
1824
}
1925

26+
/**
27+
* @return void
28+
*/
2029
public function testCustom()
2130
{
2231
$path = 'path';

0 commit comments

Comments
 (0)