Merge pull request #7544 from magento-cia/2.4.5-bugfixes-032922

Bugfixes

Author: dvoskoboinikov

app/code/Magento/Checkout/Controller/Sidebar/UpdateItemQty.php

@@ -3,19 +3,25 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Checkout\Controller\Sidebar;
 
 use Magento\Checkout\Model\Cart\RequestQuantityProcessor;
 use Magento\Checkout\Model\Sidebar;
 use Magento\Framework\App\Action\Action;
 use Magento\Framework\App\Action\Context;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\Response\Http;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Json\Helper\Data;
 use Psr\Log\LoggerInterface;
 
-class UpdateItemQty extends Action
+/**
+ * Class used to update item quantity.
+ */
+class UpdateItemQty extends Action implements HttpPostActionInterface
 {
     /**
      * @var Sidebar
@@ -61,12 +67,18 @@ public function __construct(
     }
 
     /**
+     * Action for Quantity update
+     *
      * @return $this
      */
     public function execute()
     {
         $itemId = (int)$this->getRequest()->getParam('item_id');
-        $itemQty = $this->getRequest()->getParam('item_qty') * 1;
+        $itemQty = (int)$this->getRequest()->getParam('item_qty');
+
+        if ($itemQty <= 0) {
+            return  $this->jsonResponse(__('Invalid Item Quantity Requested.'));
+        }
         $itemQty = $this->quantityProcessor->prepareQuantity($itemQty);
 
         try {

app/code/Magento/Checkout/Test/Unit/Controller/Sidebar/UpdateItemQtyTest.php

@@ -19,6 +19,9 @@
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
 
+/**
+ * Class used to execute test cases for update item quantity
+ */
 class UpdateItemQtyTest extends TestCase
 {
     /**
@@ -244,4 +247,36 @@ public function testExecuteWithException(): void
 
         $this->assertEquals('json represented', $this->updateItemQty->execute());
     }
+
+    /**
+     * @return void
+     */
+    public function testExecuteWithInvalidItemQty(): void
+    {
+        $error = [
+            'success' => false,
+            'error_message' => 'Invalid Item Quantity Requested.'
+        ];
+        $jsonResult = json_encode($error);
+        $this->requestMock
+            ->method('getParam')
+            ->withConsecutive(['item_id', null], ['item_qty', null])
+            ->willReturnOnConsecutiveCalls('1', '{{7+2}}');
+
+        $this->sidebarMock->expects($this->once())
+            ->method('getResponseData')
+            ->with('Invalid Item Quantity Requested.')
+            ->willReturn($error);
+
+        $this->jsonHelperMock->expects($this->once())
+            ->method('jsonEncode')
+            ->with($error)
+            ->willReturn($jsonResult);
+
+        $this->responseMock->expects($this->once())
+            ->method('representJson')
+            ->willReturn($jsonResult);
+
+        $this->assertEquals($jsonResult, $this->updateItemQty->execute());
+    }
 }

app/code/Magento/Checkout/i18n/en_US.csv

@@ -186,3 +186,4 @@ Payment,Payment
 "Show Cross-sell Items in the Shopping Cart","Show Cross-sell Items in the Shopping Cart"
 "You added %1 to your <a href=""%2"">shopping cart</a>.","You added %1 to your <a href=""%2"">shopping cart</a>."
 "The shipping method is missing. Select the shipping method and try again.","The shipping method is missing. Select the shipping method and try again."
+"Invalid Item Quantity Requested.","Invalid Item Quantity Requested."