Coding standards refactor

Author: Jan Polak

app/code/Magento/InstantPurchase/Controller/Button/Available.php

@@ -47,7 +47,7 @@ public function __construct(
         Config $instantPurchaseConfig
     ) {
         parent::__construct($context);
-        $this->InstantPurchase = $instantPurchase;
+        $this->instantPurchase = $instantPurchase;
         $this->customerSession = $customerSession;
         $this->customerAddressesFormatter = $customerAddressesFormatter;
         $this->instantPurchaseConfig = $instantPurchaseConfig;
@@ -64,7 +64,7 @@ public function execute()
             return $result;
         }
         $customer = $this->customerSession->getCustomer();
-        $available = $this->InstantPurchase->isAvailableForCustomer($customer);
+        $available = $this->instantPurchase->isAvailableForCustomer($customer);
         $resultData = [
             'available' => $available
         ];

app/code/Magento/InstantPurchase/Model/CustomerDataGetterFactory.php

@@ -15,14 +15,22 @@ class CustomerDataGetterFactory
      */
     private $objectManager;
 
+    /**
+     * CustomerDataGetterFactory constructor.
+     * @param ObjectManager $objectManager
+     */
     public function __construct(
         ObjectManager $objectManager
     ) {
         $this->objectManager = $objectManager;
     }
 
-    public function create(Customer $customer)
+    /**
+     * @param Customer $customer
+     * @return CustomerDataGetter
+     */
+    public function create(Customer $customer): CustomerDataGetter
     {
         return $this->objectManager->create(CustomerDataGetter::class, ['customer' => $customer]);
     }
-}
+}

app/code/Magento/InstantPurchase/Model/InstantPurchase.php

@@ -114,7 +114,7 @@ private function isBrainTreeAvailable(): bool
     /**
      * @return bool
      */
-    private function isBrainTree3DDisabled()
+    private function isBrainTree3DDisabled(): bool
     {
         return !$this->brainTreeConfig->isVerify3DSecure();
     }

app/code/Magento/InstantPurchase/Model/PaymentPreparer.php

@@ -43,4 +43,4 @@ public function prepare(Quote $quote, string $customerId, string $ccId)
         );
         $quote->collectTotals();
     }
-}
+}

app/code/Magento/InstantPurchase/Model/ShippingRateChooser.php

@@ -53,4 +53,4 @@ public function choose(Quote $quote): Quote
 
         return $quote;
     }
-}
+}

app/code/Magento/InstantPurchase/Model/ShippingRateChooserRuleInterface.php

@@ -5,8 +5,6 @@
  */
 namespace Magento\InstantPurchase\Model;
 
-use Magento\Quote\Model\Quote;
-
 /**
  * Interface ShippingRateChooserInterface
  */

app/code/Magento/InstantPurchase/Test/Unit/Model/CustomerDataGetterTest.php

@@ -7,7 +7,6 @@
 
 use Magento\Customer\Model\Address;
 use Magento\Customer\Model\Customer;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\InstantPurchase\Model\CustomerDataGetter;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use PHPUnit\Framework\TestCase;

app/code/Magento/InstantPurchase/Test/Unit/Model/ShippingRateChooserTest.php

@@ -45,7 +45,8 @@ public function setUp()
                 ['setCollectShippingRates', 'collectShippingRates', 'getAllShippingRates', 'setShippingMethod']
             )->getMock();
         $this->shippingRateChooserRule = $this->createMock(ShippingRateChooserRuleInterface::class);
-        $this->shippingRateChooser = $objectManager->getObject(ShippingRateChooser::class,
+        $this->shippingRateChooser = $objectManager->getObject(
+            ShippingRateChooser::class,
             ['shippingRateChooserRule' => $this->shippingRateChooserRule]
         );
     }

app/code/Magento/InstantPurchase/composer.json

@@ -1,5 +1,5 @@
 {
-  "name": "magento/module-instant-purchaseing",
+  "name": "magento/module-instant-purchase",
   "description": "N/A",
   "type": "magento2-module",
   "version": "100.3.0-dev",