MAGETWO-51592: Make single tenant compiler work when Magento not installed

Updating unit test

Author: Igor Melnikov

setup/src/Magento/Setup/Test/Unit/Console/Command/DiCompileCommandTest.php

@@ -12,13 +12,13 @@
 class DiCompileCommandTest extends \PHPUnit_Framework_TestCase
 {
     /** @var \Magento\Framework\App\DeploymentConfig|\PHPUnit_Framework_MockObject_MockObject */
-    private $deploymentConfig;
+    private $deploymentConfigMock;
 
     /** @var \Magento\Setup\Module\Di\App\Task\Manager|\PHPUnit_Framework_MockObject_MockObject */
-    private $manager;
+    private $managerMock;
 
     /** @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject */
-    private $objectManager;
+    private $objectManagerMock;
 
     /** @var DiCompileCommand|\PHPUnit_Framework_MockObject_MockObject */
     private $command;
@@ -27,28 +27,28 @@ class DiCompileCommandTest extends \PHPUnit_Framework_TestCase
     private $cacheMock;
 
     /** @var  \Magento\Framework\Filesystem|\PHPUnit_Framework_MockObject_MockObject */
-    private $filesystem;
+    private $filesystemMock;
 
-    /** @var  \Magento\Framework\Filesystem\Driver\File | \PHPUnit_Framework_MockObject_MockObject*/
-    private $fileDriver;
+    /** @var  \Magento\Framework\Filesystem\Driver\File|\PHPUnit_Framework_MockObject_MockObject */
+    private $fileDriverMock;
 
-    /** @var  \Magento\Framework\App\Filesystem\DirectoryList | \PHPUnit_Framework_MockObject_MockObject*/
-    private $directoryList;
+    /** @var  \Magento\Framework\App\Filesystem\DirectoryList|\PHPUnit_Framework_MockObject_MockObject */
+    private $directoryListMock;
 
     /** @var  \Magento\Framework\Component\ComponentRegistrar|\PHPUnit_Framework_MockObject_MockObject */
-    private $componentRegistrar;
+    private $componentRegistrarMock;
 
     public function setUp()
     {
-        $this->deploymentConfig = $this->getMock('Magento\Framework\App\DeploymentConfig', [], [], '', false);
-        $objectManagerProvider = $this->getMock(
+        $this->deploymentConfigMock = $this->getMock('Magento\Framework\App\DeploymentConfig', [], [], '', false);
+        $objectManagerProviderMock = $this->getMock(
             'Magento\Setup\Model\ObjectManagerProvider',
             [],
             [],
             '',
             false
         );
-        $this->objectManager = $this->getMockForAbstractClass(
+        $this->objectManagerMock = $this->getMockForAbstractClass(
             'Magento\Framework\ObjectManagerInterface',
             [],
             '',
@@ -58,91 +58,101 @@ public function setUp()
             ->disableOriginalConstructor()
             ->getMock();
 
-        $objectManagerProvider->expects($this->once())
+        $objectManagerProviderMock->expects($this->once())
             ->method('get')
-            ->willReturn($this->objectManager);
-        $this->manager = $this->getMock('Magento\Setup\Module\Di\App\Task\Manager', [], [], '', false);
-        $this->directoryList = $this->getMock('Magento\Framework\App\Filesystem\DirectoryList', [], [], '', false);
-        $this->filesystem = $this->getMockBuilder('Magento\Framework\Filesystem')
+            ->willReturn($this->objectManagerMock);
+        $this->managerMock = $this->getMock('Magento\Setup\Module\Di\App\Task\Manager', [], [], '', false);
+        $this->directoryListMock = $this->getMock('Magento\Framework\App\Filesystem\DirectoryList', [], [], '', false);
+        $this->filesystemMock = $this->getMockBuilder('Magento\Framework\Filesystem')
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->fileDriver = $this->getMockBuilder('Magento\Framework\Filesystem\Driver\File')
+        $this->fileDriverMock = $this->getMockBuilder('Magento\Framework\Filesystem\Driver\File')
             ->disableOriginalConstructor()
             ->getMock();
-        $this->componentRegistrar = $this->getMock(
+        $this->componentRegistrarMock = $this->getMock(
             '\Magento\Framework\Component\ComponentRegistrar',
             [],
             [],
             '',
             false
         );
-        $this->componentRegistrar->expects($this->any())->method('getPaths')->willReturnMap([
+        $this->componentRegistrarMock->expects($this->any())->method('getPaths')->willReturnMap([
             [ComponentRegistrar::MODULE, ['/path/to/module/one', '/path/to/module/two']],
             [ComponentRegistrar::LIBRARY, ['/path/to/library/one', '/path/to/library/two']],
         ]);
 
         $this->command = new DiCompileCommand(
-            $this->deploymentConfig,
-            $this->directoryList,
-            $this->manager,
-            $objectManagerProvider,
-            $this->filesystem,
-            $this->fileDriver,
-            $this->componentRegistrar
+            $this->deploymentConfigMock,
+            $this->directoryListMock,
+            $this->managerMock,
+            $objectManagerProviderMock,
+            $this->filesystemMock,
+            $this->fileDriverMock,
+            $this->componentRegistrarMock
         );
     }
 
     public function testExecuteDiExists()
     {
         $diPath = '/root/magento/var/di';
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
-        $this->fileDriver->expects($this->atLeastOnce())->method('isExists')->with($diPath)->willReturn(true);
-        $this->directoryList->expects($this->atLeastOnce())->method('getPath')->willReturn($diPath);
+        $this->deploymentConfigMock->expects($this->once())
+            ->method('get')
+            ->with(\Magento\Framework\Config\ConfigOptionsListConstants::KEY_MODULES)
+            ->willReturn(['Magento_Catalog' => 1]);
+        $this->fileDriverMock->expects($this->atLeastOnce())->method('isExists')->with($diPath)->willReturn(true);
+        $this->directoryListMock->expects($this->atLeastOnce())->method('getPath')->willReturn($diPath);
         $tester = new CommandTester($this->command);
         $tester->execute([]);
         $this->assertContains("delete '/root/magento/var/di'", $tester->getDisplay());
     }
 
-    public function testExecuteNotInstalled()
+    public function testExecuteModulesNotEnabled()
     {
-        $this->directoryList->expects($this->atLeastOnce())->method('getPath')->willReturn(null);
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(false);
+        $this->directoryListMock->expects($this->atLeastOnce())->method('getPath')->willReturn(null);
+        $this->deploymentConfigMock->expects($this->once())
+            ->method('get')
+            ->with(\Magento\Framework\Config\ConfigOptionsListConstants::KEY_MODULES)
+            ->willReturn(null);
         $tester = new CommandTester($this->command);
         $tester->execute([]);
         $this->assertEquals(
-            'You cannot run this command because the Magento application is not installed.' . PHP_EOL,
+            'You cannot run this command because modules are not enabled. You can enable modules by running \'module:'
+                . 'enable --all\' command.' . PHP_EOL,
             $tester->getDisplay()
         );
     }
 
     public function testExecute()
     {
-        $this->directoryList->expects($this->atLeastOnce())->method('getPath')->willReturn(null);
-        $this->objectManager->expects($this->once())
+        $this->directoryListMock->expects($this->atLeastOnce())->method('getPath')->willReturn(null);
+        $this->objectManagerMock->expects($this->once())
             ->method('get')
             ->with('Magento\Framework\App\Cache')
             ->willReturn($this->cacheMock);
         $this->cacheMock->expects($this->once())->method('clean');
         $writeDirectory = $this->getMock('Magento\Framework\Filesystem\Directory\WriteInterface');
         $writeDirectory->expects($this->atLeastOnce())->method('delete');
-        $this->filesystem->expects($this->atLeastOnce())->method('getDirectoryWrite')->willReturn($writeDirectory);
+        $this->filesystemMock->expects($this->atLeastOnce())->method('getDirectoryWrite')->willReturn($writeDirectory);
 
-        $this->deploymentConfig->expects($this->once())->method('isAvailable')->willReturn(true);
+        $this->deploymentConfigMock->expects($this->once())
+            ->method('get')
+            ->with(\Magento\Framework\Config\ConfigOptionsListConstants::KEY_MODULES)
+            ->willReturn(['Magento_Catalog' => 1]);
         $progressBar = $this->getMockBuilder(
             'Symfony\Component\Console\Helper\ProgressBar'
         )
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->objectManager->expects($this->once())->method('configure');
-        $this->objectManager
+        $this->objectManagerMock->expects($this->once())->method('configure');
+        $this->objectManagerMock
             ->expects($this->once())
             ->method('create')
             ->with('Symfony\Component\Console\Helper\ProgressBar')
             ->willReturn($progressBar);
-        $this->manager->expects($this->exactly(7))->method('addOperation');
-        $this->manager->expects($this->once())->method('process');
+        $this->managerMock->expects($this->exactly(7))->method('addOperation');
+        $this->managerMock->expects($this->once())->method('process');
         $tester = new CommandTester($this->command);
         $tester->execute([]);
         $this->assertContains(