You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets/design.xml
+8-5Lines changed: 8 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -6,15 +6,18 @@
6
6
-->
7
7
<rulesetname="Magento Specific Design Rules"xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd"xmlns="http://pmd.sf.net/ruleset/1.0.0"xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
8
8
<rulename="RequestAwareBlockMethod"class="Magento\CodeMessDetector\Rule\Design\RequestAwareBlockMethod"message="{0} uses request object directly. Add user input validation and suppress this warning.">
9
-
<description><![CDATA[
9
+
<description>
10
+
<![CDATA[
10
11
11
12
Blocks must not depend on being used with certain controllers.
12
13
If you use request object in a block directly you must validate all user input inside the block.
13
14
14
-
]]></description>
15
+
]]>
16
+
</description>
15
17
<priority>2</priority>
16
18
<properties/>
17
-
<example><![CDATA[
19
+
<example>
20
+
<![CDATA[
18
21
19
22
class MyOrder extends AbstractBlock
20
23
{
@@ -31,7 +34,7 @@ class MyOrder extends AbstractBlock
0 commit comments