ENGCOM-1064: Registry deprecation #14333

magento-engcom-team · magento-engcom-team · commit 3f975a264dc5 · 2018-03-24T10:28:16.000-05:00
- Merge Pull Request #14333 from vkublytskyi/magento2:registry-deprecation - Merged commits: 1. f3d9209
diff --git a/lib/internal/Magento/Framework/Registry.php b/lib/internal/Magento/Framework/Registry.php
@@ -8,7 +8,11 @@
 /**
  * Registry model. Used to manage values in registry
  *
+ * Registry usage as a shared service introduces temporal, hard to detect coupling into system.
+ * It's usage should be avoid. Use service classes or data providers instead.
+ *
  * @api
+ * @deprecated
  */
 class Registry
 {
@@ -24,6 +28,8 @@ class Registry
      *
      * @param string $key
      * @return mixed
+     *
+     * @deprecated
      */
     public function registry($key)
     {
@@ -41,6 +47,8 @@ public function registry($key)
      * @param bool $graceful
      * @return void
      * @throws \RuntimeException
+     *
+     * @deprecated
      */
     public function register($key, $value, $graceful = false)
     {
@@ -58,6 +66,8 @@ public function register($key, $value, $graceful = false)
      *
      * @param string $key
      * @return void
+     *
+     * @deprecated
      */
     public function unregister($key)
     {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,11 @@`
`8`	`8`	`/**`
`9`	`9`	`* Registry model. Used to manage values in registry`
`10`	`10`	`*`
	`11`	`+ * Registry usage as a shared service introduces temporal, hard to detect coupling into system.`
	`12`	`+ * It's usage should be avoid. Use service classes or data providers instead.`
	`13`	`+ *`
`11`	`14`	`* @api`
	`15`	`+ * @deprecated`
`12`	`16`	`*/`
`13`	`17`	`class Registry`
`14`	`18`	`{`
`@@ -24,6 +28,8 @@ class Registry`
`24`	`28`	`*`
`25`	`29`	`* @param string $key`
`26`	`30`	`* @return mixed`
	`31`	`+ *`
	`32`	`+ * @deprecated`
`27`	`33`	`*/`
`28`	`34`	`public function registry($key)`
`29`	`35`	`{`
`@@ -41,6 +47,8 @@ public function registry($key)`
`41`	`47`	`* @param bool $graceful`
`42`	`48`	`* @return void`
`43`	`49`	`* @throws \RuntimeException`
	`50`	`+ *`
	`51`	`+ * @deprecated`
`44`	`52`	`*/`
`45`	`53`	`public function register($key, $value, $graceful = false)`
`46`	`54`	`{`
`@@ -58,6 +66,8 @@ public function register($key, $value, $graceful = false)`
`58`	`66`	`*`
`59`	`67`	`* @param string $key`
`60`	`68`	`* @return void`
	`69`	`+ *`
	`70`	`+ * @deprecated`
`61`	`71`	`*/`
`62`	`72`	`public function unregister($key)`
`63`	`73`	`{`