Skip to content

Commit 3f7c330

Browse files
committed
MC-15959: Implement caching for url resolver
- fix static
1 parent 58d082d commit 3f7c330

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/UrlRewrite/UrlResolverCacheTest.php

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,7 @@ public function testCacheTagsForCategory()
8686
]
8787
);
8888
$categoryId = $actualUrls->getEntityId();
89-
$query
90-
= <<<QUERY
91-
{
92-
urlResolver(url:"{$categoryUrlKey}")
93-
{
94-
id
95-
relative_url
96-
canonical_url
97-
type
98-
}
99-
}
100-
QUERY;
89+
$query = $this->getUrlResolverQuery($categoryUrlKey);
10190
$responseMiss = $this->graphQlQueryWithResponseHeaders($query);
10291
$this->assertArrayHasKey('X-Magento-Tags', $responseMiss['headers']);
10392
$actualTags = explode(',', $responseMiss['headers']['X-Magento-Tags']);
@@ -130,18 +119,8 @@ public function testUrlResolverCachingForCMSPage()
130119
$page->load('page100');
131120
$cmsPageId = $page->getId();
132121
$requestPath = $page->getIdentifier();
133-
$query
134-
= <<<QUERY
135-
{
136-
urlResolver(url:"{$requestPath}")
137-
{
138-
id
139-
relative_url
140-
canonical_url
141-
type
142-
}
143-
}
144-
QUERY;
122+
123+
$query = $this->getUrlResolverQuery($requestPath);
145124
$responseMiss = $this->graphQlQueryWithResponseHeaders($query);
146125
$this->assertArrayHasKey('X-Magento-Tags', $responseMiss['headers']);
147126
$actualTags = explode(',', $responseMiss['headers']['X-Magento-Tags']);

dev/tests/integration/testsuite/Magento/GraphQlCache/Controller/Cms/CmsPageCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public function testToCheckCmsPageRequestCacheTags(): void
9696
$this->assertEquals(
9797
'MISS',
9898
$response->getHeader('X-Magento-Cache-Debug')->getFieldValue(),
99-
"expected MISS on page pageBlank dsdss id {$pageIdBlank}"
99+
"expected MISS on page pageBlank id {$pageIdBlank}"
100100
);
101101
$requestedCacheTags = explode(',', $response->getHeader('X-Magento-Tags')->getFieldValue());
102102
$expectedCacheTags = ['cms_p', 'cms_p_' .$pageIdBlank , 'FPC'];

0 commit comments

Comments
 (0)