ENGCOM-5686: Correct the return of type of function _columnBrake in module-theme block topMenu.php #24252

magento-engcom-team · magento-engcom-team · commit 3f3ef35d0f7b · 2019-08-23T09:14:24.000-05:00
- Merge Pull Request #24252 from Krielkip/magento2:2.3-develop - Merged commits: 1. 60ea2be 2. e9dd493
diff --git a/app/code/Magento/Theme/Block/Html/Topmenu.php b/app/code/Magento/Theme/Block/Html/Topmenu.php
@@ -133,15 +133,15 @@ protected function _countItems($items)
      *
      * @param Menu $items
      * @param int $limit
-     * @return array|void
+     * @return array
      *
      * @todo: Add Depth Level limit, and better logic for columns
      */
     protected function _columnBrake($items, $limit)
     {
         $total = $this->_countItems($items);
         if ($total <= $limit) {
-            return;
+            return [];
         }
 
         $result[] = ['total' => $total, 'max' => (int)ceil($total / ceil($total / $limit))];

Original file line number	Diff line number	Diff line change
`@@ -133,15 +133,15 @@ protected function _countItems($items)`
`133`	`133`	`*`
`134`	`134`	`* @param Menu $items`
`135`	`135`	`* @param int $limit`
`136`		`- * @return array\|void`
	`136`	`+ * @return array`
`137`	`137`	`*`
`138`	`138`	`* @todo: Add Depth Level limit, and better logic for columns`
`139`	`139`	`*/`
`140`	`140`	`protected function _columnBrake($items, $limit)`
`141`	`141`	`{`
`142`	`142`	`$total = $this->_countItems($items);`
`143`	`143`	`if ($total <= $limit) {`
`144`		`- return;`
	`144`	`+ return [];`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`$result[] = ['total' => $total, 'max' => (int)ceil($total / ceil($total / $limit))];`