Skip to content

Commit 3ebde7e

Browse files
author
Joan He
committed
MAGETWO-25343: Removed version from theme.xml
1 parent b68900d commit 3ebde7e

File tree

56 files changed

+26
-160
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+26
-160
lines changed

app/code/Magento/Core/Model/Theme.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
namespace Magento\Core\Model;
66

77
use Magento\Framework\View\Design\ThemeInterface;
8-
use Magento\Framework\App\Filesystem\DirectoryList;
98

109
/**
1110
* Theme model class
@@ -14,7 +13,6 @@
1413
* @method string getParentThemePath()
1514
* @method string getParentId()
1615
* @method string getThemeTitle()
17-
* @method string getThemeVersion()
1816
* @method string getPreviewImage()
1917
* @method bool getIsFeatured()
2018
* @method int getThemeId()
@@ -26,7 +24,6 @@
2624
* @method ThemeInterface setPackageCode(string $packageCode)
2725
* @method ThemeInterface setThemeCode(string $themeCode)
2826
* @method ThemeInterface setThemePath(string $themePath)
29-
* @method ThemeInterface setThemeVersion(string $themeVersion)
3027
* @method ThemeInterface setThemeTitle(string $themeTitle)
3128
* @method ThemeInterface setType(int $type)
3229
* @method ThemeInterface setCode(string $code)

app/code/Magento/Core/Model/Theme/Collection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ public function _prepareConfigurationData($configPath)
216216
'area' => $pathData['area'],
217217
'theme_path' => $themePath,
218218
'code' => $themeCode,
219-
'theme_version' => $themeConfig->getThemeVersion(),
220219
'theme_title' => $themeConfig->getThemeTitle(),
221220
'preview_image' => $media['preview_image'] ? $media['preview_image'] : null,
222221
'parent_theme_path' => $parentPath

app/code/Magento/Core/Model/Theme/Domain/Virtual.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ protected function _createStagingTheme()
118118
[
119119
'parent_id' => $this->_theme->getId(),
120120
'theme_path' => null,
121-
'theme_version' => $this->_theme->getThemeVersion(),
122121
'theme_title' => sprintf('%s - Staging', $this->_theme->getThemeTitle()),
123122
'preview_image' => $this->_theme->getPreviewImage(),
124123
'is_featured' => $this->_theme->getIsFeatured(),

app/code/Magento/Core/etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
*/
66
-->
77
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
8-
<module name="Magento_Core" schema_version="2.0.0">
8+
<module name="Magento_Core" schema_version="2.0.1">
99
</module>
1010
</config>
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<?php
2+
/**
3+
* @copyright Copyright (c) 2014 X.commerce, Inc. (http://www.magentocommerce.com)
4+
*/
5+
6+
/* @var $installer \Magento\Setup\Module\SetupModule */
7+
$installer = $this;
8+
9+
$installer->startSetup();
10+
$connection = $installer->getConnection();
11+
12+
/**
13+
* Remove column 'theme_version' from 'core_theme'
14+
*/
15+
$connection->dropColumn(
16+
$installer->getTable('core_theme'),
17+
'theme_version'
18+
);
19+
20+
$installer->endSetup();

app/code/Magento/Theme/Block/Adminhtml/System/Design/Theme/Edit/Tab/General.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,6 @@ protected function _addThemeFieldset($form, $formData, ThemeInterface $theme)
154154
);
155155
}
156156

157-
$themeFieldset->addField(
158-
'theme_version',
159-
$this->_getFieldTextType(),
160-
[
161-
'label' => __('Theme Version'),
162-
'title' => __('Theme Version'),
163-
'name' => 'theme_version',
164-
'required' => $this->_isFieldAttrRequired(),
165-
'note' => $this->_filterFieldNote(__('Example: 0.0.0.1 or 123.1.0.25-alpha1'))
166-
]
167-
);
168-
169157
$themeFieldset->addField(
170158
'theme_title',
171159
$this->_getFieldTextType(),
@@ -281,7 +269,6 @@ public function canShowTab()
281269
protected function _getDefaults()
282270
{
283271
$defaults = [];
284-
$defaults['theme_version'] = '0.0.0.1';
285272
$defaults['theme_title'] = __('New Theme');
286273

287274
return $defaults;

app/code/Magento/Theme/view/adminhtml/layout/adminhtml_system_design_theme_block.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,6 @@
5151
<argument name="column_css_class" xsi:type="string">theme-path</argument>
5252
</arguments>
5353
</block>
54-
<block class="Magento\Backend\Block\Widget\Grid\Column" as="theme_version">
55-
<arguments>
56-
<argument name="header" xsi:type="string" translate="true">Theme Version</argument>
57-
<argument name="index" xsi:type="string">theme_version</argument>
58-
<argument name="filter_index" xsi:type="string">main_table.theme_version</argument>
59-
<argument name="column_css_class" xsi:type="string">theme-version</argument>
60-
</arguments>
61-
</block>
6254
</block>
6355
</block>
6456
</referenceBlock>

app/design/adminhtml/Magento/backend/theme.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento 2 backend</title>
8-
<version>0.1.0</version>
98
</theme>

app/design/frontend/Magento/blank/theme.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento Blank</title>
8-
<version>0.1.0</version>
98
<media>
109
<preview_image>media/preview.jpg</preview_image>
1110
</media>

app/design/frontend/Magento/luma/theme.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
-->
66
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
77
<title>Magento Luma</title>
8-
<version>0.1.0</version>
98
<parent>Magento/blank</parent>
109
<media>
1110
<preview_image>media/preview.jpg</preview_image>

0 commit comments

Comments
 (0)