Skip to content

Commit 3ea9249

Browse files
committed
Merge remote-tracking branch 'mainline/develop' into prs
2 parents dba8e16 + d085f88 commit 3ea9249

File tree

113 files changed

+2634
-1413
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+2634
-1413
lines changed

app/code/Magento/Authorization/Setup/InstallSchema.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
138138
'role_id',
139139
$installer->getTable('authorization_role'),
140140
'role_id',
141-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
142141
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
143142
)->setComment(
144143
'Admin Rule Table'

app/code/Magento/Bundle/Setup/InstallSchema.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
7979
'parent_id',
8080
$installer->getTable('catalog_product_entity'),
8181
'entity_id',
82-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
8382
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
8483
)
8584
->setComment('Catalog Product Bundle Option');
@@ -138,7 +137,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
138137
'option_id',
139138
$installer->getTable('catalog_product_bundle_option'),
140139
'option_id',
141-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
142140
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
143141
)
144142
->setComment('Catalog Product Bundle Option Value');
@@ -238,7 +236,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
238236
'option_id',
239237
$installer->getTable('catalog_product_bundle_option'),
240238
'option_id',
241-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
242239
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
243240
)
244241
->addForeignKey(
@@ -251,7 +248,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
251248
'product_id',
252249
$installer->getTable('catalog_product_entity'),
253250
'entity_id',
254-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
255251
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
256252
)
257253
->setComment('Catalog Product Bundle Selection');
@@ -305,7 +301,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
305301
'website_id',
306302
$installer->getTable('store_website'),
307303
'website_id',
308-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
309304
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
310305
)
311306
->addForeignKey(
@@ -318,7 +313,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
318313
'selection_id',
319314
$installer->getTable('catalog_product_bundle_selection'),
320315
'selection_id',
321-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
322316
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
323317
)
324318
->setComment('Catalog Product Bundle Selection Price');
@@ -383,7 +377,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
383377
'customer_group_id',
384378
$installer->getTable('customer_group'),
385379
'customer_group_id',
386-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
387380
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
388381
)
389382
->addForeignKey(
@@ -396,7 +389,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
396389
'entity_id',
397390
$installer->getTable('catalog_product_entity'),
398391
'entity_id',
399-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
400392
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
401393
)
402394
->addForeignKey(
@@ -409,7 +401,6 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
409401
'website_id',
410402
$installer->getTable('store_website'),
411403
'website_id',
412-
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE,
413404
\Magento\Framework\DB\Ddl\Table::ACTION_CASCADE
414405
)
415406
->setComment('Catalog Product Bundle Price Index');

app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function getValuesHtml()
4646
if ($_option->getType() == \Magento\Catalog\Model\Product\Option::OPTION_TYPE_DROP_DOWN) {
4747
$select->setName('options[' . $_option->getid() . ']')->addOption('', __('-- Please Select --'));
4848
} else {
49-
$select->setName('options[' . $_option->getid() . '][]');
49+
$select->setName('options[' . $_option->getid() . ']');
5050
$select->setClass('multiselect admin__control-multiselect' . $require . ' product-custom-option');
5151
}
5252
foreach ($_option->getValues() as $_value) {
@@ -141,7 +141,7 @@ public function getValuesHtml()
141141
' name="options[' .
142142
$_option->getId() .
143143
']' .
144-
$arraySign .
144+
(!empty($arraySign) ? '[' . $htmlValue . ']' : '') .
145145
'" id="options_' .
146146
$_option->getId() .
147147
'_' .

0 commit comments

Comments
 (0)