MAGETWO-91934: Unlock Locales Editing when SCD on Demand Mode is Enabled

 - fixed static tests

Author: NadiyaS

app/code/Magento/Config/Test/Unit/Model/Config/Structure/ElementVisibility/ConcealScdFieldTest.php

@@ -64,9 +64,13 @@ protected function setUp()
      * @param bool $isHidden
      * @dataProvider disabledDataProvider
      */
-    public function testCheckVisibility(string $path, string $mageMode,
-                                        int $scdOnDemand, bool $isHidden, bool $isDisabled): void
-    {
+    public function testCheckVisibility(
+        string $path,
+        string $mageMode,
+        int $scdOnDemand,
+        bool $isHidden,
+        bool $isDisabled
+    ): void {
         $this->stateMock->expects($this->any())
             ->method('getMode')
             ->willReturn($mageMode);

lib/internal/Magento/Framework/Locale/Test/Unit/Deployed/OptionsTest.php

@@ -83,9 +83,11 @@ protected function setUp()
      * @param string $mode
      * @param int $scdOnDemand
      * @param array $locales
+     * @return void
+     *
      * @dataProvider getFullLocalesDataProvider
      */
-    public function testGetOptionLocalesFull($mode, $scdOnDemand, $locales)
+    public function testGetOptionLocalesFull(string $mode, int $scdOnDemand, array $locales): void
     {
         $this->localeListsMock->expects($this->once())
             ->method('getOptionLocales')
@@ -100,9 +102,11 @@ public function testGetOptionLocalesFull($mode, $scdOnDemand, $locales)
      * @param string $mode
      * @param int $scdOnDemand
      * @param array $locales
+     * @return void
+     *
      * @dataProvider getFullLocalesDataProvider
      */
-    public function testGetTranslatedOptionLocalesFull($mode, $scdOnDemand, $locales)
+    public function testGetTranslatedOptionLocalesFull(string $mode, int $scdOnDemand, array $locales): void
     {
         $this->localeListsMock->expects($this->once())
             ->method('getTranslatedOptionLocales')
@@ -119,10 +123,17 @@ public function testGetTranslatedOptionLocalesFull($mode, $scdOnDemand, $locales
      * @param array $locales
      * @param array $expectedLocales
      * @param array $deployedCodes
+     * @return void
+     *
      * @dataProvider getLimitedLocalesDataProvider
      */
-    public function testGetOptionLocalesLimited($mode, $scdOnDemand, $locales, $expectedLocales, $deployedCodes)
-    {
+    public function testGetOptionLocalesLimited(
+        string $mode,
+        int $scdOnDemand,
+        array $locales,
+        array $expectedLocales,
+        array $deployedCodes
+    ): void {
         $this->localeListsMock->expects($this->once())
             ->method('getOptionLocales')
             ->willReturn($locales);
@@ -138,11 +149,17 @@ public function testGetOptionLocalesLimited($mode, $scdOnDemand, $locales, $expe
      * @param array $locales
      * @param array $expectedLocales
      * @param array $deployedCodes
+     * @return void
+     *
      * @dataProvider getLimitedLocalesDataProvider
      */
-    public function testGetTranslatedOptionLocalesLimited($mode, $scdOnDemand, $locales,
-                                                          $expectedLocales, $deployedCodes)
-    {
+    public function testGetTranslatedOptionLocalesLimited(
+        string $mode,
+        int $scdOnDemand,
+        array $locales,
+        array $expectedLocales,
+        array $deployedCodes
+    ): void {
         $this->localeListsMock->expects($this->once())
             ->method('getTranslatedOptionLocales')
             ->willReturn($locales);
@@ -153,12 +170,12 @@ public function testGetTranslatedOptionLocalesLimited($mode, $scdOnDemand, $loca
     }
 
     /**
-     * @param $mode
+     * @param string $mode
      * @param int $scdOnDemand
-     * @param $deployedCodes
+     * @param array $deployedCodes
      * @return void
      */
-    private function prepareGetLocalesLimited($mode, $scdOnDemand, $deployedCodes)
+    private function prepareGetLocalesLimited(string $mode, int $scdOnDemand, $deployedCodes): void
     {
         $this->stateMock->expects($this->once())
             ->method('getMode')
@@ -188,11 +205,11 @@ private function prepareGetLocalesLimited($mode, $scdOnDemand, $deployedCodes)
     }
 
     /**
-     * @param $mode
+     * @param string $mode
      * @param int $scdOnDemand
      * @return void
      */
-    private function prepareGetLocalesFull($mode, $scdOnDemand)
+    private function prepareGetLocalesFull(string $mode, int $scdOnDemand): void
     {
         $this->stateMock->expects($this->once())
             ->method('getMode')
@@ -209,7 +226,7 @@ private function prepareGetLocalesFull($mode, $scdOnDemand)
     /**
      * @return array
      */
-    public function getFullLocalesDataProvider()
+    public function getFullLocalesDataProvider(): array
     {
         $deLocale = [
             'value' => 'de_DE',
@@ -252,7 +269,7 @@ public function getFullLocalesDataProvider()
     /**
      * @return array
      */
-    public function getLimitedLocalesDataProvider()
+    public function getLimitedLocalesDataProvider(): array
     {
         $deLocale = [
             'value' => 'de_DE',