B2B-2931: [Graphql Resolver Cache] improve reliability and developer awareness on cache keyspace

rganin · rganin · commit 3e193d842f80 · 2023-08-23T11:14:56.000-05:00
- fixed static tests failures
diff --git a/app/code/Magento/CatalogGraphQl/etc/graphql/di.xml b/app/code/Magento/CatalogGraphQl/etc/graphql/di.xml
@@ -275,7 +275,7 @@
     </type>
     <type name="Magento\GraphQlResolverCache\Model\Resolver\Result\CacheKey\Calculator\Provider">
         <arguments>
-            <argument name="customFactorProviders" xsi:type="array">
+            <argument name="factorProviders" xsi:type="array">
                 <item name="Magento\CatalogGraphQl\Model\Resolver\Product\MediaGallery" xsi:type="array">
                     <item name="parent_entity_id" xsi:type="string">Magento\CatalogGraphQl\Model\Resolver\CacheKey\FactorProvider\ParentProductEntityId</item>
                     <item name="store" xsi:type="string">Magento\StoreGraphQl\Model\Resolver\CacheKey\FactorProvider\Store</item>
diff --git a/dev/tests/integration/testsuite/Magento/GraphQlResolverCache/Model/Resolver/Result/Cache/KeyCalculator/ProviderTest.php b/dev/tests/integration/testsuite/Magento/GraphQlResolverCache/Model/Resolver/Result/Cache/KeyCalculator/ProviderTest.php
@@ -22,6 +22,7 @@
 /**
  * Test for Graphql Resolver-level cache key provider.
  * @magentoAppArea graphql
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ProviderTest extends \PHPUnit\Framework\TestCase
 {

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`/**`
`23`	`23`	`* Test for Graphql Resolver-level cache key provider.`
`24`	`24`	`* @magentoAppArea graphql`
	`25`	`+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)`
`25`	`26`	`*/`
`26`	`27`	`class ProviderTest extends \PHPUnit\Framework\TestCase`
`27`	`28`	`{`