AC-12022::Upgrade monolog/monolog system dependency to the latest major version

Author: glo71317

app/code/Magento/Developer/Model/Logger/Handler/Debug.php

@@ -15,6 +15,7 @@
 use Magento\Framework\Exception\RuntimeException;
 use Magento\Framework\Filesystem\DriverInterface;
 use Magento\Framework\Logger\Handler\Debug as DebugHandler;
+use Monolog\LogRecord;
 
 /**
  * Enable/disable debug logging based on the store config setting
@@ -53,7 +54,7 @@ public function __construct(
     /**
      * @inheritdoc
      */
-    public function isHandling(array $record): bool
+    public function isHandling(LogRecord $record): bool
     {
         if ($this->deploymentConfig->isAvailable()) {
             return parent::isHandling($record) && $this->isLoggingEnabled();

app/code/Magento/Developer/Model/Logger/Handler/Syslog.php

@@ -10,6 +10,7 @@
 use Magento\Config\Setup\ConfigOptionsList;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\DeploymentConfig;
+use Monolog\LogRecord;
 
 /**
  * Enable/disable syslog logging based on the deployment config setting.
@@ -43,7 +44,7 @@ public function __construct(
     /**
      * @inheritdoc
      */
-    public function isHandling(array $record): bool
+    public function isHandling(LogRecord $record): bool
     {
         return parent::isHandling($record)
             && $this->deploymentConfig->isDbAvailable()

app/code/Magento/Developer/Test/Unit/Model/Logger/Handler/SyslogTest.php

@@ -12,6 +12,7 @@
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Logger\Monolog;
+use Monolog\LogRecord;
 use PHPUnit\Framework\MockObject\MockObject as Mock;
 use PHPUnit\Framework\TestCase;
 
@@ -35,13 +36,19 @@ class SyslogTest extends TestCase
      */
     private $deploymentConfigMock;
 
+    /**
+     * @var LogRecord|Mock
+     */
+    private $logRecordMock;
+
     /**
      * @inheritdoc
      */
     protected function setUp(): void
     {
         $this->scopeConfigMock = $this->getMockForAbstractClass(ScopeConfigInterface::class);
         $this->deploymentConfigMock = $this->createMock(DeploymentConfig::class);
+        $this->logRecordMock = $this->createMock(LogRecord::class);
 
         $this->model = new Syslog(
             $this->deploymentConfigMock,
@@ -54,9 +61,9 @@ protected function setUp(): void
      */
     public function testIsHandling(): void
     {
-        $record = [
-            'level' => Monolog::DEBUG,
-        ];
+//        $record = [
+//            'level' => Monolog::DEBUG,
+//        ];
 
         $this->scopeConfigMock
             ->expects($this->never())
@@ -72,7 +79,7 @@ public function testIsHandling(): void
             ->willReturn(1);
 
         $this->assertTrue(
-            $this->model->isHandling($record)
+            $this->model->isHandling($this->logRecordMock)
         );
     }
 
@@ -81,9 +88,9 @@ public function testIsHandling(): void
      */
     public function testIsHandlingNotInstalled(): void
     {
-        $record = [
-            'level' => Monolog::DEBUG,
-        ];
+//        $record = [
+//            'level' => Monolog::DEBUG,
+//        ];
 
         $this->scopeConfigMock
             ->expects($this->never())
@@ -94,7 +101,7 @@ public function testIsHandlingNotInstalled(): void
             ->willReturn(false);
 
         $this->assertFalse(
-            $this->model->isHandling($record)
+            $this->model->isHandling($this->logRecordMock)
         );
     }
 
@@ -103,9 +110,9 @@ public function testIsHandlingNotInstalled(): void
      */
     public function testIsHandlingDisabled(): void
     {
-        $record = [
-            'level' => Monolog::DEBUG,
-        ];
+//        $record = [
+//            'level' => Monolog::DEBUG,
+//        ];
 
         $this->scopeConfigMock
             ->expects($this->never())
@@ -121,7 +128,7 @@ public function testIsHandlingDisabled(): void
             ->willReturn(0);
 
         $this->assertFalse(
-            $this->model->isHandling($record)
+            $this->model->isHandling($this->logRecordMock)
         );
     }
 }

lib/internal/Magento/Framework/Logger/Handler/Base.php

@@ -13,6 +13,7 @@
 use Monolog\Formatter\LineFormatter;
 use Monolog\Handler\StreamHandler;
 use Monolog\Logger;
+use Monolog\LogRecord;
 
 /**
  * Base stream handler
@@ -87,7 +88,7 @@ private function sanitizeFileName(string $fileName): string
     /**
      * @inheritDoc
      */
-    protected function write(array $record): void
+    protected function write(LogRecord $record): void
     {
         $logDir = $this->filesystem->getParentDirectory($this->url);
 

lib/internal/Magento/Framework/Logger/Handler/System.php

@@ -11,6 +11,7 @@
 use Magento\Framework\Filesystem\DriverInterface;
 use Magento\Framework\Logger\Handler\Exception as ExceptionHandler;
 use Monolog\Logger;
+use Monolog\LogRecord;
 
 /**
  * System stream handler
@@ -53,7 +54,7 @@ public function __construct(
      * @param array $record The record metadata
      * @return void
      */
-    public function write(array $record): void
+    public function write(LogRecord $record): void
     {
         if (isset($record['context']['exception'])) {
             $this->exceptionHandler->handle($record);