Fixed assertDefinitionEqual column type test

Nuranto · Nuranto · commit 3d14e8c861b6 · 2021-03-30T08:23:43.000+02:00
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/ValidationRules/IncosistentReferenceDefinition.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/ValidationRules/IncosistentReferenceDefinition.php
@@ -40,7 +40,7 @@ private function assertDefinitionEqual(Column $column, Column $referenceColumn)
          * Columns should have the same types
          */
         if ($column->getType() !== $referenceColumn->getType()) {
-            return true;
+            return false;
         }
 
         return $this->assertUnsigned($column, $referenceColumn) &&

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ private function assertDefinitionEqual(Column $column, Column $referenceColumn)`
`40`	`40`	`* Columns should have the same types`
`41`	`41`	`*/`
`42`	`42`	`if ($column->getType() !== $referenceColumn->getType()) {`
`43`		`- return true;`
	`43`	`+ return false;`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`return $this->assertUnsigned($column, $referenceColumn) &&`