Skip to content

Commit 3ce916f

Browse files
author
Stanislav Idolov
authored
ENGCOM-3358: [Forwardport] Prevent rendering of "Ship here" button to select a shipping item if it is already selected #18986
2 parents 44f70de + 591168e commit 3ce916f

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

app/code/Magento/Checkout/Test/Mftf/Section/CheckoutShippingMethodsSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<element name="shippingMethodRow" type="text" selector=".form.methods-shipping table tbody tr"/>
1515
<element name="checkShippingMethodByName" type="radio" selector="//div[@id='checkout-shipping-method-load']//td[contains(., '{{var1}}')]/..//input" parameterized="true"/>
1616
<element name="shippingMethodRowByName" type="text" selector="//div[@id='checkout-shipping-method-load']//td[contains(., '{{var1}}')]/.." parameterized="true"/>
17-
<element name="shipHereButton" type="button" selector="//button[contains(@class, 'action-select-shipping-item')]/parent::div/following-sibling::div/button[contains(@class, 'action-select-shipping-item')]"/>
17+
<element name="shipHereButton" type="button" selector="//div/following-sibling::div/button[contains(@class, 'action-select-shipping-item')]"/>
1818
<element name="shippingMethodLoader" type="button" selector="//div[contains(@class, 'checkout-shipping-method')]/following-sibling::div[contains(@class, 'loading-mask')]"/>
1919
</section>
2020
</sections>

app/code/Magento/Checkout/view/frontend/web/template/shipping-address/address-renderer/default.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@
3535
click="editAddress">
3636
<span translate="'Edit'"></span>
3737
</button>
38+
<!-- ko if: (!isSelected()) -->
3839
<button type="button" click="selectAddress" class="action action-select-shipping-item">
3940
<span translate="'Ship Here'"></span>
4041
</button>
42+
<!-- /ko -->
4143
</div>

app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_shipping.less

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@
9898
text-align: center;
9999
top: 0;
100100
}
101-
102-
.action-select-shipping-item {
103-
&:extend(.abs-no-display-s all);
104-
visibility: hidden;
105-
}
106101
}
107102
}
108103

0 commit comments

Comments
 (0)