Skip to content

Commit 3cd4694

Browse files
author
Dale Sikkema
committed
MAGETWO-44681: page cache entries not tagged with "FPC" cache type
- fix static tests
1 parent 6422081 commit 3cd4694

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

app/code/Magento/PageCache/Model/App/PageCachePlugin.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ class PageCachePlugin
1212
* Attach FPC tag to all saved entries to enable cache type management
1313
*
1414
* @param \Magento\Framework\App\PageCache\Cache $subject
15-
* @param $data
16-
* @param $identifier
17-
* @param array $tags
18-
* @param null $lifeTime
15+
* @param string $data
16+
* @param string $identifier
17+
* @param string[] $tags
18+
* @param int|null $lifeTime
1919
* @return array
20+
*
21+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2022
*/
2123
public function beforeSave(
2224
\Magento\Framework\App\PageCache\Cache $subject,

app/code/Magento/PageCache/Test/Unit/Model/App/PageCachePluginTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* See COPYING.txt for license details.
55
*/
66

7+
namespace Magento\PageCache\Test\Unit\Model\App;
8+
79
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
810
use Magento\PageCache\Model\Cache\Type;
911

0 commit comments

Comments
 (0)