Skip to content

Commit 3c5adaa

Browse files
committed
ACP2E-1200: fixed tests
1 parent 74d3b17 commit 3c5adaa

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

app/code/Magento/Quote/Plugin/SendOrderNotification.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace Magento\Quote\Plugin;
1010

1111
use Magento\Framework\Event\Observer;
12-
use Magento\Framework\Webapi\Rest\Request as RestRequest;
12+
use Magento\Framework\App\RequestInterface;
1313
use Magento\Quote\Observer\SubmitObserver;
1414
use Magento\Sales\Model\Order;
1515

@@ -19,14 +19,14 @@
1919
class SendOrderNotification
2020
{
2121
/**
22-
* @var RestRequest $request
22+
* @var RequestInterface $request
2323
*/
24-
private RestRequest $request;
24+
private RequestInterface $request;
2525

2626
/**
27-
* @param RestRequest $request
27+
* @param RequestInterface $request
2828
*/
29-
public function __construct(RestRequest $request)
29+
public function __construct(RequestInterface $request)
3030
{
3131
$this->request = $request;
3232
}
@@ -43,7 +43,7 @@ public function beforeExecute(SubmitObserver $subject, Observer $observer): arra
4343
{
4444
/** @var Order $order */
4545
$order = $observer->getEvent()->getOrder();
46-
$requestInfo = $this->request->getPostValue('order');
46+
$requestInfo = $this->request->getParam('order');
4747
$order->setCanSendNewEmailFlag((bool)($requestInfo['send_confirmation'] ?? 0));
4848

4949
return [$observer];

app/code/Magento/Quote/Test/Unit/Plugin/SendOrderNotificationTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
namespace Magento\Quote\Test\Unit\Plugin;
99

1010
use Magento\Framework\Event\Observer;
11-
use Magento\Framework\Webapi\Rest\Request as RestRequest;
11+
use Magento\Framework\App\RequestInterface;
1212
use Magento\Quote\Observer\SubmitObserver;
1313
use Magento\Quote\Plugin\SendOrderNotification;
1414
use PHPUnit\Framework\MockObject\MockObject;
@@ -22,9 +22,9 @@
2222
class SendOrderNotificationTest extends TestCase
2323
{
2424
/**
25-
* @var RestRequest|RestRequest&MockObject|MockObject
25+
* @var RequestInterface|RequestInterface&MockObject|MockObject
2626
*/
27-
private RestRequest $request;
27+
private RequestInterface $request;
2828

2929
/**
3030
* @var SubmitObserver|SubmitObserver&MockObject|MockObject
@@ -46,7 +46,7 @@ class SendOrderNotificationTest extends TestCase
4646
*/
4747
protected function setUp(): void
4848
{
49-
$this->request = $this->createMock(RestRequest::class);
49+
$this->request = $this->createMock(RequestInterface::class);
5050
$this->subject = $this->createMock(SubmitObserver::class);
5151
$this->observer = $this->createMock(Observer::class);
5252
$this->notification = new SendOrderNotification($this->request);
@@ -57,7 +57,7 @@ protected function setUp(): void
5757
*/
5858
public function testBeforeExecuteWithSendConfirmation()
5959
{
60-
$this->request->expects($this->once())->method('getPostValue')->with('order')
60+
$this->request->expects($this->once())->method('getParam')->with('order')
6161
->willReturn(['send_confirmation' => 1]);
6262

6363
$order = $this->getMockBuilder(Order::class)
@@ -88,7 +88,7 @@ public function testBeforeExecuteWithSendConfirmation()
8888
*/
8989
public function testBeforeExecuteWithoutSendConfirmation()
9090
{
91-
$this->request->expects($this->once())->method('getPostValue')->with('order')
91+
$this->request->expects($this->once())->method('getParam')->with('order')
9292
->willReturn(['order' => []]);
9393

9494
$order = $this->getMockBuilder(Order::class)

0 commit comments

Comments
 (0)