Skip to content

Commit 3bb2cb4

Browse files
committed
B2B-2606: Graphql Parser called at least 3 times per request
- Fixing actiongroup name & removing argument
1 parent 0c16a79 commit 3bb2cb4

6 files changed

+7
-10
lines changed

app/code/Magento/CheckoutAgreements/Test/Mftf/ActionGroup/AdminDeleteMultipleTermsActionGroup.xml renamed to app/code/Magento/CheckoutAgreements/Test/Mftf/ActionGroup/AdminDeleteAllTermConditionsActionGroup.xml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,15 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="AdminAllTermConditionsActionGroup">
10+
<actionGroup name="AdminDeleteAllTermConditionsActionGroup">
1111
<annotations>
1212
<description>Deletes all rows one by one on the 'Terms and Conditions' page.</description>
1313
</annotations>
14-
<arguments>
15-
<argument name="rowsToDelete" defaultValue="{{AdminTermGridSection.allTermRows}}" type="string"/>
16-
</arguments>
1714
<waitForElementVisible selector="{{AdminLegacyDataGridFilterSection.clear}}" stepKey="waitForResetFilter"/>
1815
<click selector="{{AdminLegacyDataGridFilterSection.clear}}" stepKey="clickResetFilter"/>
1916
<waitForPageLoad stepKey="waitForGridReset"/>
2017
<helper class="Magento\CheckoutAgreements\Test\Mftf\Helper\CheckoutAgreementsHelpers" method="deleteAllTermConditionRows" stepKey="deleteAllTermConditionRows">
21-
<argument name="rowsToDelete">{{rowsToDelete}}</argument>
18+
<argument name="rowsToDelete">{{AdminTermGridSection.allTermRows}}</argument>
2219
<argument name="deleteButton">{{AdminMainActionsSection.delete}}</argument>
2320
<argument name="modalAcceptButton">{{AdminConfirmationModalSection.ok}}</argument>
2421
<argument name="successMessage">You deleted the condition.</argument>

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/AdminCreateActiveHtmlTermEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<deleteData createDataKey="createProduct" stepKey="deletedProduct"/>
3434

3535
<actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
36-
<actionGroup ref="AdminAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
36+
<actionGroup ref="AdminDeleteAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
3737
<comment userInput="BIC workaround" stepKey="openTermToDelete"/>
3838
<comment userInput="BIC workaround" stepKey="deleteOpenedTerm"/>
3939

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/AdminCreateDisabledTextTermEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<deleteData createDataKey="createProduct" stepKey="deletedProduct"/>
3333

3434
<actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
35-
<actionGroup ref="AdminAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
35+
<actionGroup ref="AdminDeleteAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
3636
<comment userInput="BIC workaround" stepKey="openTermToDelete"/>
3737
<comment userInput="BIC workaround" stepKey="deleteOpenedTerm"/>
3838

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/AdminCreateEnabledTextTermOnMultishippingEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<deleteData createDataKey="createdProduct2" stepKey="deletedProduct2"/>
4242

4343
<actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
44-
<actionGroup ref="AdminAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
44+
<actionGroup ref="AdminDeleteAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
4545
<comment userInput="BIC workaround" stepKey="openTermToDelete"/>
4646
<comment userInput="BIC workaround" stepKey="deleteOpenedTerm"/>
4747

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/AdminUpdateDisabledHtmlTermEntityTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<deleteData createDataKey="createProduct" stepKey="deletedProduct"/>
3333

3434
<actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
35-
<actionGroup ref="AdminAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
35+
<actionGroup ref="AdminDeleteAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
3636
<comment userInput="BIC workaround" stepKey="openTermToDelete"/>
3737
<comment userInput="BIC workaround" stepKey="deleteOpenedTerm"/>
3838

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/StoreFrontManualTermsAndConditionsTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<deleteData createDataKey="testCategory" stepKey="deleteTestCategory"/>
5151
<magentoCLI command="config:set checkout/options/enable_agreements 0" stepKey="setDisableTermsOnCheckout"/>
5252
<actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
53-
<actionGroup ref="AdminAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
53+
<actionGroup ref="AdminDeleteAllTermConditionsActionGroup" stepKey="deleteAllTerms"/>
5454
<comment userInput="BIC workaround" stepKey="openTermToDelete"/>
5555
<comment userInput="BIC workaround" stepKey="deleteOpenedTerm"/>
5656
<magentoCLI command="config:set {{CashOnDeliveryDisabledConfigData.path}} {{CashOnDeliveryDisabledConfigData.value}}" stepKey="disabledCashOnDelivery"/>

0 commit comments

Comments
 (0)