Fix codacy unused variable in for, and improve condition

enriquei4 · enriquei4 · commit 3bab7142a508 · 2018-01-19T11:09:57.000+01:00
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Validate.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Validate.php
@@ -110,8 +110,8 @@ public function execute()
                 $options
             );
             $valueOptions = (isset($options['value']) && is_array($options['value'])) ? $options['value'] : [];
-            foreach ($valueOptions as $key => $valueOption) {
-                if (isset($options['delete'][$key]) && $options['delete'][$key]) {
+            foreach (array_keys($valueOptions) as $key) {
+                if (!empty($options['delete'][$key])) {
                     unset($valueOptions[$key]);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,8 @@ public function execute()`
`110`	`110`	`$options`
`111`	`111`	`);`
`112`	`112`	`$valueOptions = (isset($options['value']) && is_array($options['value'])) ? $options['value'] : [];`
`113`		`- foreach ($valueOptions as $key => $valueOption) {`
`114`		`- if (isset($options['delete'][$key]) && $options['delete'][$key]) {`
	`113`	`+ foreach (array_keys($valueOptions) as $key) {`
	`114`	`+ if (!empty($options['delete'][$key])) {`
`115`	`115`	`unset($valueOptions[$key]);`
`116`	`116`	`}`
`117`	`117`	`}`