Skip to content

Commit 3a27449

Browse files
engcom-Foxtrotengcom-Foxtrot
committed
MFTF tests updates.
1 parent 8e4af1b commit 3a27449

8 files changed

+5
-20
lines changed

‎app/code/Magento/LoginAsCustomer/Test/Mftf/ActionGroup/AdminLoginAsCustomerLogPageNotAvailableActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
<amOnPage url="{{AdminLoginAsCustomerLogPage.url}}" stepKey="openAdminLoginAsCustomerLogPage"/>
1717
<waitForPageLoad stepKey="waitForLoginAsCustomerLogPageLoad"/>
18-
<see userInput="Sorry, you need permissions to view this content."
19-
selector="{{AdminMessagesSection.accessDenied}}" stepKey="seeAccessDenied"/>
18+
<see userInput="404 Error" selector="{{AdminHeaderSection.pageHeading}}" stepKey="see404PageHeading"/>
2019
</actionGroup>
2120
</actionGroups>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/ActionGroup/AdminLoginAsCustomerLoginFromCustomerPageActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
<click selector="{{AdminCustomerMainActionsSection.loginAsCustomer}}" stepKey="clickLoginAsCustomerLink"/>
2222
<see selector="{{AdminConfirmationModalSection.title}}" userInput="You are about to Login as Customer"
2323
stepKey="seeModal"/>
24-
<!-- TODO: Unskip after https://github.com/magento/magento2-login-as-customer/issues/137 is fixed-->
25-
<!-- <see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in "Login as Customer" will affect actual customer data." stepKey="seeModalMessage"/>-->
24+
<see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in &quot;Login as Customer&quot; will affect actual customer data." stepKey="seeModalMessage"/>
2625
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="clickLogin"/>
2726
<switchToNextTab stepKey="switchToNewTab"/>
2827
<waitForPageLoad stepKey="waitForPageLoad"/>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/ActionGroup/AdminLoginAsCustomerLoginFromCustomerPageManualChooseActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
<waitForPageLoad stepKey="waitForCustomerPageLoad"/>
2222
<click selector="{{AdminCustomerMainActionsSection.loginAsCustomer}}" stepKey="clickLoginAsCustomerLink"/>
2323
<see selector="{{AdminConfirmationModalSection.title}}" userInput="Login as Customer: Select Store View" stepKey="seeModal"/>
24-
<!-- TODO: Unskip after https://github.com/magento/magento2-login-as-customer/issues/137 is fixed-->
25-
<!-- <see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in "Login as Customer" will affect actual customer data." stepKey="seeModalMessage"/>-->
24+
<see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in &quot;Login as Customer&quot; will affect actual customer data." stepKey="seeModalMessage"/>
2625
<selectOption selector="{{AdminLoginAsCustomerConfirmationModalSection.storeView}}" userInput="{{storeViewName}}" stepKey="selectStoreView"/>
2726
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="clickLogin"/>
2827
<switchToNextTab stepKey="switchToNewTab"/>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/ActionGroup/AdminLoginAsCustomerLoginFromOrderPageActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
<click selector="{{AdminOrderDetailsMainActionsSection.loginAsCustomer}}" stepKey="clickLoginAsCustomerLink"/>
2222
<see selector="{{AdminConfirmationModalSection.title}}" userInput="You are about to Login as Customer"
2323
stepKey="seeModal"/>
24-
<!-- TODO: Unskip after https://github.com/magento/magento2-login-as-customer/issues/137 is fixed-->
25-
<!-- <see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in "Login as Customer" will affect actual customer data." stepKey="seeModalMessage"/>-->
24+
<see selector="{{AdminConfirmationModalSection.message}}" userInput="Actions taken while in &quot;Login as Customer&quot; will affect actual customer data." stepKey="seeModalMessage"/>
2625
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="clickLogin"/>
2726
<switchToNextTab stepKey="switchToNewTab"/>
2827
<waitForPageLoad stepKey="waitForPageLoad"/>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerAutoDetectionTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
value="Verify admin user can directly login into customer account to Default store view when Store View To Login In = Auto detection"/>
1919
<severity value="BLOCKER"/>
2020
<group value="login_as_customer"/>
21-
<skip>
22-
<issueId value="https://github.com/magento/magento2-login-as-customer/pull/135"/>
23-
</skip>
2421
</annotations>
2522
<before>
2623
<createData entity="Simple_US_Customer" stepKey="createCustomer"/>
@@ -60,7 +57,6 @@
6057
<argument name="customerFullName" value="$$createCustomer.firstname$$ $$createCustomer.lastname$$"/>
6158
<argument name="customerEmail" value="$$createCustomer.email$$"/>
6259
</actionGroup>
63-
<actionGroup ref="StorefrontClickOnHeaderLogoActionGroup" stepKey="clickOnStorefrontHeaderLogo"/>
6460
<actionGroup ref="AssertStorefrontStoreCodeInUrlActionGroup" stepKey="seeDefaultStoreCodeInUrl"/>
6561

6662
<!-- Log out Customer and close tab -->

‎app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerDirectlyToCustomWebsiteTest.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
value="Verify admin user can directly login into customer account on custom website using 'Login as customer' functionality"/>
1818
<severity value="BLOCKER"/>
1919
<group value="login_as_customer"/>
20-
<skip>
21-
<issueId value="https://github.com/magento/magento2-login-as-customer/issues/102"/>
22-
</skip>
2320
</annotations>
2421
<before>
2522
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 1"
@@ -77,7 +74,6 @@
7774
</actionGroup>
7875

7976
<!-- Assert Customer logged on Custom Website -->
80-
<actionGroup ref="StorefrontClickOnHeaderLogoActionGroup" stepKey="clickOnStorefrontHeaderLogo"/>
8177
<actionGroup ref="AssertStorefrontStoreCodeInUrlActionGroup" stepKey="seeStoreCodeInUrl">
8278
<argument name="storeCode" value="{{customStoreEN.code}}"/>
8379
</actionGroup>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerLogNotShownIfLoginAsCustomerDisabledTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
<description value="Verify that 'Login As Customer Log' not shown if 'Login as customer' functionality is disabled"/>
1717
<severity value="CRITICAL"/>
1818
<group value="login_as_customer"/>
19-
<skip>
20-
<issueId value="https://github.com/magento/magento2-login-as-customer/issues/136"/>
21-
</skip>
2219
</annotations>
2320
<before>
2421
<magentoCLI command="config:set {{LoginAsCustomerConfigDataEnabled.path}} 0" stepKey="disableLoginAsCustomer"/>

‎app/code/Magento/LoginAsCustomer/Test/Mftf/Test/AdminLoginAsCustomerManualChooseTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<severity value="CRITICAL"/>
2020
<group value="login_as_customer"/>
2121
<skip>
22-
<issueId value="https://github.com/magento/magento2-login-as-customer/issues/102"/>
22+
<issueId value="https://github.com/magento/magento2-login-as-customer/issues/58"/>
2323
</skip>
2424
</annotations>
2525
<before>

0 commit comments

Comments
 (0)