Skip to content

Commit 3a1fdce

Browse files
author
Prabhu Ram
committed
MC-20648: Implement the changes
- Removed parameter enforcements and marked DiscountDataInterface with @api
1 parent 62f084b commit 3a1fdce

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

app/code/Magento/SalesRule/Api/Data/DiscountDataInterface.php

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,65 +7,68 @@
77

88
namespace Magento\SalesRule\Api\Data;
99

10+
/**
11+
* @api
12+
*/
1013
interface DiscountDataInterface
1114
{
1215
/**
1316
* Get Amount
1417
*
1518
* @return float
1619
*/
17-
public function getAmount(): float;
20+
public function getAmount();
1821

1922
/**
2023
* Set Amount
2124
*
2225
* @param float $amount
2326
* @return $this
2427
*/
25-
public function setAmount(float $amount);
28+
public function setAmount($amount);
2629

2730
/**
2831
* Get Base Amount
2932
*
3033
* @return float
3134
*/
32-
public function getBaseAmount(): float;
35+
public function getBaseAmount();
3336

3437
/**
3538
* Set Base Amount
3639
*
3740
* @param float $baseAmount
3841
* @return $this
3942
*/
40-
public function setBaseAmount(float $baseAmount);
43+
public function setBaseAmount($baseAmount);
4144

4245
/**
4346
* Get Original Amount
4447
*
4548
* @return float
4649
*/
47-
public function getOriginalAmount(): float;
50+
public function getOriginalAmount();
4851

4952
/**
5053
* Set original Amount
5154
*
5255
* @param float $originalAmount
5356
* @return $this
5457
*/
55-
public function setOriginalAmount(float $originalAmount);
58+
public function setOriginalAmount($originalAmount);
5659

5760
/**
5861
* Get Base Original Amount
5962
*
6063
* @return float
6164
*/
62-
public function getBaseOriginalAmount(): float;
65+
public function getBaseOriginalAmount();
6366

6467
/**
6568
* Set base original Amount
6669
*
6770
* @param float $baseOriginalAmount
6871
* @return $this
6972
*/
70-
public function setBaseOriginalAmount(float $baseOriginalAmount);
73+
public function setBaseOriginalAmount($baseOriginalAmount);
7174
}

app/code/Magento/SalesRule/Model/Rule/Action/Discount/Data.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function __construct()
5050
* @param float $amount
5151
* @return $this
5252
*/
53-
public function setAmount(float $amount)
53+
public function setAmount($amount)
5454
{
5555
$this->amount = $amount;
5656
return $this;
@@ -61,7 +61,7 @@ public function setAmount(float $amount)
6161
*
6262
* @return float
6363
*/
64-
public function getAmount(): float
64+
public function getAmount()
6565
{
6666
return $this->amount;
6767
}
@@ -72,7 +72,7 @@ public function getAmount(): float
7272
* @param float $baseAmount
7373
* @return $this
7474
*/
75-
public function setBaseAmount(float $baseAmount)
75+
public function setBaseAmount($baseAmount)
7676
{
7777
$this->baseAmount = $baseAmount;
7878
return $this;
@@ -83,7 +83,7 @@ public function setBaseAmount(float $baseAmount)
8383
*
8484
* @return float
8585
*/
86-
public function getBaseAmount(): float
86+
public function getBaseAmount()
8787
{
8888
return $this->baseAmount;
8989
}
@@ -94,7 +94,7 @@ public function getBaseAmount(): float
9494
* @param float $originalAmount
9595
* @return $this
9696
*/
97-
public function setOriginalAmount(float $originalAmount)
97+
public function setOriginalAmount($originalAmount)
9898
{
9999
$this->originalAmount = $originalAmount;
100100
return $this;
@@ -105,7 +105,7 @@ public function setOriginalAmount(float $originalAmount)
105105
*
106106
* @return float
107107
*/
108-
public function getOriginalAmount(): float
108+
public function getOriginalAmount()
109109
{
110110
return $this->originalAmount;
111111
}
@@ -116,7 +116,7 @@ public function getOriginalAmount(): float
116116
* @param float $baseOriginalAmount
117117
* @return $this
118118
*/
119-
public function setBaseOriginalAmount(float $baseOriginalAmount)
119+
public function setBaseOriginalAmount($baseOriginalAmount)
120120
{
121121
$this->baseOriginalAmount = $baseOriginalAmount;
122122
return $this;
@@ -127,7 +127,7 @@ public function setBaseOriginalAmount(float $baseOriginalAmount)
127127
*
128128
* @return float
129129
*/
130-
public function getBaseOriginalAmount(): float
130+
public function getBaseOriginalAmount()
131131
{
132132
return $this->baseOriginalAmount;
133133
}

0 commit comments

Comments
 (0)