MC-5588: When using MysqlMQ messages are always set to complete even if exception occurs

danielrenaud · danielrenaud · commit 39b8e35c8a01 · 2018-11-27T15:35:50.000-06:00
diff --git a/app/code/Magento/MysqlMq/Model/Driver/Queue.php b/app/code/Magento/MysqlMq/Model/Driver/Queue.php
@@ -111,7 +111,6 @@ public function subscribe($callback)
             while ($envelope = $this->dequeue()) {
                 try {
                     call_user_func($callback, $envelope);
-                    $this->acknowledge($envelope);
                 } catch (\Exception $e) {
                     $this->reject($envelope);
                 }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,6 @@ public function subscribe($callback)`
`111`	`111`	`while ($envelope = $this->dequeue()) {`
`112`	`112`	`try {`
`113`	`113`	`call_user_func($callback, $envelope);`
`114`		`- $this->acknowledge($envelope);`
`115`	`114`	`} catch (\Exception $e) {`
`116`	`115`	`$this->reject($envelope);`
`117`	`116`	`}`