Added check for equality to return 0 This now covers all possible situations, returning a value that the usort function expects

luke-denton-aligent · rostyslav-hymon · commit 39202ba7c647 · 2018-04-26T08:56:14.000Z
diff --git a/app/code/Magento/Customer/Block/Account/Navigation.php b/app/code/Magento/Customer/Block/Account/Navigation.php
@@ -46,6 +46,10 @@ public function getLinks()
      */
     private function compare(SortLinkInterface $firstLink, SortLinkInterface $secondLink)
     {
+        if ($firstLink->getSortOrder() == $secondLink->getSortOrder()) {
+            return 0;
+        }
+
         return ($firstLink->getSortOrder() < $secondLink->getSortOrder()) ? -1 : 1;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,10 @@ public function getLinks()`
`46`	`46`	`*/`
`47`	`47`	`private function compare(SortLinkInterface $firstLink, SortLinkInterface $secondLink)`
`48`	`48`	`{`
	`49`	`+ if ($firstLink->getSortOrder() == $secondLink->getSortOrder()) {`
	`50`	`+ return 0;`
	`51`	`+ }`
	`52`	`+`
`49`	`53`	`return ($firstLink->getSortOrder() < $secondLink->getSortOrder()) ? -1 : 1;`
`50`	`54`	`}`
`51`	`55`	`}`