Skip to content

Commit 38f27f1

Browse files
author
Bohdan Korablov
committed
MAGETWO-56252: [PR] Delivery of bugfixes
1 parent 64ed899 commit 38f27f1

File tree

2 files changed

+14
-26
lines changed

2 files changed

+14
-26
lines changed

setup/src/Magento/Setup/Model/Grid/Module.php

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@
77
namespace Magento\Setup\Model\Grid;
88

99
use Magento\Framework\Composer\ComposerInformation;
10-
use Magento\Framework\Module\FullModuleList;
11-
use Magento\Framework\Module\ModuleList;
12-
use Magento\Framework\Module\PackageInfo;
13-
use Magento\Framework\Module\PackageInfoFactory;
14-
use Magento\Setup\Model\ObjectManagerProvider;
15-
use Magento\Setup\Model\PackagesData;
1610

1711
/**
1812
* Module grid
@@ -33,26 +27,26 @@ class Module
3327
/**
3428
* Module package info
3529
*
36-
* @var PackageInfo
30+
* @var \Magento\Framework\Module\PackageInfo
3731
*/
3832
private $packageInfo;
3933

4034
/**
41-
* @var ObjectManagerProvider
35+
* @var \Magento\Setup\Model\ObjectManagerProvider
4236
*/
4337
private $objectManagerProvider;
4438

4539
/**
4640
* Full Module info
4741
*
48-
* @var FullModuleList
42+
* @var \Magento\Framework\Module\FullModuleList
4943
*/
5044
private $fullModuleList;
5145

5246
/**
5347
* Module info
5448
*
55-
* @var ModuleList
49+
* @var \Magento\Framework\Module\ModuleList
5650
*/
5751
private $moduleList;
5852

@@ -62,25 +56,25 @@ class Module
6256
private $typeMapper;
6357

6458
/**
65-
* @var PackagesData
59+
* @var \Magento\Setup\Model\PackagesData
6660
*/
6761
private $packagesData;
6862

6963
/**
7064
* @param ComposerInformation $composerInformation
71-
* @param FullModuleList $fullModuleList
72-
* @param ModuleList $moduleList
73-
* @param ObjectManagerProvider $objectManagerProvider
65+
* @param \Magento\Framework\Module\FullModuleList $fullModuleList
66+
* @param \Magento\Framework\Module\ModuleList $moduleList
67+
* @param \Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider
7468
* @param TypeMapper $typeMapper
75-
* @param PackagesData $packagesData
69+
* @param \Magento\Setup\Model\PackagesData $packagesData
7670
*/
7771
public function __construct(
7872
ComposerInformation $composerInformation,
79-
FullModuleList $fullModuleList,
80-
ModuleList $moduleList,
81-
ObjectManagerProvider $objectManagerProvider,
73+
\Magento\Framework\Module\FullModuleList $fullModuleList,
74+
\Magento\Framework\Module\ModuleList $moduleList,
75+
\Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider,
8276
TypeMapper $typeMapper,
83-
PackagesData $packagesData
77+
\Magento\Setup\Model\PackagesData $packagesData
8478
) {
8579
$this->composerInformation = $composerInformation;
8680
$this->fullModuleList = $fullModuleList;
@@ -98,7 +92,7 @@ public function __construct(
9892
public function getList()
9993
{
10094
$this->packageInfo = $this->objectManagerProvider->get()
101-
->get(PackageInfoFactory::class)
95+
->get(\Magento\Framework\Module\PackageInfoFactory::class)
10296
->create();
10397

10498
$items = array_replace_recursive(

setup/src/Magento/Setup/Test/Unit/Model/Grid/ModuleTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ class ModuleTest extends \PHPUnit_Framework_TestCase
7777
*/
7878
private $moduleData = [];
7979

80-
/**
81-
* @var array
82-
*/
83-
private $allComponentData = [];
84-
8580
public function setUp()
8681
{
8782
$this->moduleData = [
@@ -96,7 +91,6 @@ public function setUp()
9691
'Sample_ModuleOne', 'Sample_ModuleTwo'
9792
];
9893

99-
10094
$this->composerInformationMock = $this->getMockBuilder(ComposerInformation::class)
10195
->disableOriginalConstructor()
10296
->getMock();

0 commit comments

Comments
 (0)