Remove unecessaries ternary conditions

Author: carusogabriel

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/MediaGalleryTest.php

@@ -198,6 +198,6 @@ private function checkImageExists(string $url): bool
         curl_exec($connection);
         $responseStatus = curl_getinfo($connection, CURLINFO_HTTP_CODE);
         // phpcs:enable Magento2.Functions.DiscouragedFunction
-        return $responseStatus === 200 ? true : false;
+        return $responseStatus === 200;
     }
 }

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductImageTest.php

@@ -144,6 +144,6 @@ private function checkImageExists(string $url): bool
         curl_exec($connection);
         $responseStatus = curl_getinfo($connection, CURLINFO_HTTP_CODE);
 
-        return $responseStatus === 200 ? true : false;
+        return $responseStatus === 200;
     }
 }

dev/tests/functional/lib/Magento/Mtf/Client/Element/LiselectstoreElement.php

@@ -133,7 +133,7 @@ public function getValues()
      */
     protected function isSubstring($haystack, $pattern)
     {
-        return preg_match("/$pattern/", $haystack) != 0 ? true : false;
+        return preg_match("/$pattern/", $haystack) != 0;
     }
 
     /**

dev/tests/functional/tests/app/Magento/Bundle/Test/Block/Catalog/Product/View/Type/Bundle.php

@@ -311,7 +311,7 @@ public function fillBundleOptions($bundleOptions)
     {
         foreach ($bundleOptions as $option) {
             $selector = sprintf($this->bundleOptionBlock, $option['title']);
-            $useDefault = isset($option['use_default']) && strtolower($option['use_default']) == 'true' ? true : false;
+            $useDefault = isset($option['use_default']) && strtolower($option['use_default']) == 'true';
             if (!$useDefault) {
                 /** @var Option $optionBlock */
                 $optionBlock = $this->blockFactory->create(

dev/tests/functional/tests/app/Magento/Review/Test/TestCase/MassActionsProductReviewEntityTest.php

@@ -102,7 +102,7 @@ public function test($gridActions, $gridStatus)
         $this->reviewIndex->getReviewGrid()->massaction(
             [['title' => $this->review->getTitle()]],
             [$gridActions => $gridStatus],
-            ($gridActions == 'Delete' ? true : false)
+            ($gridActions == 'Delete')
         );
     }
 

lib/internal/Magento/Framework/Acl/AclResource/Config/Converter/Dom.php

@@ -53,7 +53,7 @@ protected function _convertResourceNode(\DOMNode $resourceNode)
         $sortOrderNode = $resourceAttributes->getNamedItem('sortOrder');
         $resourceData['sortOrder'] = $sortOrderNode !== null ? (int)$sortOrderNode->nodeValue : 0;
         $disabledNode = $resourceAttributes->getNamedItem('disabled');
-        $resourceData['disabled'] = $disabledNode !== null && $disabledNode->nodeValue == 'true' ? true : false;
+        $resourceData['disabled'] = $disabledNode !== null && $disabledNode->nodeValue == 'true';
         // convert child resource nodes if needed
         $resourceData['children'] = [];
         /** @var $childNode \DOMNode */

lib/internal/Magento/Framework/App/MaintenanceMode.php

@@ -110,7 +110,7 @@ public function setAddresses($addresses)
             throw new \InvalidArgumentException("One or more IP-addresses is expected (comma-separated)\n");
         }
         $result = $this->flagDir->writeFile(self::IP_FILENAME, $addresses);
-        return false !== $result ? true : false;
+        return false !== $result;
     }
 
     /**

lib/internal/Magento/Framework/Code/Reader/NamespaceResolver.php

@@ -50,7 +50,7 @@ public function resolveNamespace($type, array $availableNamespaces)
         ) {
             $name = explode(self::NS_SEPARATOR, $type);
             $unqualifiedName = $name[0];
-            $isQualifiedName = count($name) > 1 ? true : false;
+            $isQualifiedName = count($name) > 1;
             if (isset($availableNamespaces[$unqualifiedName])) {
                 $namespace = $availableNamespaces[$unqualifiedName];
                 if ($isQualifiedName) {

lib/internal/Magento/Framework/GraphQl/Schema/Type/ScalarTypes.php

@@ -21,7 +21,7 @@ class ScalarTypes
     public function isScalarType(string $typeName) : bool
     {
         $standardTypes = \GraphQL\Type\Definition\Type::getStandardTypes();
-        return isset($standardTypes[$typeName]) ? true : false;
+        return isset($standardTypes[$typeName]);
     }
 
     /**

lib/internal/Magento/Framework/HTTP/PhpEnvironment/Response.php

@@ -130,7 +130,7 @@ public function setHttpResponseCode($code)
             throw new \InvalidArgumentException('Invalid HTTP response code');
         }
 
-        $this->isRedirect = (300 <= $code && 307 >= $code) ? true : false;
+        $this->isRedirect = (300 <= $code && 307 >= $code);
 
         $this->setStatusCode($code);
         return $this;