Skip to content

Commit 38b8b51

Browse files
Merge remote-tracking branch '37309/fix-for-issue-37308' into comm_voted_v3
2 parents 0907c9f + 016bed9 commit 38b8b51

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

app/code/Magento/Theme/view/frontend/templates/messages.phtml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
*/
66
?>
77
<div data-bind="scope: 'messages'">
8-
<!-- ko if: cookieMessages && cookieMessages.length > 0 -->
9-
<div aria-atomic="true" role="alert" data-bind="foreach: { data: cookieMessages, as: 'message' }" class="messages">
8+
<!-- ko if: cookieMessagesObservable() && cookieMessagesObservable().length > 0 -->
9+
<div aria-atomic="true" role="alert" class="messages" data-bind="foreach: {
10+
data: cookieMessagesObservable(), as: 'message'
11+
}">
1012
<div data-bind="attr: {
1113
class: 'message-' + message.type + ' ' + message.type + ' message',
1214
'data-ui-id': 'message-' + message.type

app/code/Magento/Theme/view/frontend/web/js/view/messages.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ define([
1919
return Component.extend({
2020
defaults: {
2121
cookieMessages: [],
22+
cookieMessagesObservable: [],
2223
messages: [],
2324
allowedTags: ['div', 'span', 'b', 'strong', 'i', 'em', 'u', 'a']
2425
},
@@ -27,9 +28,18 @@ define([
2728
* Extends Component object by storage observable messages.
2829
*/
2930
initialize: function () {
30-
this._super();
31+
this._super().observe(
32+
[
33+
'cookieMessagesObservable'
34+
]
35+
);
3136

37+
// The "cookieMessages" variable is not used anymore. It exists for backward compatibility; to support
38+
// merchants who have overwritten "messages.phtml" which would still point to cookieMessages instead of the
39+
// observable variant (also see https://github.com/magento/magento2/pull/37309).
3240
this.cookieMessages = _.unique($.cookieStorage.get('mage-messages'), 'text');
41+
this.cookieMessagesObservable(this.cookieMessages);
42+
3343
this.messages = customerData.get('messages').extend({
3444
disposableCustomerData: 'messages'
3545
});

0 commit comments

Comments
 (0)