MAGETWO-69521: Customer attribute with "Show on Storefront" set to No does not appear in backend

Author: Sergii Kovalenko

app/code/Magento/Customer/Model/Customer/DataProvider.php

@@ -143,8 +143,10 @@ class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
      * @param Config $eavConfig
      * @param FilterPool $filterPool
      * @param FileProcessorFactory $fileProcessorFactory
+     * @param ContextInterface $context
      * @param array $meta
      * @param array $data
+     * @param bool $allowToShowHiddenAttributes
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -350,7 +352,6 @@ protected function getAttributesMeta(Type $entityType)
             $meta[$code]['arguments']['data']['config']['componentType'] = Field::NAME;
             $meta[$code]['arguments']['data']['config']['visible'] = $this->canShowAttribute($attribute);
 
-
             $this->overrideFileUploaderMetadata($entityType, $attribute, $meta[$code]['arguments']['data']['config']);
         }
 
@@ -359,30 +360,41 @@ protected function getAttributesMeta(Type $entityType)
     }
 
     /**
-     * Detect can we show attribute on specific form or not
+     * Check whether the specific attribute can be shown in form: customer registration, customer edit, etc...
      *
      * @param Attribute $customerAttribute
      * @return bool
      */
-    private function canShowAttribute(AbstractAttribute $customerAttribute)
+    private function canShowAttributeInForm(AbstractAttribute $customerAttribute)
     {
-        $isRegistration = is_null($this->context->getRequestParam($this->getRequestFieldName()));
-        $userDefined = (bool) $customerAttribute->getIsUserDefined();
-
-        if (!$userDefined) {
-            return $customerAttribute->getIsVisible();
-        }
+        $isRegistration = $this->context->getRequestParam($this->getRequestFieldName()) === null;
 
         if ($customerAttribute->getEntityType()->getEntityTypeCode() === 'customer') {
-            $canShowOnForm = is_array($customerAttribute->getUsedInForms()) &&
+            return is_array($customerAttribute->getUsedInForms()) &&
                 (
                     (in_array('customer_account_create', $customerAttribute->getUsedInForms()) && $isRegistration) ||
                     (in_array('customer_account_edit', $customerAttribute->getUsedInForms()) && !$isRegistration)
                 );
         } else {
-            $canShowOnForm = is_array($customerAttribute->getUsedInForms()) &&
+            return is_array($customerAttribute->getUsedInForms()) &&
                 in_array('customer_address_edit', $customerAttribute->getUsedInForms());
         }
+    }
+
+    /**
+     * Detect can we show attribute on specific form or not
+     *
+     * @param Attribute $customerAttribute
+     * @return bool
+     */
+    private function canShowAttribute(AbstractAttribute $customerAttribute)
+    {
+        $userDefined = (bool) $customerAttribute->getIsUserDefined();
+        if (!$userDefined) {
+            return $customerAttribute->getIsVisible();
+        }
+
+        $canShowOnForm = $this->canShowAttributeInForm($customerAttribute);
 
         return ($this->allowToShowHiddenAttributes && $canShowOnForm) ||
             (!$this->allowToShowHiddenAttributes && $canShowOnForm && $customerAttribute->getIsVisible());