MQE-975: Bump MFTF version in Magento and deliver all related changes to new version

- remove explicity exit code in function
- fix _bootstrap file

Author: imeron2433

dev/tests/acceptance/RoboFile.php

@@ -198,8 +198,7 @@ private function parseTestsConfigJson($json, $testConfiguration) {
 
         // stop execution if we have failed to properly parse any json
         if (json_last_error() != JSON_ERROR_NONE) {
-            $this->say("JSON could not be parsed: " . json_last_error_msg());
-            exit(1);
+            throw new \Magento\FunctionalTestingFramework\Exceptions\TestFrameworkException("JSON could not be parsed: " . json_last_error_msg());
         }
 
         $jsonTestConfiguration['tests'] = $testConfigArray['tests'] ?? null;;

dev/tests/acceptance/tests/_bootstrap.php

@@ -8,7 +8,7 @@
 $projectRootPath = $bootstrapRoot;
 
 // If we're under a vendor directory, find project root.
-if (strpos($bootstrapRoot, '/vendor') != 0) {
+if (strpos($bootstrapRoot, '/vendor') !== false) {
     $projectRootPath = substr($bootstrapRoot, 0, strpos($bootstrapRoot, '/vendor/'));
 }
 
@@ -28,9 +28,16 @@
 // Find framework path
 $COMPOSER_FW_FULL_PREFIX = $loader->getPrefixesPsr4()[$FW_PACKAGE_NAME][0] ?? null;
 if ($COMPOSER_FW_FULL_PREFIX === null) {
-    throw new Exception("You must have the magento/magento2-functional-testing-framework installed to be able to generate tests.");
+    throw new Exception(
+        "You must have the magento/magento2-functional-testing-framework 
+        installed to be able to generate tests."
+    );
 }
-$FW_PATH = substr($COMPOSER_FW_FULL_PREFIX, 0, strpos($COMPOSER_FW_FULL_PREFIX, "/src/Magento/FunctionalTestingFramework"));
+$FW_PATH = substr(
+    $COMPOSER_FW_FULL_PREFIX,
+    0,
+    strpos($COMPOSER_FW_FULL_PREFIX, "/src/Magento/FunctionalTestingFramework")
+);
 
 // Find tests path
 $COMPOSER_TEST_FULL_PREFIX = $loader->getPrefixesPsr4()[$TESTS_PACKAGE_NAME][0] ?? null;
@@ -41,18 +48,23 @@
     $TEST_PATH = $COMPOSER_TEST_FULL_PREFIX;
 }
 
-// We register "Magento\\" to "tests/functional/Magento" for our own class loading, need to try and find a prefix that isn't that one.
+// We register "Magento\\" to "tests/functional/Magento" for our own class loading, need to try and find a
+// prefix that isn't that one.
 $COMPOSER_MAGENTO_PREFIXES = $loader->getPrefixesPsr4()[$MAGENTO_PACKAGE_NAME];
 $COMPOSER_MAGENTO_FULL_PREFIX = null;
 foreach ($COMPOSER_MAGENTO_PREFIXES as $path) {
-    if (strpos($path, "tests/functional/Magento") == 0) {
+    if (strpos($path, "tests/functional/Magento") === 0) {
         $COMPOSER_MAGENTO_FULL_PREFIX = $path;
     }
 }
 if ($COMPOSER_MAGENTO_FULL_PREFIX === null) {
     $MAGENTO_PATH = dirname(__DIR__ . "/../../../../../");
 } else {
-    $MAGENTO_PATH = substr($COMPOSER_MAGENTO_FULL_PREFIX, 0, strpos($COMPOSER_MAGENTO_FULL_PREFIX, "/app/code/Magento"));
+    $MAGENTO_PATH = substr(
+        $COMPOSER_MAGENTO_FULL_PREFIX,
+        0,
+        strpos($COMPOSER_MAGENTO_FULL_PREFIX, "/app/code/Magento")
+    );
 }
 
 $RELATIVE_TESTS_MODULE_PATH = '/Magento/FunctionalTest';
@@ -65,14 +77,19 @@
     $env->load();
 
     if (array_key_exists('TESTS_MODULE_PATH', $_ENV) xor array_key_exists('TESTS_BP', $_ENV)) {
-        throw new Exception('You must define both parameters TESTS_BP and TESTS_MODULE_PATH or neither parameter');
+        throw new Exception(
+            'You must define both parameters TESTS_BP and TESTS_MODULE_PATH or neither parameter'
+        );
     }
 
     foreach ($_ENV as $key => $var) {
         defined($key) || define($key, $var);
     }
 
-    defined('MAGENTO_CLI_COMMAND_PATH') || define('MAGENTO_CLI_COMMAND_PATH', 'dev/tests/acceptance/utils/command.php');
+    defined('MAGENTO_CLI_COMMAND_PATH') || define(
+        'MAGENTO_CLI_COMMAND_PATH',
+        'dev/tests/acceptance/utils/command.php'
+    );
     $env->setEnvironmentVariable('MAGENTO_CLI_COMMAND_PATH', MAGENTO_CLI_COMMAND_PATH);
 
     defined('MAGENTO_CLI_COMMAND_PARAMETER') || define('MAGENTO_CLI_COMMAND_PARAMETER', 'command');
@@ -81,10 +98,13 @@
 
 defined('FW_BP') || define('FW_BP', realpath($FW_PATH));
 defined('TESTS_BP') || define('TESTS_BP', realpath($TEST_PATH));
-defined('TESTS_MODULE_PATH') || define('TESTS_MODULE_PATH', realpath($TEST_PATH . $RELATIVE_TESTS_MODULE_PATH));
+defined('TESTS_MODULE_PATH') || define(
+    'TESTS_MODULE_PATH',
+    realpath($TEST_PATH . $RELATIVE_TESTS_MODULE_PATH)
+);
 
 // add the debug flag here
 $debug_mode = $_ENV['MFTF_DEBUG'] ?? false;
 if (!(bool)$debug_mode && extension_loaded('xdebug')) {
     xdebug_disable();
-}
+}