MAGETWO-58691: Refactor Module_Quote, Module_Sales

buskamuza · buskamuza · commit 3894d3100863 · 2016-10-28T10:49:31.000-05:00
- simplified regexp for the static test
diff --git a/dev/tests/static/testsuite/Magento/Test/Legacy/UnsecureFunctionsUsageTest.php b/dev/tests/static/testsuite/Magento/Test/Legacy/UnsecureFunctionsUsageTest.php
@@ -159,10 +159,6 @@ private function prepareRegexp(array $functions)
         if (empty($functions)) {
             return '';
         }
-        $regexArray = [];
-        foreach ($functions as $function) {
-            $regexArray[] = '(?<!function |[^\s])\b' . $function . '\b\(';
-        }
-        return '/' . implode('|', $regexArray) . '/i';
+        return '/(?<!function |[^\s])\b(' . join('|', $functions) . ')\s*\(/i';
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -159,10 +159,6 @@ private function prepareRegexp(array $functions)`
`159`	`159`	`if (empty($functions)) {`
`160`	`160`	`return '';`
`161`	`161`	`}`
`162`		`- $regexArray = [];`
`163`		`- foreach ($functions as $function) {`
`164`		`- $regexArray[] = '(?<!function \|[^\s])\b' . $function . '\b\(';`
`165`		`- }`
`166`		`- return '/' . implode('\|', $regexArray) . '/i';`
	`162`	`+ return '/(?<!function \|[^\s])\b(' . join('\|', $functions) . ')\s*\(/i';`
`167`	`163`	`}`
`168`	`164`	`}`