Skip to content

Commit 3773134

Browse files
engcom-Echoengcom-Echo
committed
Mftf test, changed properties visibility
1 parent 52fdef4 commit 3773134

File tree

4 files changed

+96
-13
lines changed

4 files changed

+96
-13
lines changed

‎app/code/Magento/Indexer/Block/Backend/Grid/Column/Renderer/ScheduleStatus.php

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,16 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
declare(strict_types=1);
7+
68
namespace Magento\Indexer\Block\Backend\Grid\Column\Renderer;
79

10+
use Magento\Backend\Block\Context;
811
use Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer;
12+
use Magento\Framework\DataObject;
913
use Magento\Framework\Escaper;
1014
use Magento\Framework\Mview\View;
15+
use Magento\Framework\Mview\ViewInterface;
1116
use Magento\Framework\Phrase;
1217

1318
/**
@@ -16,23 +21,23 @@
1621
class ScheduleStatus extends AbstractRenderer
1722
{
1823
/**
19-
* @var \Magento\Framework\Escaper
24+
* @var Escaper
2025
*/
21-
protected $escaper;
26+
private $escaper;
2227

2328
/**
24-
* @var \Magento\Framework\Mview\ViewInterface
29+
* @var ViewInterface
2530
*/
26-
protected $viewModel;
31+
private $viewModel;
2732

28-
/**
29-
* @param \Magento\Backend\Block\Context $context
30-
* @param \Magento\Framework\Escaper $escaper
31-
* @param \Magento\Framework\Mview\ViewInterface $viewModel
32-
* @param array $data
33-
*/
33+
/**
34+
* @param Context $context
35+
* @param Escaper $escaper
36+
* @param ViewInterface $viewModel
37+
* @param array $data
38+
*/
3439
public function __construct(
35-
\Magento\Backend\Block\Context $context,
40+
Context $context,
3641
Escaper $escaper,
3742
View $viewModel,
3843
array $data = []
@@ -45,10 +50,10 @@ public function __construct(
4550
/**
4651
* Render indexer status
4752
*
48-
* @param \Magento\Framework\DataObject $row
53+
* @param DataObject $row
4954
* @return string
5055
*/
51-
public function render(\Magento\Framework\DataObject $row)
56+
public function render(DataObject $row)
5257
{
5358
try {
5459
if (!$row->getIsScheduled()) {

‎app/code/Magento/Indexer/Test/Mftf/Data/AdminIndexManagementGridData.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
10+
<entity name="AdminIndexManagementGridData">
11+
<data key="rowProductPrice">Product Price</data>
12+
</entity>
13+
</entities>

‎app/code/Magento/Indexer/Test/Mftf/Section/AdminIndexManagementSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@
1717
<element name="indexerStatus" type="text" selector="//tr[descendant::td[contains(., '{{status}}')]]//*[contains(@class, 'col-indexer_status')]/span" parameterized="true"/>
1818
<element name="successMessage" type="text" selector="//*[@data-ui-id='messages-message-success']" timeout="120"/>
1919
<element name="selectMassAction" type="select" selector="#gridIndexer_massaction-mass-select"/>
20+
<element name="columnScheduleStatus" type="text" selector="//th[contains(@class, 'col-indexer_schedule_status')]"/>
21+
<element name="indexerScheduleStatus" type="text" selector="//tr[contains(.,'{{var1}}')]//td[contains(@class,'col-indexer_schedule_status')]" parameterized="true"/>
2022
</section>
2123
</sections>

‎app/code/Magento/Indexer/Test/Mftf/Test/AdminSystemIndexManagementGridChangesTest.xml

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="AdminSystemIndexManagementGridChangesTest">
11+
<annotations>
12+
<features value="Indexer"/>
13+
<stories value="Menu Navigation"/>
14+
<title value="Admin system index management grid change test"/>
15+
<description value="Verify changes in 'Schedule column' on system index management"/>
16+
</annotations>
17+
<before>
18+
<createData entity="_defaultCategory" stepKey="createCategory"/>
19+
<createData entity="_defaultProduct" stepKey="createProduct">
20+
<requiredEntity createDataKey="createCategory"/>
21+
</createData>
22+
23+
<!--Open Index Management Page and Select Index mode "Update by Schedule" -->
24+
<magentoCLI command="indexer:set-mode" arguments="schedule" stepKey="setIndexerModeSchedule"/>
25+
<magentoCLI command="indexer:reindex" stepKey="indexerReindex"/>
26+
<magentoCLI command="cache:flush" stepKey="flushCache"/>
27+
<actionGroup ref="LoginAsAdmin" stepKey="LoginAsAdmin"/></before>
28+
<after>
29+
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
30+
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
31+
<magentoCLI command="indexer:set-mode" arguments="realtime" stepKey="setIndexerModeRealTime"/>
32+
<magentoCLI command="indexer:reindex" stepKey="indexerReindex"/>
33+
<magentoCLI command="cache:flush" stepKey="flushCache"/>
34+
<actionGroup ref="logout" stepKey="logout"/>
35+
</after>
36+
37+
<actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToIndexManagementPageFirst">
38+
<argument name="menuUiId" value="{{AdminMenuSystem.dataUiId}}"/>
39+
<argument name="submenuUiId" value="{{AdminMenuSystemToolsIndexManagement.dataUiId}}"/>
40+
</actionGroup>
41+
<grabTextFrom selector="{{AdminIndexManagementSection.indexerScheduleStatus(AdminIndexManagementGridData.rowProductPrice)}}" stepKey="gradScheduleStatusBeforeChange"/>
42+
43+
<!-- Verify 'Schedule status' column is present -->
44+
<seeElement selector="{{AdminIndexManagementSection.columnScheduleStatus}}" stepKey="seeScheduleStatusColumn"/>
45+
46+
<!--Adding Special price to product-->
47+
<amOnPage url="{{AdminProductEditPage.url($$createProduct.id$$)}}" stepKey="openAdminProductEditPage"/>
48+
<actionGroup ref="AddSpecialPriceToProductActionGroup" stepKey="addSpecialPrice"/>
49+
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProductForm"/>
50+
51+
<actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToIndexManagementPageSecond">
52+
<argument name="menuUiId" value="{{AdminMenuSystem.dataUiId}}"/>
53+
<argument name="submenuUiId" value="{{AdminMenuSystemToolsIndexManagement.dataUiId}}"/>
54+
</actionGroup>
55+
<grabTextFrom selector="{{AdminIndexManagementSection.indexerScheduleStatus(AdminIndexManagementGridData.rowProductPrice)}}" stepKey="gradScheduleStatusAfterChange"/>
56+
57+
<!-- Verify 'Schedule Status' column changes for 'Product Price' -->
58+
<assertNotEquals stepKey="assertChange">
59+
<expectedResult type="string">$gradScheduleStatusBeforeChange</expectedResult>
60+
<actualResult type="string">$gradScheduleStatusAfterChange</actualResult>
61+
</assertNotEquals>
62+
</test>
63+
</tests>

0 commit comments

Comments
 (0)