Skip to content

Commit 36ec5b3

Browse files
author
Evgeniy Kolesov
committed
MAGETWO-34984: Invert new admin styles scope
- Fixing tests
1 parent 72da958 commit 36ec5b3

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

app/code/Magento/Catalog/view/adminhtml/layout/catalog_product_new.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</head>
1414
<update handle="editor"/>
1515
<body>
16-
<referenceContainer name="admin.scope.col.wrap" htmlClass="" /> <!-- @todo ui: Removes .admin__scope-old class for edit product -->
16+
<referenceContainer name="admin.scope.col.wrap" htmlClass="admin__old" /> <!-- ToDo UI: remove this wrapper with old styles removal. The class name "admin__old" is for tests only, we shouldn't use it in any way -->
1717
<referenceContainer name="content">
1818
<block class="Magento\Catalog\Block\Adminhtml\Product\Edit" name="product_edit">
1919
<container name="product-type-tabs" label="Tabs">

app/code/Magento/Customer/view/adminhtml/layout/customer_index_edit.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
-->
88
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="admin-2columns-left" xsi:noNamespaceSchemaLocation="../../../../../../../lib/internal/Magento/Framework/View/Layout/etc/page_configuration.xsd">
99
<body>
10-
<referenceContainer name="admin.scope.col.wrap" htmlClass="" /> <!-- Removes .admin__scope-old class for customer columns -->
10+
<referenceContainer name="admin.scope.col.wrap" htmlClass="admin__old" /> <!-- ToDo UI: remove this wrapper with old styles removal. The class name "admin__old" is for tests only, we shouldn't use it in any way -->
1111
<referenceContainer name="content">
1212
<ui_component name="customer_form" component="form" />
1313
</referenceContainer>

dev/tests/js/testsuite/mage/tabs/tabs-test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,13 @@ TabsTest.prototype.testOnContentChange = function() {
128128
tabs = jQuery('#tabs').tabs();
129129

130130
tabs.data("tabs")._onContentChange(eventMock);
131-
assertTrue(jQuery('#tab1').hasClass('changed'));
131+
assertTrue(jQuery('#tab1').hasClass('_changed'));
132132
};
133133

134134
TabsTest.prototype.testOnInvalid = function() {
135135
/*:DOC += <div id="tabs"><ul>
136136
<li>
137-
<a href="www.site.com" id="tab1">Tab 1<span class="error">&nbsp;</span></a>
137+
<a href="www.site.com" id="tab1">Tab 1<span class="_error">&nbsp;</span></a>
138138
<div id="tab1_content"></div>
139139
</li>
140140
</ul></div>
@@ -145,13 +145,13 @@ TabsTest.prototype.testOnInvalid = function() {
145145
}
146146
},
147147
tabs = jQuery('#tabs').tabs(),
148-
errorIcon = jQuery('#tab1').find('.error');
148+
errorIcon = jQuery('#tab1').find('._error');
149149

150150
errorIcon.hide();
151151
assertTrue(errorIcon.is(':hidden'));
152152

153153
tabs.data("tabs")._onInvalid(eventMock);
154-
assertTrue(jQuery('#tab1').hasClass('error'));
154+
assertTrue(jQuery('#tab1').hasClass('_error'));
155155
assertTrue(errorIcon.is(':visible'));
156156
};
157157

@@ -174,10 +174,10 @@ TabsTest.prototype.testOnFocus = function() {
174174
},
175175
tabs = jQuery('#tabs').tabs();
176176

177-
assertNotEquals(tabs.tabs('option', 'active'), eventMock.data.index);
177+
assertNotEquals(tabs.tabs('option', '_active'), eventMock.data.index);
178178

179179
tabs.data("tabs")._onFocus(eventMock);
180-
assertEquals(tabs.tabs('option', 'active'), eventMock.data.index);
180+
assertEquals(tabs.tabs('option', '_active'), eventMock.data.index);
181181
};
182182

183183
TabsTest.prototype.testOnBeforeSubmit = function() {

0 commit comments

Comments
 (0)