[EngCom] Public Pull Requests - 2.2-develop

 - merged latest code from mainline branch

Author: magento-engcom-team

dev/tests/acceptance/RoboFile.php

@@ -43,8 +43,15 @@ function buildProject()
      * @param array $opts
      * @return void
      */
-    function generateTests($opts = ['config' => null])
+    function generateTests($opts = ['config' => null, 'force' => false])
     {
+        $GLOBALS['GENERATE_TESTS'] = true;
+
+        if ($opts['force'])
+        {
+            $GLOBALS['FORCE_PHP_GENERATE'] = true;
+        }
+
         require 'tests'. DIRECTORY_SEPARATOR . 'functional' . DIRECTORY_SEPARATOR . '_bootstrap.php';
         \Magento\FunctionalTestingFramework\Util\TestGenerator::getInstance()->createAllTestFiles($opts['config']);
         $this->say("Generate Tests Command Run");

dev/tests/acceptance/composer.json

@@ -22,7 +22,7 @@
         "consolidation/robo": "^1.0.0",
         "symfony/process": ">=2.7 <3.4",
         "henrikbjorn/lurker": "^1.2",
-        "magento/magento2-functional-testing-framework": "~2.0.0",
+        "magento/magento2-functional-testing-framework": "~2.1.0",
         "php": "7.0.2|7.0.4|~7.0.6|~7.1.0",
         "vlucas/phpdotenv": "~2.4"
     },

dev/tests/acceptance/composer.lock

@@ -16,6 +16,7 @@
         <include>
             <module name="Catalog" />
             <group name="login" />
+            <test name="AdminCreateCustomerTest"/>
         </include>
         <exclude>
             <module name="Catalog" file="AdminCreateCategoryTest.xml" />

dev/tests/acceptance/tests/_suite/sampleSuite.xml

@@ -21,6 +21,7 @@ modules:
             depends: PhpBrowser
             part: Json
         - \Magento\FunctionalTestingFramework\Module\MagentoSequence
+        - \Magento\FunctionalTestingFramework\Module\MagentoAssert
         - Asserts
     config:
         \Magento\FunctionalTestingFramework\Module\MagentoWebDriver:

dev/tests/acceptance/tests/functional.suite.dist.yml

@@ -12,8 +12,8 @@
         <arguments>
             <argument name="product" defaultValue="product"/>
         </arguments>
-        <amOnPage stepKey="navigateProductPage-{{product.name}}" url="/{{product.name}}.html"/>
-        <click stepKey="addToCart-{{product.name}}" selector="{{StorefrontProductPageSection.AddToCartBtn}}"/>
+        <amOnPage stepKey="navigateProductPage" url="/{{product.name}}.html"/>
+        <click stepKey="addToCart" selector="{{StorefrontProductPageSection.AddToCartBtn}}"/>
         <waitForElementVisible selector="{{StorefrontProductPageSection.SuccessMsg}}" time="30" stepKey="waitForProductAdded"/>
     </actionGroup>
 </actionGroups>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/ActionGroup/AddProductToCartActionGroup.xml

@@ -9,7 +9,7 @@
 <sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
     <section name="AdminCategorySidebarTreeSection">
-        <element name="Collapse All" type="button" selector=".tree-actions a:first-child"/>
-        <element name="Expand All" type="button" selector=".tree-actions a:last-child"/>
+        <element name="collapseAll" type="button" selector=".tree-actions a:first-child"/>
+        <element name="expandAll" type="button" selector=".tree-actions a:last-child"/>
     </section>
 </sections>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Section/AdminCategorySidebarTreeSection.xml

@@ -14,7 +14,7 @@
             <stories value="Create an Invoice via the Admin"/>
             <title value="Create Invoice"/>
             <description value="Should be able to create an invoice via the admin."/>
-            <severity value="NORMAL"/>
+            <severity value="MAJOR"/>
             <testCaseId value="MAGETWO-72096"/>
             <group value="sales"/>
         </annotations>