ACP2E-277: address CR comments

Author: alzota

app/code/Magento/Authorization/Model/Acl/Loader/Rule.php

@@ -7,6 +7,7 @@
 
 namespace Magento\Authorization\Model\Acl\Loader;
 
+use Magento\Framework\Acl;
 use Magento\Framework\Acl\Data\CacheInterface;
 use Magento\Framework\Acl\LoaderInterface;
 use Magento\Framework\Acl\RootResource;
@@ -31,27 +32,27 @@ class Rule implements LoaderInterface
     /**
      * @var ResourceConnection
      */
-    private ResourceConnection $_resource;
+    protected $_resource;
 
     /**
      * @var RootResource
      */
-    private RootResource $_rootResource;
+    private $_rootResource;
 
     /**
      * @var CacheInterface
      */
-    private CacheInterface $aclDataCache;
+    private $aclDataCache;
 
     /**
      * @var Json
      */
-    private Json $serializer;
+    private $serializer;
 
     /**
      * @var string
      */
-    private string $cacheKey;
+    private $cacheKey;
 
     /**
      * @param RootResource $rootResource
@@ -80,10 +81,10 @@ public function __construct(
     /**
      * Populate ACL with rules from external storage
      *
-     * @param \Magento\Framework\Acl $acl
+     * @param Acl $acl
      * @return void
      */
-    public function populateAcl(\Magento\Framework\Acl $acl)
+    public function populateAcl(Acl $acl)
     {
         $result = $this->applyPermissionsAccordingToRules($acl);
         $this->applyDenyPermissionsForMissingRules($acl, ...$result);
@@ -92,10 +93,10 @@ public function populateAcl(\Magento\Framework\Acl $acl)
     /**
      * Apply ACL with rules
      *
-     * @param \Magento\Framework\Acl $acl
+     * @param Acl $acl
      * @return array[]
      */
-    private function applyPermissionsAccordingToRules(\Magento\Framework\Acl $acl): array
+    private function applyPermissionsAccordingToRules(Acl $acl): array
     {
         $foundResources = $foundDeniedRoles = [];
         foreach ($this->getRulesArray() as $rule) {
@@ -124,19 +125,19 @@ private function applyPermissionsAccordingToRules(\Magento\Framework\Acl $acl):
      * when adding a new module and without re-saving all roles,
      * consider not present rules with deny permissions
      *
-     * @param \Magento\Framework\Acl $acl
+     * @param Acl $acl
      * @param array $resources
      * @param array $deniedRoles
      * @return void
      */
     private function applyDenyPermissionsForMissingRules(
-        \Magento\Framework\Acl $acl,
+        Acl $acl,
         array $resources,
         array $deniedRoles
     ) {
         if (count($resources) && count($deniedRoles)
             //ignore denying missing permission if all are allowed
-            && !(count($resources) == 1 && isset($resources[static::ALLOW_EVERYTHING]))
+            && !(count($resources) === 1 && isset($resources[static::ALLOW_EVERYTHING]))
         ) {
             foreach ($acl->getResources() as $resource) {
                 if (!isset($resources[$resource])) {