MAGETWO-63321: Issue when deleting item from Product options grid containing more than 20 options

Author: Sergii Kovalenko

app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js

@@ -633,7 +633,6 @@ define([
         getChildItems: function (data, page) {
             var dataRecord = data || this.relatedData,
                 startIndex;
-
             this.startIndex = (~~this.currentPage() - 1) * this.pageSize;
 
             startIndex = page || this.startIndex;
@@ -672,9 +671,8 @@ define([
             this.bubble('addChild', false);
 
             if (this.relatedData.length && this.relatedData.length % this.pageSize === 0) {
-                this.clear();
                 this.pages(this.pages() + 1);
-                this.currentPage(this.pages());
+                this.nextPage();
             } else if (~~this.currentPage() !== this.pages()) {
                 this.currentPage(this.pages());
             }
@@ -717,8 +715,8 @@ define([
                 return false;
             }
 
-            this.clear();
             this.initChildren();
+            return true;
         },
 
         /**
@@ -743,13 +741,15 @@ define([
          * Change page to next
          */
         nextPage: function () {
+            this.clear();
             this.currentPage(this.currentPage() + 1);
         },
 
         /**
          * Change page to previous
          */
         previousPage: function () {
+            this.clear();
             this.currentPage(this.currentPage() - 1);
         },
 

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/dynamic-rows/dynamic.rows.test.js

@@ -0,0 +1,55 @@
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/* eslint-disable max-nested-callbacks */
+define([
+    'Magento_Ui/js/dynamic-rows/dynamic-rows'
+], function (DynamicRows) {
+    'use strict';
+
+    var model;
+
+    beforeEach(function(done) {
+        model = new DynamicRows({});
+        done();
+    });
+
+    describe('Magento_Ui/js/dynamic-rows/dynamic-rows', function () {
+        it('changePage without Records', function() {
+            model.recordData = function () {
+                return {
+                    length: 0
+                };
+            };
+
+            expect(model.changePage(1)).toBeFalsy();
+        });
+
+        it('changePage with Fake Page', function() {
+            model.pages = function () {
+                return 3;
+            };
+
+            expect(model.changePage(4)).toBeFalsy();
+        });
+
+        it('changePage', function() {
+            model.startIndex = 0;
+            model.pageSize = 3;
+            model.relatedData = [
+                {"a": "b"},
+                {"b": "c"},
+                {"v": "g"}
+            ];
+
+            model.pages = function () {
+                return 3;
+            };
+            model.changePage(2);
+
+            expect(model.templates.record.recordId).toBe(2);//last record number is 3
+        });
+    });
+});