Skip to content

Commit 3635b3a

Browse files
cod62627cod62627
committed
AC-12267:: unittest and static test resolution
1 parent e416abc commit 3635b3a

File tree

3 files changed

+94
-90
lines changed

3 files changed

+94
-90
lines changed

‎lib/internal/Magento/Framework/Session/SaveHandler/Redis/Config.php

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -18,135 +18,135 @@ class Config implements \Cm\RedisSession\Handler\ConfigInterface
1818
/**
1919
* Configuration path for log level
2020
*/
21-
const PARAM_LOG_LEVEL = 'session/redis/log_level';
21+
public const PARAM_LOG_LEVEL = 'session/redis/log_level';
2222

2323
/**
2424
* Configuration path for host
2525
*/
26-
const PARAM_HOST = 'session/redis/host';
26+
public const PARAM_HOST = 'session/redis/host';
2727

2828
/**
2929
* Configuration path for port
3030
*/
31-
const PARAM_PORT = 'session/redis/port';
31+
public const PARAM_PORT = 'session/redis/port';
3232

3333
/**
3434
* Configuration path for database
3535
*/
36-
const PARAM_DATABASE = 'session/redis/database';
36+
public const PARAM_DATABASE = 'session/redis/database';
3737

3838
/**
3939
* Configuration path for password
4040
*/
41-
const PARAM_PASSWORD = 'session/redis/password';
41+
public const PARAM_PASSWORD = 'session/redis/password';
4242

4343
/**
4444
* Configuration path for connection timeout
4545
*/
46-
const PARAM_TIMEOUT = 'session/redis/timeout';
46+
public const PARAM_TIMEOUT = 'session/redis/timeout';
4747

4848
/**
4949
* Configuration path for number of connection retries
5050
*/
51-
const PARAM_RETRIES = 'session/redis/retries';
51+
public const PARAM_RETRIES = 'session/redis/retries';
5252

5353
/**
5454
* Configuration path for persistent identifier
5555
*/
56-
const PARAM_PERSISTENT_IDENTIFIER = 'session/redis/persistent_identifier';
56+
public const PARAM_PERSISTENT_IDENTIFIER = 'session/redis/persistent_identifier';
5757

5858
/**
5959
* Configuration path for compression threshold
6060
*/
61-
const PARAM_COMPRESSION_THRESHOLD = 'session/redis/compression_threshold';
61+
public const PARAM_COMPRESSION_THRESHOLD = 'session/redis/compression_threshold';
6262

6363
/**
6464
* Configuration path for compression library
6565
*/
66-
const PARAM_COMPRESSION_LIBRARY = 'session/redis/compression_library';
66+
public const PARAM_COMPRESSION_LIBRARY = 'session/redis/compression_library';
6767

6868
/**
6969
* Configuration path for maximum number of processes that can wait for a lock on one session
7070
*/
71-
const PARAM_MAX_CONCURRENCY = 'session/redis/max_concurrency';
71+
public const PARAM_MAX_CONCURRENCY = 'session/redis/max_concurrency';
7272

7373
/**
7474
* Configuration path for minimum session lifetime
7575
*/
76-
const PARAM_MAX_LIFETIME = 'session/redis/max_lifetime';
76+
public const PARAM_MAX_LIFETIME = 'session/redis/max_lifetime';
7777

7878
/**
7979
* Configuration path for min
8080
*/
81-
const PARAM_MIN_LIFETIME = 'session/redis/min_lifetime';
81+
public const PARAM_MIN_LIFETIME = 'session/redis/min_lifetime';
8282

8383
/**
8484
* Configuration path for disabling session locking entirely flag
8585
*/
86-
const PARAM_DISABLE_LOCKING = 'session/redis/disable_locking';
86+
public const PARAM_DISABLE_LOCKING = 'session/redis/disable_locking';
8787

8888
/**
8989
* Configuration path for lifetime of session for bots on subsequent writes
9090
*/
91-
const PARAM_BOT_LIFETIME = 'session/redis/bot_lifetime';
91+
public const PARAM_BOT_LIFETIME = 'session/redis/bot_lifetime';
9292

9393
/**
9494
* Configuration path for lifetime of session for bots on the first write
9595
*/
96-
const PARAM_BOT_FIRST_LIFETIME = 'session/redis/bot_first_lifetime';
96+
public const PARAM_BOT_FIRST_LIFETIME = 'session/redis/bot_first_lifetime';
9797

9898
/**
9999
* Configuration path for lifetime of session for non-bots on the first write
100100
*/
101-
const PARAM_FIRST_LIFETIME = 'session/redis/first_lifetime';
101+
public const PARAM_FIRST_LIFETIME = 'session/redis/first_lifetime';
102102

103103
/**
104104
* Configuration path for number of seconds to wait before trying to break the lock
105105
*/
106-
const PARAM_BREAK_AFTER = 'session/redis/break_after';
106+
public const PARAM_BREAK_AFTER = 'session/redis/break_after';
107107

108108
/**
109109
* Configuration path for comma separated list of sentinel servers
110110
*/
111-
const PARAM_SENTINEL_SERVERS = 'session/redis/sentinel_servers';
111+
public const PARAM_SENTINEL_SERVERS = 'session/redis/sentinel_servers';
112112

113113
/**
114114
* Configuration path for sentinel master
115115
*/
116-
const PARAM_SENTINEL_MASTER = 'session/redis/sentinel_master';
116+
public const PARAM_SENTINEL_MASTER = 'session/redis/sentinel_master';
117117

118118
/**
119119
* Configuration path for verify sentinel master flag
120120
*/
121-
const PARAM_SENTINEL_VERIFY_MASTER = 'session/redis/sentinel_verify_master';
121+
public const PARAM_SENTINEL_VERIFY_MASTER = 'session/redis/sentinel_verify_master';
122122

123123
/**
124124
* Configuration path for number of sentinel connection retries
125125
*/
126-
const PARAM_SENTINEL_CONNECT_RETRIES = 'session/redis/sentinel_connect_retries';
126+
public const PARAM_SENTINEL_CONNECT_RETRIES = 'session/redis/sentinel_connect_retries';
127127

128128
/**
129129
* Cookie lifetime config path
130130
*/
131-
const XML_PATH_COOKIE_LIFETIME = 'web/cookie/cookie_lifetime';
131+
public const XML_PATH_COOKIE_LIFETIME = 'web/cookie/cookie_lifetime';
132132

133133
/**
134134
* Admin session lifetime config path
135135
*/
136-
const XML_PATH_ADMIN_SESSION_LIFETIME = 'admin/security/session_lifetime';
136+
public const XML_PATH_ADMIN_SESSION_LIFETIME = 'admin/security/session_lifetime';
137137

138138
/**
139139
* Session max lifetime
140140
*/
141-
const SESSION_MAX_LIFETIME = 31536000;
141+
public const SESSION_MAX_LIFETIME = 31536000;
142142

143143
/**
144144
* Try to break lock for at most this many seconds
145145
*/
146-
const DEFAULT_FAIL_AFTER = 15;
146+
public const DEFAULT_FAIL_AFTER = 15;
147147

148148
/**
149-
* Deployment config
149+
* Deployment configuration
150150
*
151151
* @var DeploymentConfig
152152
*/

‎setup/src/Magento/Setup/Model/ConfigOptionsList/Session.php

Lines changed: 48 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -19,54 +19,54 @@
1919
*/
2020
class Session implements ConfigOptionsListInterface
2121
{
22-
const INPUT_KEY_SESSION_REDIS_HOST = 'session-save-redis-host';
23-
const INPUT_KEY_SESSION_REDIS_PORT = 'session-save-redis-port';
24-
const INPUT_KEY_SESSION_REDIS_PASSWORD = 'session-save-redis-password';
25-
const INPUT_KEY_SESSION_REDIS_TIMEOUT = 'session-save-redis-timeout';
26-
const INPUT_KEY_SESSION_REDIS_RETRIES = 'session-save-redis-retries';
27-
const INPUT_KEY_SESSION_REDIS_PERSISTENT_IDENTIFIER = 'session-save-redis-persistent-id';
28-
const INPUT_KEY_SESSION_REDIS_DATABASE = 'session-save-redis-db';
29-
const INPUT_KEY_SESSION_REDIS_COMPRESSION_THRESHOLD = 'session-save-redis-compression-threshold';
30-
const INPUT_KEY_SESSION_REDIS_COMPRESSION_LIBRARY = 'session-save-redis-compression-lib';
31-
const INPUT_KEY_SESSION_REDIS_LOG_LEVEL = 'session-save-redis-log-level';
32-
const INPUT_KEY_SESSION_REDIS_MAX_CONCURRENCY = 'session-save-redis-max-concurrency';
33-
const INPUT_KEY_SESSION_REDIS_BREAK_AFTER_FRONTEND = 'session-save-redis-break-after-frontend';
34-
const INPUT_KEY_SESSION_REDIS_BREAK_AFTER_ADMINHTML = 'session-save-redis-break-after-adminhtml';
35-
const INPUT_KEY_SESSION_REDIS_FIRST_LIFETIME = 'session-save-redis-first-lifetime';
36-
const INPUT_KEY_SESSION_REDIS_BOT_FIRST_LIFETIME = 'session-save-redis-bot-first-lifetime';
37-
const INPUT_KEY_SESSION_REDIS_BOT_LIFETIME = 'session-save-redis-bot-lifetime';
38-
const INPUT_KEY_SESSION_REDIS_DISABLE_LOCKING = 'session-save-redis-disable-locking';
39-
const INPUT_KEY_SESSION_REDIS_MIN_LIFETIME = 'session-save-redis-min-lifetime';
40-
const INPUT_KEY_SESSION_REDIS_MAX_LIFETIME = 'session-save-redis-max-lifetime';
41-
const INPUT_KEY_SESSION_REDIS_SENTINEL_SERVERS = 'session-save-redis-sentinel-servers';
42-
const INPUT_KEY_SESSION_REDIS_SENTINEL_MASTER = 'session-save-redis-sentinel-master';
43-
const INPUT_KEY_SESSION_REDIS_SENTINEL_VERIFY_MASTER = 'session-save-redis-sentinel-verify-master';
44-
const INPUT_KEY_SESSION_REDIS_SENTINEL_CONNECT_RETRIES = 'session-save-redis-sentinel-connect-retries';
22+
public const INPUT_KEY_SESSION_REDIS_HOST = 'session-save-redis-host';
23+
public const INPUT_KEY_SESSION_REDIS_PORT = 'session-save-redis-port';
24+
public const INPUT_KEY_SESSION_REDIS_PASSWORD = 'session-save-redis-password';
25+
public const INPUT_KEY_SESSION_REDIS_TIMEOUT = 'session-save-redis-timeout';
26+
public const INPUT_KEY_SESSION_REDIS_RETRIES = 'session-save-redis-retries';
27+
public const INPUT_KEY_SESSION_REDIS_PERSISTENT_IDENTIFIER = 'session-save-redis-persistent-id';
28+
public const INPUT_KEY_SESSION_REDIS_DATABASE = 'session-save-redis-db';
29+
public const INPUT_KEY_SESSION_REDIS_COMPRESSION_THRESHOLD = 'session-save-redis-compression-threshold';
30+
public const INPUT_KEY_SESSION_REDIS_COMPRESSION_LIBRARY = 'session-save-redis-compression-lib';
31+
public const INPUT_KEY_SESSION_REDIS_LOG_LEVEL = 'session-save-redis-log-level';
32+
public const INPUT_KEY_SESSION_REDIS_MAX_CONCURRENCY = 'session-save-redis-max-concurrency';
33+
public const INPUT_KEY_SESSION_REDIS_BREAK_AFTER_FRONTEND = 'session-save-redis-break-after-frontend';
34+
public const INPUT_KEY_SESSION_REDIS_BREAK_AFTER_ADMINHTML = 'session-save-redis-break-after-adminhtml';
35+
public const INPUT_KEY_SESSION_REDIS_FIRST_LIFETIME = 'session-save-redis-first-lifetime';
36+
public const INPUT_KEY_SESSION_REDIS_BOT_FIRST_LIFETIME = 'session-save-redis-bot-first-lifetime';
37+
public const INPUT_KEY_SESSION_REDIS_BOT_LIFETIME = 'session-save-redis-bot-lifetime';
38+
public const INPUT_KEY_SESSION_REDIS_DISABLE_LOCKING = 'session-save-redis-disable-locking';
39+
public const INPUT_KEY_SESSION_REDIS_MIN_LIFETIME = 'session-save-redis-min-lifetime';
40+
public const INPUT_KEY_SESSION_REDIS_MAX_LIFETIME = 'session-save-redis-max-lifetime';
41+
public const INPUT_KEY_SESSION_REDIS_SENTINEL_SERVERS = 'session-save-redis-sentinel-servers';
42+
public const INPUT_KEY_SESSION_REDIS_SENTINEL_MASTER = 'session-save-redis-sentinel-master';
43+
public const INPUT_KEY_SESSION_REDIS_SENTINEL_VERIFY_MASTER = 'session-save-redis-sentinel-verify-master';
44+
public const INPUT_KEY_SESSION_REDIS_SENTINEL_CONNECT_RETRIES = 'session-save-redis-sentinel-connect-retries';
4545

46-
const CONFIG_PATH_SESSION_REDIS = 'session/redis';
47-
const CONFIG_PATH_SESSION_REDIS_HOST = 'session/redis/host';
48-
const CONFIG_PATH_SESSION_REDIS_PORT = 'session/redis/port';
49-
const CONFIG_PATH_SESSION_REDIS_PASSWORD = 'session/redis/password';
50-
const CONFIG_PATH_SESSION_REDIS_TIMEOUT = 'session/redis/timeout';
51-
const CONFIG_PATH_SESSION_REDIS_RETRIES = 'session/redis/retries';
52-
const CONFIG_PATH_SESSION_REDIS_PERSISTENT_IDENTIFIER = 'session/redis/persistent_identifier';
53-
const CONFIG_PATH_SESSION_REDIS_DATABASE = 'session/redis/database';
54-
const CONFIG_PATH_SESSION_REDIS_COMPRESSION_THRESHOLD = 'session/redis/compression_threshold';
55-
const CONFIG_PATH_SESSION_REDIS_COMPRESSION_LIBRARY = 'session/redis/compression_library';
56-
const CONFIG_PATH_SESSION_REDIS_LOG_LEVEL = 'session/redis/log_level';
57-
const CONFIG_PATH_SESSION_REDIS_MAX_CONCURRENCY = 'session/redis/max_concurrency';
58-
const CONFIG_PATH_SESSION_REDIS_BREAK_AFTER_FRONTEND = 'session/redis/break_after_frontend';
59-
const CONFIG_PATH_SESSION_REDIS_BREAK_AFTER_ADMINHTML = 'session/redis/break_after_adminhtml';
60-
const CONFIG_PATH_SESSION_REDIS_FIRST_LIFETIME = 'session/redis/first_lifetime';
61-
const CONFIG_PATH_SESSION_REDIS_BOT_FIRST_LIFETIME = 'session/redis/bot_first_lifetime';
62-
const CONFIG_PATH_SESSION_REDIS_BOT_LIFETIME = 'session/redis/bot_lifetime';
63-
const CONFIG_PATH_SESSION_REDIS_DISABLE_LOCKING = 'session/redis/disable_locking';
64-
const CONFIG_PATH_SESSION_REDIS_MIN_LIFETIME = 'session/redis/min_lifetime';
65-
const CONFIG_PATH_SESSION_REDIS_MAX_LIFETIME = 'session/redis/max_lifetime';
66-
const CONFIG_PATH_SESSION_REDIS_SENTINEL_SERVERS = 'session/redis/sentinel_servers';
67-
const CONFIG_PATH_SESSION_REDIS_SENTINEL_MASTER = 'session/redis/sentinel_master';
68-
const CONFIG_PATH_SESSION_REDIS_SENTINEL_VERIFY_MASTER = 'session/redis/sentinel_verify_master';
69-
const CONFIG_PATH_SESSION_REDIS_SENTINEL_CONNECT_RETRIES = 'session/redis/sentinel_connect_retries';
46+
public const CONFIG_PATH_SESSION_REDIS = 'session/redis';
47+
public const CONFIG_PATH_SESSION_REDIS_HOST = 'session/redis/host';
48+
public const CONFIG_PATH_SESSION_REDIS_PORT = 'session/redis/port';
49+
public const CONFIG_PATH_SESSION_REDIS_PASSWORD = 'session/redis/password';
50+
public const CONFIG_PATH_SESSION_REDIS_TIMEOUT = 'session/redis/timeout';
51+
public const CONFIG_PATH_SESSION_REDIS_RETRIES = 'session/redis/retries';
52+
public const CONFIG_PATH_SESSION_REDIS_PERSISTENT_IDENTIFIER = 'session/redis/persistent_identifier';
53+
public const CONFIG_PATH_SESSION_REDIS_DATABASE = 'session/redis/database';
54+
public const CONFIG_PATH_SESSION_REDIS_COMPRESSION_THRESHOLD = 'session/redis/compression_threshold';
55+
public const CONFIG_PATH_SESSION_REDIS_COMPRESSION_LIBRARY = 'session/redis/compression_library';
56+
public const CONFIG_PATH_SESSION_REDIS_LOG_LEVEL = 'session/redis/log_level';
57+
public const CONFIG_PATH_SESSION_REDIS_MAX_CONCURRENCY = 'session/redis/max_concurrency';
58+
public const CONFIG_PATH_SESSION_REDIS_BREAK_AFTER_FRONTEND = 'session/redis/break_after_frontend';
59+
public const CONFIG_PATH_SESSION_REDIS_BREAK_AFTER_ADMINHTML = 'session/redis/break_after_adminhtml';
60+
public const CONFIG_PATH_SESSION_REDIS_FIRST_LIFETIME = 'session/redis/first_lifetime';
61+
public const CONFIG_PATH_SESSION_REDIS_BOT_FIRST_LIFETIME = 'session/redis/bot_first_lifetime';
62+
public const CONFIG_PATH_SESSION_REDIS_BOT_LIFETIME = 'session/redis/bot_lifetime';
63+
public const CONFIG_PATH_SESSION_REDIS_DISABLE_LOCKING = 'session/redis/disable_locking';
64+
public const CONFIG_PATH_SESSION_REDIS_MIN_LIFETIME = 'session/redis/min_lifetime';
65+
public const CONFIG_PATH_SESSION_REDIS_MAX_LIFETIME = 'session/redis/max_lifetime';
66+
public const CONFIG_PATH_SESSION_REDIS_SENTINEL_SERVERS = 'session/redis/sentinel_servers';
67+
public const CONFIG_PATH_SESSION_REDIS_SENTINEL_MASTER = 'session/redis/sentinel_master';
68+
public const CONFIG_PATH_SESSION_REDIS_SENTINEL_VERIFY_MASTER = 'session/redis/sentinel_verify_master';
69+
public const CONFIG_PATH_SESSION_REDIS_SENTINEL_CONNECT_RETRIES = 'session/redis/sentinel_connect_retries';
7070

7171
/**
7272
* @var array
@@ -138,7 +138,7 @@ class Session implements ConfigOptionsListInterface
138138
self::INPUT_KEY_SESSION_REDIS_SENTINEL_MASTER => self::CONFIG_PATH_SESSION_REDIS_SENTINEL_MASTER,
139139
self::INPUT_KEY_SESSION_REDIS_SENTINEL_SERVERS => self::CONFIG_PATH_SESSION_REDIS_SENTINEL_SERVERS,
140140
self::INPUT_KEY_SESSION_REDIS_SENTINEL_CONNECT_RETRIES =>
141-
self::CONFIG_PATH_SESSION_REDIS_SENTINEL_CONNECT_RETRIES,
141+
self::CONFIG_PATH_SESSION_REDIS_SENTINEL_CONNECT_RETRIES,
142142
self::INPUT_KEY_SESSION_REDIS_SENTINEL_VERIFY_MASTER => self::CONFIG_PATH_SESSION_REDIS_SENTINEL_VERIFY_MASTER,
143143
];
144144

‎setup/src/Magento/Setup/Test/Unit/Model/ConfigOptionsList/SessionTest.php

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ protected function setUp(): void
3636
public function testGetOptions()
3737
{
3838
$options = $this->configList->getOptions();
39-
$this->assertCount(23, $options);
39+
$this->assertCount(24, $options);
4040

4141
$this->assertArrayHasKey(0, $options);
4242
$this->assertInstanceOf(SelectConfigOption::class, $options[0]);
@@ -60,59 +60,63 @@ public function testGetOptions()
6060

6161
$this->assertArrayHasKey(5, $options);
6262
$this->assertInstanceOf(TextConfigOption::class, $options[5]);
63-
$this->assertEquals('session-save-redis-persistent-id', $options[5]->getName());
63+
$this->assertEquals('session-save-redis-retries', $options[5]->getName());
6464

6565
$this->assertArrayHasKey(6, $options);
6666
$this->assertInstanceOf(TextConfigOption::class, $options[6]);
67-
$this->assertEquals('session-save-redis-db', $options[6]->getName());
67+
$this->assertEquals('session-save-redis-persistent-id', $options[6]->getName());
6868

6969
$this->assertArrayHasKey(7, $options);
7070
$this->assertInstanceOf(TextConfigOption::class, $options[7]);
71-
$this->assertEquals('session-save-redis-compression-threshold', $options[7]->getName());
71+
$this->assertEquals('session-save-redis-db', $options[7]->getName());
7272

7373
$this->assertArrayHasKey(8, $options);
7474
$this->assertInstanceOf(TextConfigOption::class, $options[8]);
75-
$this->assertEquals('session-save-redis-compression-lib', $options[8]->getName());
75+
$this->assertEquals('session-save-redis-compression-threshold', $options[8]->getName());
7676

7777
$this->assertArrayHasKey(9, $options);
7878
$this->assertInstanceOf(TextConfigOption::class, $options[9]);
79-
$this->assertEquals('session-save-redis-log-level', $options[9]->getName());
79+
$this->assertEquals('session-save-redis-compression-lib', $options[9]->getName());
8080

8181
$this->assertArrayHasKey(10, $options);
8282
$this->assertInstanceOf(TextConfigOption::class, $options[10]);
83-
$this->assertEquals('session-save-redis-max-concurrency', $options[10]->getName());
83+
$this->assertEquals('session-save-redis-log-level', $options[10]->getName());
8484

8585
$this->assertArrayHasKey(11, $options);
8686
$this->assertInstanceOf(TextConfigOption::class, $options[11]);
87-
$this->assertEquals('session-save-redis-break-after-frontend', $options[11]->getName());
87+
$this->assertEquals('session-save-redis-max-concurrency', $options[11]->getName());
8888

8989
$this->assertArrayHasKey(12, $options);
9090
$this->assertInstanceOf(TextConfigOption::class, $options[12]);
91-
$this->assertEquals('session-save-redis-break-after-adminhtml', $options[12]->getName());
91+
$this->assertEquals('session-save-redis-break-after-frontend', $options[12]->getName());
9292

9393
$this->assertArrayHasKey(13, $options);
9494
$this->assertInstanceOf(TextConfigOption::class, $options[13]);
95-
$this->assertEquals('session-save-redis-first-lifetime', $options[13]->getName());
95+
$this->assertEquals('session-save-redis-break-after-adminhtml', $options[13]->getName());
9696

9797
$this->assertArrayHasKey(14, $options);
9898
$this->assertInstanceOf(TextConfigOption::class, $options[14]);
99-
$this->assertEquals('session-save-redis-bot-first-lifetime', $options[14]->getName());
99+
$this->assertEquals('session-save-redis-first-lifetime', $options[14]->getName());
100100

101101
$this->assertArrayHasKey(15, $options);
102102
$this->assertInstanceOf(TextConfigOption::class, $options[15]);
103-
$this->assertEquals('session-save-redis-bot-lifetime', $options[15]->getName());
103+
$this->assertEquals('session-save-redis-bot-first-lifetime', $options[15]->getName());
104104

105105
$this->assertArrayHasKey(16, $options);
106106
$this->assertInstanceOf(TextConfigOption::class, $options[16]);
107-
$this->assertEquals('session-save-redis-disable-locking', $options[16]->getName());
107+
$this->assertEquals('session-save-redis-bot-lifetime', $options[16]->getName());
108108

109109
$this->assertArrayHasKey(17, $options);
110110
$this->assertInstanceOf(TextConfigOption::class, $options[17]);
111-
$this->assertEquals('session-save-redis-min-lifetime', $options[17]->getName());
111+
$this->assertEquals('session-save-redis-disable-locking', $options[17]->getName());
112112

113113
$this->assertArrayHasKey(18, $options);
114114
$this->assertInstanceOf(TextConfigOption::class, $options[18]);
115-
$this->assertEquals('session-save-redis-max-lifetime', $options[18]->getName());
115+
$this->assertEquals('session-save-redis-min-lifetime', $options[18]->getName());
116+
117+
$this->assertArrayHasKey(19, $options);
118+
$this->assertInstanceOf(TextConfigOption::class, $options[19]);
119+
$this->assertEquals('session-save-redis-max-lifetime', $options[19]->getName());
116120
}
117121

118122
public function testCreateConfig()

0 commit comments

Comments
 (0)