Skip to content

Commit 35dde64

Browse files
committed
MC-42813: Feature request: Cart qty update should be reverted back if the requested qty is not available
1 parent 028f8d7 commit 35dde64

File tree

2 files changed

+22
-24
lines changed

2 files changed

+22
-24
lines changed

app/code/Magento/Checkout/Controller/Cart/UpdateItemQty.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121

2222
/**
2323
* UpdateItemQty ajax request
24-
*
25-
* @package Magento\Checkout\Controller\Cart
2624
*/
2725
class UpdateItemQty extends Action implements HttpPostActionInterface
2826
{

app/code/Magento/Checkout/view/frontend/templates/cart/item/default.phtml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
// phpcs:disable Magento2.Templates.ThisInTemplate
8-
// phpcs:disable Magento2.Files.LineLength.MaxExceeded
8+
// phpcs:disable Generic.Files.LineLength
99

1010
/** @var $block \Magento\Checkout\Block\Cart\Item\Renderer */
1111

@@ -19,58 +19,58 @@ $canApplyMsrp = $helper->isShowBeforeOrderConfirm($product) && $helper->isMinima
1919
<tbody class="cart item">
2020
<tr class="item-info">
2121
<td data-th="<?= $block->escapeHtml(__('Item')) ?>" class="col item">
22-
<?php if ($block->hasProductUrl()) :?>
22+
<?php if ($block->hasProductUrl()): ?>
2323
<a href="<?= $block->escapeUrl($block->getProductUrl()) ?>"
2424
title="<?= $block->escapeHtml($block->getProductName()) ?>"
2525
tabindex="-1"
2626
class="product-item-photo">
27-
<?php else :?>
27+
<?php else: ?>
2828
<span class="product-item-photo">
29-
<?php endif;?>
29+
<?php endif; ?>
3030
<?= $block->getImage($block->getProductForThumbnail(), 'cart_page_product_thumbnail')->toHtml() ?>
31-
<?php if ($block->hasProductUrl()) :?>
31+
<?php if ($block->hasProductUrl()): ?>
3232
</a>
33-
<?php else :?>
33+
<?php else: ?>
3434
</span>
3535
<?php endif; ?>
3636
<div class="product-item-details">
3737
<strong class="product-item-name">
38-
<?php if ($block->hasProductUrl()) :?>
38+
<?php if ($block->hasProductUrl()): ?>
3939
<a href="<?= $block->escapeUrl($block->getProductUrl()) ?>"><?= $block->escapeHtml($block->getProductName()) ?></a>
40-
<?php else :?>
40+
<?php else: ?>
4141
<?= $block->escapeHtml($block->getProductName()) ?>
4242
<?php endif; ?>
4343
</strong>
44-
<?php if ($_options = $block->getOptionList()) :?>
44+
<?php if ($_options = $block->getOptionList()): ?>
4545
<dl class="item-options">
46-
<?php foreach ($_options as $_option) :?>
46+
<?php foreach ($_options as $_option): ?>
4747
<?php $_formatedOptionValue = $block->getFormatedOptionValue($_option) ?>
4848
<dt><?= $block->escapeHtml($_option['label']) ?></dt>
4949
<dd>
50-
<?php if (isset($_formatedOptionValue['full_view'])) :?>
50+
<?php if (isset($_formatedOptionValue['full_view'])): ?>
5151
<?= $block->escapeHtml($_formatedOptionValue['full_view'], ['span', 'a']) ?>
52-
<?php else :?>
53-
<?= $block->escapeHtml($_formatedOptionValue['value'], ['span', 'a']) ?>
52+
<?php else: ?>
53+
<?= $block->escapeHtml($_formatedOptionValue['value'], ['span', 'a']) ?>
5454
<?php endif; ?>
5555
</dd>
5656
<?php endforeach; ?>
5757
</dl>
58-
<?php endif;?>
59-
<?php if ($messages = $block->getMessages()) :?>
60-
<?php foreach ($messages as $message) :?>
58+
<?php endif; ?>
59+
<?php if ($messages = $block->getMessages()): ?>
60+
<?php foreach ($messages as $message): ?>
6161
<div class= "cart item message <?= $block->escapeHtmlAttr($message['type']) ?>">
6262
<div><?= $block->escapeHtml($message['text']) ?></div>
6363
</div>
6464
<?php endforeach; ?>
6565
<?php endif; ?>
6666
<?php $addInfoBlock = $block->getProductAdditionalInformationBlock(); ?>
67-
<?php if ($addInfoBlock) :?>
67+
<?php if ($addInfoBlock): ?>
6868
<?= $addInfoBlock->setItem($_item)->toHtml() ?>
69-
<?php endif;?>
69+
<?php endif; ?>
7070
</div>
7171
</td>
7272

73-
<?php if ($canApplyMsrp) :?>
73+
<?php if ($canApplyMsrp): ?>
7474
<td class="col msrp" data-th="<?= $block->escapeHtml(__('Price')) ?>">
7575
<span class="pricing msrp">
7676
<span class="msrp notice"><?= $block->escapeHtml(__('See price before order confirmation.')) ?></span>
@@ -89,7 +89,7 @@ $canApplyMsrp = $helper->isShowBeforeOrderConfirm($product) && $helper->isMinima
8989
</a>
9090
</span>
9191
</td>
92-
<?php else :?>
92+
<?php else: ?>
9393
<td class="col price" data-th="<?= $block->escapeHtml(__('Price')) ?>">
9494
<?= $block->getUnitPriceHtml($_item) ?>
9595
</td>
@@ -117,9 +117,9 @@ $canApplyMsrp = $helper->isShowBeforeOrderConfirm($product) && $helper->isMinima
117117
</td>
118118

119119
<td class="col subtotal" data-th="<?= $block->escapeHtml(__('Subtotal')) ?>">
120-
<?php if ($canApplyMsrp) :?>
120+
<?php if ($canApplyMsrp): ?>
121121
<span class="cart msrp subtotal">--</span>
122-
<?php else :?>
122+
<?php else: ?>
123123
<?= $block->getRowTotalHtml($_item) ?>
124124
<?php endif; ?>
125125
</td>

0 commit comments

Comments
 (0)