MAGETWO-54361: Configurable variation is displayed on category/product page when is out of stock

- Rename constraint;

Author: adifucan

dev/tests/functional/tests/app/Magento/CatalogInventoryConfigurableProduct/Test/Constraint/AssertOutOfStockOptionIsAbsentOnOnProductPage.php renamed to dev/tests/functional/tests/app/Magento/CatalogInventoryConfigurableProduct/Test/Constraint/AssertOutOfStockOptionIsAbsentOnProductPage.php

@@ -14,7 +14,7 @@
 /**
  * Assert that out of stock configurable option is not displayed on product page.
  */
-class AssertOutOfStockOptionIsAbsentOnOnProductPage extends AbstractConstraint
+class AssertOutOfStockOptionIsAbsentOnProductPage extends AbstractConstraint
 {
     /**
      * Assert that out of stock configurable option is not displayed on product page on frontend.
@@ -37,18 +37,18 @@ public function processAssert(
         foreach ($listOptions as $option) {
             $productOptions = $catalogProductView->getConfigurableAttributesBlock()->getSelectOptionsData($option);
         }
-        $option = $this->isOptionPresent($outOfStockOption, $productOptions);
+        $option = $this->isOptionAbsent($outOfStockOption, $productOptions);
         \PHPUnit_Framework_Assert::assertTrue($option, 'Out of stock option is present on product page.');
     }
 
     /**
-     * Check if option is present on product page.
+     * Check if option is absent on product page.
      *
      * @param string $needle
      * @param array $haystack
      * @return bool
      */
-    private function isOptionPresent($needle, array $haystack)
+    private function isOptionAbsent($needle, array $haystack)
     {
         foreach ($haystack as $options) {
             foreach ($options as $option) {

dev/tests/functional/tests/app/Magento/CatalogInventoryConfigurableProduct/Test/TestCase/CreateConfigurableProductEntityTest.xml

@@ -19,7 +19,7 @@
             <data name="product/data/description" xsi:type="string">Configurable Product description %isolation%</data>
             <data name="outOfStockOption" xsi:type="string">SIZE_S</data>
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductSaveMessage" />
-            <constraint name="Magento\CatalogInventoryConfigurableProduct\Test\Constraint\AssertOutOfStockOptionIsAbsentOnOnProductPage" />
+            <constraint name="Magento\CatalogInventoryConfigurableProduct\Test\Constraint\AssertOutOfStockOptionIsAbsentOnProductPage" />
         </variation>
     </testCase>
 </config>

dev/tests/functional/tests/app/Magento/CatalogInventoryConfigurableProduct/Test/etc/di.xml

@@ -6,7 +6,7 @@
  */
  -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
-    <type name="Magento\CatalogInventoryConfigurableProduct\Test\Constraint\AssertOutOfStockOptionIsAbsentOnOnProductPage">
+    <type name="Magento\CatalogInventoryConfigurableProduct\Test\Constraint\AssertOutOfStockOptionIsAbsentOnProductPage">
         <arguments>
             <argument name="severity" xsi:type="string">middle</argument>
         </arguments>

dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Block/Product/View/ConfigurableOptions.php

@@ -46,7 +46,7 @@ class ConfigurableOptions extends CustomOptions
      *
      * @var string
      */
-    protected $configurableOptionElement = '#product-options-wrapper > * > .configurable';
+    private $configurableOptionElement = '#product-options-wrapper > * > .configurable';
 
     /**
      * Get configurable product options