ACP2E-3403: Cart Price Rules Miscalculating Discount

aplapana · aplapana · commit 35c69e7da505 · 2024-10-16T16:19:54.000+03:00
diff --git a/app/code/Magento/SalesRule/Model/Quote/Discount.php b/app/code/Magento/SalesRule/Model/Quote/Discount.php
@@ -238,8 +238,9 @@ public function collect(
                     $this->eventManager->dispatch('sales_quote_address_discount_item', $eventArgs);
                     $this->aggregateItemDiscount($child, $total);
                 }
+            } else {
+                $this->aggregateItemDiscount($item, $total);
             }
-            $this->aggregateItemDiscount($item, $total);
             if ($item->getExtensionAttributes()) {
                 $this->aggregateDiscountPerRule($item, $address);
             }

Original file line number	Diff line number	Diff line change
`@@ -238,8 +238,9 @@ public function collect(`
`238`	`238`	`$this->eventManager->dispatch('sales_quote_address_discount_item', $eventArgs);`
`239`	`239`	`$this->aggregateItemDiscount($child, $total);`
`240`	`240`	`}`
	`241`	`+ } else {`
	`242`	`+ $this->aggregateItemDiscount($item, $total);`
`241`	`243`	`}`
`242`		`- $this->aggregateItemDiscount($item, $total);`
`243`	`244`	`if ($item->getExtensionAttributes()) {`
`244`	`245`	`$this->aggregateDiscountPerRule($item, $address);`
`245`	`246`	`}`