Skip to content

Commit 35a1b12

Browse files
authored
ENGCOM-7784: [MFTF] Use actionGroup go to CatalogRulePage #28999
2 parents 455ca54 + df6bb34 commit 35a1b12

10 files changed

+14
-19
lines changed

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminApplyCatalogRuleByCategoryTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<deleteData createDataKey="createSimpleProductTwo" stepKey="deleteSimpleProductTwo"/>
3737

3838
<!-- Delete the catalog price rule -->
39-
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>
39+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
4040
<actionGroup stepKey="deletePriceRule" ref="deleteEntitySecondaryGrid">
4141
<argument name="name" value="{{_defaultCatalogRule.name}}"/>
4242
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>
@@ -46,8 +46,7 @@
4646
</after>
4747

4848
<!-- 1. Begin creating a new catalog price rule -->
49-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage"/>
50-
<waitForPageLoad stepKey="waitForPriceRulePage"/>
49+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
5150
<click selector="{{AdminGridMainControls.add}}" stepKey="addNewRule"/>
5251
<waitForPageLoad stepKey="waitForIndividualRulePage"/>
5352
<fillField selector="{{AdminNewCatalogPriceRule.ruleName}}" userInput="{{_defaultCatalogRule.name}}" stepKey="fillName"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminDeleteCatalogPriceRuleEntityTest/AdminDeleteCatalogPriceRuleEntityFromConfigurableProductTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@
105105
</after>
106106

107107
<!-- Delete the simple product and catalog price rule -->
108-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage1"/>
109-
<waitForPageLoad stepKey="waitForPriceRulePage"/>
108+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage1"/>
110109
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule1">
111110
<argument name="name" value="{{DeleteActiveCatalogPriceRuleWithConditions.name}}"/>
112111
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminDeleteCatalogPriceRuleEntityTest/AdminDeleteCatalogPriceRuleEntityFromSimpleProductTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@
4949
</after>
5050

5151
<!-- Delete the simple product and catalog price rule -->
52-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage1"/>
53-
<waitForPageLoad stepKey="waitForPriceRulePage"/>
52+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage1"/>
5453
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule1">
5554
<argument name="name" value="{{DeleteActiveCatalogPriceRuleWithConditions.name}}"/>
5655
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminDeleteCatalogPriceRuleTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<see selector="{{StorefrontProductInfoMainSection.productPrice}}" userInput="$0.90" stepKey="seeCorrectPrice2"/>
7676

7777
<!-- Delete the rule -->
78-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage"/>
78+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
7979
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule">
8080
<argument name="name" value="{{_defaultCatalogRule.name}}"/>
8181
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/AdminEnableAttributeIsUndefinedCatalogPriceRuleTest.xml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<after>
5050

5151
<!--Delete created data-->
52-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToCatalogPriceRulePage"/>
52+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToCatalogPriceRulePage"/>
5353
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule">
5454
<argument name="name" value="{{CatalogRuleWithAllCustomerGroups.name}}"/>
5555
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>
@@ -68,8 +68,7 @@
6868
</after>
6969

7070
<!--Create catalog price rule-->
71-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage"/>
72-
<waitForPageLoad stepKey="waitForPriceRulePage"/>
71+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
7372
<actionGroup ref="CreateCatalogPriceRuleActionGroup" stepKey="createCatalogPriceRule">
7473
<argument name="catalogRule" value="CatalogRuleWithAllCustomerGroups"/>
7574
</actionGroup>
@@ -104,7 +103,7 @@
104103

105104
<!--Delete previous attribute and Catalog Price Rule-->
106105
<deleteData createDataKey="createProductAttribute" stepKey="deleteProductAttribute"/>
107-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToCatalogPriceRulePage"/>
106+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToCatalogPriceRulePage"/>
108107
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule">
109108
<argument name="name" value="{{CatalogRuleWithAllCustomerGroups.name}}"/>
110109
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>
@@ -116,8 +115,7 @@
116115
</createData>
117116

118117
<!--Create new Catalog Price Rule-->
119-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToPriceRulePage1"/>
120-
<waitForPageLoad stepKey="waitForPriceRulePage1"/>
118+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage1"/>
121119
<actionGroup ref="CreateCatalogPriceRuleActionGroup" stepKey="createCatalogPriceRule1">
122120
<argument name="catalogRule" value="CatalogRuleWithAllCustomerGroups"/>
123121
</actionGroup>

app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogPriceRuleByProductAttributeTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
<deleteData createDataKey="createConfigChildProduct2" stepKey="deleteConfigChildProduct2"/>
9898
<deleteData createDataKey="createConfigProductAttribute" stepKey="deleteConfigProductAttribute"/>
9999

100-
<amOnPage url="{{CatalogRulePage.url}}" stepKey="goToCatalogPriceRulePage"/>
100+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToCatalogPriceRulePage"/>
101101
<actionGroup ref="deleteEntitySecondaryGrid" stepKey="deletePriceRule">
102102
<argument name="name" value="{{SimpleCatalogPriceRule.name}}"/>
103103
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleAndConfigurableProductTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
</before>
8282
<after>
8383
<!-- Delete the catalog price rule -->
84-
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>
84+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
8585
<actionGroup stepKey="deletePriceRule" ref="deleteEntitySecondaryGrid">
8686
<argument name="name" value="{{_defaultCatalogRule.name}}"/>
8787
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleProductAndFixedMethodTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
4242

4343
<!-- Delete the catalog price rule -->
44-
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>
44+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
4545
<actionGroup stepKey="deletePriceRule" ref="deleteEntitySecondaryGrid">
4646
<argument name="name" value="{{CatalogRuleByFixed.name}}"/>
4747
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleProductForNewCustomerGroupTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
<deleteData createDataKey="customerGroup" stepKey="deleteCustomerGroup"/>
4747

4848
<!-- Delete the catalog price rule -->
49-
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>
49+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
5050
<actionGroup stepKey="deletePriceRule" ref="deleteEntitySecondaryGrid">
5151
<argument name="name" value="{{CatalogRuleByFixed.name}}"/>
5252
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

app/code/Magento/CatalogRule/Test/Mftf/Test/ApplyCatalogRuleForSimpleProductWithCustomOptionsTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
5050

5151
<!-- Delete the catalog price rule -->
52-
<amOnPage stepKey="goToPriceRulePage" url="{{CatalogRulePage.url}}"/>
52+
<actionGroup ref="AdminOpenCatalogPriceRulePageActionGroup" stepKey="goToPriceRulePage"/>
5353
<actionGroup stepKey="deletePriceRule" ref="deleteEntitySecondaryGrid">
5454
<argument name="name" value="{{_defaultCatalogRule.name}}"/>
5555
<argument name="searchInput" value="{{AdminSecondaryGridSection.catalogRuleIdentifierSearch}}"/>

0 commit comments

Comments
 (0)