MAGETWO-69036: Lazy-loaders cause fatal errors in production mode on cloud

  - Fix static tests

Author: igrybkov

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -109,10 +109,10 @@ public function __construct(
         Js $jsHelper,
         DateFilter $dateFilter,
         LinkTypeProvider $linkTypeProvider = null,
-        CustomOptionFactory $customOptionFactory,
-        ProductLinkFactory $productLinkFactory,
-        ProductRepository $productRepository,
-        DateTime $dateTimeFilter
+        CustomOptionFactory $customOptionFactory = null,
+        ProductLinkFactory $productLinkFactory = null,
+        ProductRepository $productRepository = null,
+        DateTime $dateTimeFilter = null
     ) {
         if (null === $linkTypeProvider) {
             $linkTypeProvider = ObjectManager::getInstance()->get(LinkTypeProvider::class);

app/code/Magento/Catalog/Model/Product/Option/Repository.php

@@ -58,6 +58,8 @@ class Repository implements \Magento\Catalog\Api\ProductCustomOptionRepositoryIn
      * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository
      * @param \Magento\Catalog\Model\ResourceModel\Product\Option $optionResource
      * @param Converter $converter
+     * @param \Magento\Catalog\Model\Product\OptionFactory $optionFactory
+     * @param \Magento\Catalog\Model\ResourceModel\Product\Option\CollectionFactory $collectionFactory
      */
     public function __construct(
         \Magento\Catalog\Api\ProductRepositoryInterface $productRepository,

app/code/Magento/Catalog/Model/ProductLink/Repository.php

@@ -84,6 +84,8 @@ class Repository implements \Magento\Catalog\Api\ProductLinkRepositoryInterface
      * @param LinksInitializer $linkInitializer
      * @param Management $linkManagement
      * @param \Magento\Framework\Reflection\DataObjectProcessor $dataObjectProcessor
+     * @param ProductLinkInterfaceFactory $productLinkFactory
+     * @param ProductLinkExtensionFactory $productLinkExtensionFactory
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(

app/code/Magento/Catalog/Model/ResourceModel/Category/Flat.php

@@ -703,19 +703,4 @@ public function getProductsPosition($category)
 
         return $this->getConnection()->fetchPairs($select, $bind);
     }
-
-    /**
-     * Get instance of CategoryFlatCollectionFactory
-     *
-     * @return CategoryFlatCollectionFactory
-     */
-    private function getCategoryFlatCollectionFactory()
-    {
-        if (!$this->categoryFlatCollectionFactory instanceof CategoryFlatCollectionFactory) {
-            $this->categoryFlatCollectionFactory = ObjectManager::getInstance()
-                ->get(CategoryFlatCollectionFactory::class);
-        }
-
-        return $this->categoryFlatCollectionFactory;
-    }
 }

app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php

@@ -26,6 +26,35 @@ class Cart extends \Magento\Customer\Controller\Adminhtml\Index
      */
     private $quoteFactory;
 
+    /**
+     * Cart constructor.
+     * @param \Magento\Backend\App\Action\Context $context
+     * @param \Magento\Framework\Registry $coreRegistry
+     * @param \Magento\Framework\App\Response\Http\FileFactory $fileFactory
+     * @param \Magento\Customer\Model\CustomerFactory $customerFactory
+     * @param \Magento\Customer\Model\AddressFactory $addressFactory
+     * @param \Magento\Customer\Model\Metadata\FormFactory $formFactory
+     * @param \Magento\Newsletter\Model\SubscriberFactory $subscriberFactory
+     * @param \Magento\Customer\Helper\View $viewHelper
+     * @param \Magento\Framework\Math\Random $random
+     * @param CustomerRepositoryInterface $customerRepository
+     * @param \Magento\Framework\Api\ExtensibleDataObjectConverter $extensibleDataObjectConverter
+     * @param Mapper $addressMapper
+     * @param AccountManagementInterface $customerAccountManagement
+     * @param AddressRepositoryInterface $addressRepository
+     * @param CustomerInterfaceFactory $customerDataFactory
+     * @param AddressInterfaceFactory $addressDataFactory
+     * @param \Magento\Customer\Model\Customer\Mapper $customerMapper
+     * @param \Magento\Framework\Reflection\DataObjectProcessor $dataObjectProcessor
+     * @param DataObjectHelper $dataObjectHelper
+     * @param ObjectFactory $objectFactory
+     * @param \Magento\Framework\View\LayoutFactory $layoutFactory
+     * @param \Magento\Framework\View\Result\LayoutFactory $resultLayoutFactory
+     * @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
+     * @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
+     * @param \Magento\Framework\Controller\Result\JsonFactory $resultJsonFactory
+     * @param QuoteFactory|null $quoteFactory
+     */
     public function __construct(
         \Magento\Backend\App\Action\Context $context,
         \Magento\Framework\Registry $coreRegistry,
@@ -87,7 +116,6 @@ public function __construct(
         $this->quoteFactory = $quoteFactory;
     }
 
-
     /**
      * Handle and then get cart grid contents
      *

app/code/Magento/Customer/Model/Metadata/Form/File.php

@@ -72,8 +72,8 @@ class File extends AbstractData
      * @param \Magento\MediaStorage\Model\File\Validator\NotProtectedExtension $fileValidator
      * @param Filesystem $fileSystem
      * @param UploaderFactory $uploaderFactory
+     * @param FileProcessorFactory|null $fileProcessorFactory
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
-     * @throws \RuntimeException
      */
     public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,

app/code/Magento/Directory/Model/Currency/Import/Webservicex.php

@@ -34,6 +34,7 @@ class Webservicex extends \Magento\Directory\Model\Currency\Import\AbstractImpor
      * @var \Magento\Framework\App\Config\ScopeConfigInterface
      */
     private $scopeConfig;
+
     /**
      * @var ZendClientFactory|null
      */

app/code/Magento/Indexer/Console/Command/AbstractIndexerCommand.php

@@ -28,6 +28,7 @@ abstract class AbstractIndexerCommand extends Command
      * @var ObjectManagerInterface
      */
     private $objectManager;
+
     /**
      * @var IndexerCollectionFactory|null
      */

app/code/Magento/Indexer/Console/Command/AbstractIndexerManageCommand.php

@@ -20,6 +20,7 @@ abstract class AbstractIndexerManageCommand extends AbstractIndexerCommand
      * Indexer name option
      */
     const INPUT_KEY_INDEXERS = 'index';
+
     /**
      * @var IndexerFactory|null
      */

app/code/Magento/Quote/Model/QuoteRepository.php

@@ -71,6 +71,9 @@ class QuoteRepository implements \Magento\Quote\Api\CartRepositoryInterface
      */
     private $loadHandler;
 
+    /**
+     * @var QuoteCollectionFactory
+     */
     private $quoteCollectionFactory;
 
     /**
@@ -79,6 +82,7 @@ class QuoteRepository implements \Magento\Quote\Api\CartRepositoryInterface
      * @param \Magento\Quote\Model\ResourceModel\Quote\Collection $quoteCollection
      * @param \Magento\Quote\Api\Data\CartSearchResultsInterfaceFactory $searchResultsDataFactory
      * @param JoinProcessorInterface $extensionAttributesJoinProcessor
+     * @param QuoteCollectionFactory|null $quoteCollectionFactory
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(