Skip to content

Commit 35586e3

Browse files
[ACQE-4974] Modifying stepkeys for better readability
1 parent cb4aab3 commit 35586e3

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/StorefrontVerifyCategoryPageNotCachedTest.xml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222
<!--Login to Admin Panel-->
2323
<actionGroup ref="AdminLoginActionGroup" stepKey="logInAsAdmin"/>
2424
<!-- Create tax rate for CA -->
25-
<createData entity="US_CA_Rate_1" stepKey="CATaxRate"/>
25+
<createData entity="US_CA_Rate_1" stepKey="createTaxRateCA"/>
2626
<!-- Create tax rate for TX -->
2727
<createData entity="ThirdTaxRateTexas" stepKey="createTaxRateTX"/>
2828
<!-- Create Tax Rules -->
2929
<actionGroup ref="AdminCreateTaxRuleActionGroup" stepKey="createTaxRule1">
30-
<argument name="taxRate" value="$$CATaxRate$$"/>
30+
<argument name="taxRate" value="$$createTaxRateCA$$"/>
3131
<argument name="taxRule" value="SimpleTaxRule"/>
3232
</actionGroup>
3333
<actionGroup ref="AdminCreateTaxRuleActionGroup" stepKey="createTaxRule2">
@@ -66,33 +66,33 @@
6666
<argument name="taxRuleCode" value="{{SimpleTaxRule2.code}}"/>
6767
</actionGroup>
6868
<!--Delete Tax Rates-->
69-
<deleteData createDataKey="CATaxRate" stepKey="deleteTaxRate1"/>
69+
<deleteData createDataKey="createTaxRateCA" stepKey="deleteTaxRate1"/>
7070
<deleteData createDataKey="createTaxRateTX" stepKey="deleteTaxRate2"/>
7171
<!--Delete Customers-->
7272
<deleteData createDataKey="createCustomerCA" stepKey="deleteCustomer1"/>
7373
<deleteData createDataKey="createCustomerTX" stepKey="deleteCustomer2"/>
7474
<!--Logout Admin-->
75-
<actionGroup ref="AdminLogoutActionGroup" stepKey="amOnLogoutPage"/>
75+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAdmin"/>
7676
</after>
7777

7878
<!-- Login as customer 1-->
79-
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="storefrontCustomerLogin">
79+
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="storefrontCustomer1Login">
8080
<argument name="Customer" value="$$createCustomerCA$$"/>
8181
</actionGroup>
8282
<!-- Assert Customer Name -->
83-
<actionGroup ref="AssertCustomerWelcomeMessageActionGroup" stepKey="assertCustomerLoggedIn">
83+
<actionGroup ref="AssertCustomerWelcomeMessageActionGroup" stepKey="assertCustomerName">
8484
<argument name="customerFullName" value="$$createCustomerCA.firstname$$ $$createCustomerCA.lastname$$" />
8585
</actionGroup>
8686
<!-- Navigate to category page -->
8787
<actionGroup ref="StorefrontNavigateCategoryPageActionGroup" stepKey="navigateToCategoryPage">
8888
<argument name="category" value="$$createCategory$$"/>
8989
</actionGroup>
9090
<!-- Assert Product Prices -->
91-
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seePriceCategoryPageProduct1">
91+
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeProduct1TaxInclusivePriceCustomer1">
9292
<argument name="productName" value="$$simpleProduct.name$$"/>
9393
<argument name="productPrice" value="$108.25"/>
9494
</actionGroup>
95-
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeInclPriceCategoryPageProduct2">
95+
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeProduct2TaxInclusivePriceCustomer1">
9696
<argument name="productName" value="$$simpleProduct2.name$$"/>
9797
<argument name="productPrice" value="$216.50"/>
9898
</actionGroup>
@@ -103,7 +103,7 @@
103103
<actionGroup ref="StorefrontAddProductToCompareActionGroup" stepKey="addFirstProductToCompare">
104104
<argument name="productVar" value="$$simpleProduct$$"/>
105105
</actionGroup>
106-
<actionGroup ref="StorefrontClickAddToCartOnProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage"/>
106+
<actionGroup ref="StorefrontClickAddToCartOnProductPageActionGroup" stepKey="addFirstProductToCart"/>
107107
<!--Add second product to compare list -->
108108
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openSecondProductPage">
109109
<argument name="productUrl" value="$$simpleProduct2.custom_attributes[url_key]$$"/>
@@ -112,11 +112,11 @@
112112
<argument name="productVar" value="$$simpleProduct2$$"/>
113113
</actionGroup>
114114
<!--Add second product to wishlist -->
115-
<actionGroup ref="StorefrontCustomerAddProductToWishlistActionGroup" stepKey="wishlist">
115+
<actionGroup ref="StorefrontCustomerAddProductToWishlistActionGroup" stepKey="addSecondProductToWishlist">
116116
<argument name="productVar" value="$$simpleProduct2$$"/>
117117
</actionGroup>
118118
<!-- Customer 1 logout -->
119-
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogout"/>
119+
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customer1Logout"/>
120120
<!-- Customer 2 login -->
121121
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="storefrontCustomer2Login">
122122
<argument name="Customer" value="$$createCustomerTX$$"/>
@@ -127,19 +127,19 @@
127127
</actionGroup>
128128
<actionGroup ref="StorefrontAssertCustomerWishlistIsEmptyActionGroup" stepKey="assertNoItemsInWishlist"/>
129129
<!-- Assert minicart is empty -->
130-
<actionGroup ref="AssertMiniCartEmptyActionGroup" stepKey="assertMiniCartEmpty"/>
130+
<actionGroup ref="AssertMiniCartEmptyActionGroup" stepKey="assertMiniCartIsEmpty"/>
131131
<!-- Navigate to category page -->
132-
<actionGroup ref="StorefrontNavigateCategoryPageActionGroup" stepKey="navigateToCategoryPage4">
132+
<actionGroup ref="StorefrontNavigateCategoryPageActionGroup" stepKey="navigateToCategoryPage2">
133133
<argument name="category" value="$$createCategory$$"/>
134134
</actionGroup>
135135
<!-- Assert Compare list is empty -->
136136
<seeElement selector="{{StorefrontComparisonSidebarSection.NoItemsMessage}}" stepKey="assertCompareListIsEmpty"/>
137137
<!-- Assert Product Prices -->
138-
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seePrice2CategoryPageProduct1">
138+
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeProduct1TaxInclusivePriceCustomer2">
139139
<argument name="productName" value="$$simpleProduct.name$$"/>
140140
<argument name="productPrice" value="$120"/>
141141
</actionGroup>
142-
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeInclPrice2CategoryPageProduct2">
142+
<actionGroup ref="StorefrontAssertProductPriceOnCategoryPageActionGroup" stepKey="seeProduct2TaxInclusivePriceCustomer2">
143143
<argument name="productName" value="$$simpleProduct2.name$$"/>
144144
<argument name="productPrice" value="$240"/>
145145
</actionGroup>

0 commit comments

Comments
 (0)