AC-14352::Integration and Unit test coverage for Delete multiple catalog price rules at once

Author: glo60612

app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/MassDelete.php

@@ -48,7 +48,7 @@ public function execute()
             foreach ($ids as $id) {
                 $this->ruleRepository->deleteById($id);
             }
-            $this->messageManager->addSuccessMessage(__('You deleted a total of %1 records.', count($ids)));
+            $this->messageManager->addSuccessMessage(__('A total of %1 record(s) were deleted.', count($ids)));
         } else {
             $this->messageManager->addErrorMessage(__('Please select a catalog price rule(s)'));
         }

app/code/Magento/CatalogRule/Test/Unit/Controller/Adminhtml/Promo/Catalog/MassDeleteTest.php

@@ -0,0 +1,106 @@
+<?php
+/**
+ * Copyright 2025 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\CatalogRule\Test\Unit\Controller\Adminhtml\Promo\Catalog;
+
+use Magento\Backend\Model\View\Result\Redirect;
+use Magento\CatalogRule\Controller\Adminhtml\Promo\Catalog\MassDelete;
+use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Controller\ResultFactory;
+use Magento\Framework\Message\ManagerInterface;
+use PHPUnit\Framework\MockObject\MockObject;
+use Magento\Backend\App\Action\Context;
+use PHPUnit\Framework\TestCase;
+use Magento\CatalogRule\Api\Data\RuleInterface;
+use Magento\CatalogRule\Model\Rule;
+use Magento\CatalogRule\Api\CatalogRuleRepositoryInterface;
+
+class MassDeleteTest extends TestCase
+{
+    /**
+     * @var CatalogRuleRepositoryInterface|MockObject
+     */
+    private $catalogRuleRepositoryMock;
+
+    /**
+     * @var Context|MockObject
+     */
+    protected $contextMock;
+
+    /**
+     * @var MassDelete
+     */
+    protected $delete;
+
+    /**
+     * @var RequestInterface|MockObject
+     */
+    protected $requestMock;
+
+    /**
+     * @var Rule|MockObject
+     */
+    protected $ruleMock;
+
+    /**
+     * @var ManagerInterface|MockObject
+     */
+    protected $messageManagerMock;
+
+    /**
+     * @var Redirect|MockObject
+     */
+    protected $resultRedirectMock;
+
+    /**
+     * @var ResultFactory|MockObject
+     */
+    protected $resultFactory;
+
+    protected function setUp(): void
+    {
+        $this->requestMock = $this->getMockBuilder(RequestInterface::class)
+            ->onlyMethods(['getParam'])
+            ->getMockForAbstractClass();
+        $this->contextMock = $this->createMock(Context::class);
+
+        $this->messageManagerMock = $this->getMockBuilder(ManagerInterface::class)
+            ->getMockForAbstractClass();
+
+        $this->resultRedirectMock = $this->getMockBuilder(Redirect::class)
+            ->onlyMethods(['setPath'])
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->resultFactory = $this->createMock(ResultFactory::class);
+        $this->resultFactory->method('create')->willReturn($this->resultRedirectMock);
+        $this->contextMock->method('getResultFactory')->willReturn($this->resultFactory);
+        $this->contextMock->method('getMessageManager')->willReturn($this->messageManagerMock);
+        $this->contextMock->method('getRequest')->willReturn($this->requestMock);
+        $this->catalogRuleRepositoryMock = $this->createMock(
+            CatalogRuleRepositoryInterface::class
+        );
+        $this->delete = new MassDelete($this->contextMock, $this->catalogRuleRepositoryMock);
+    }
+
+    public function testExecute()
+    {
+        $data = [1];
+        $this->requestMock->expects(self::any())
+            ->method('getParam')
+            ->willReturn($data);
+        $catalogRuleMock = $this->getMockForAbstractClass(RuleInterface::class);
+        $this->catalogRuleRepositoryMock->expects($this->once())
+            ->method('deleteById')
+            ->with(1)
+            ->willReturn($catalogRuleMock);
+        $this->messageManagerMock->expects($this->once())
+            ->method('addSuccessMessage')
+            ->with(__('A total of %1 record(s) were deleted.', $data));
+        $this->delete->execute();
+    }
+}

dev/tests/integration/testsuite/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/MassActionTest.php

@@ -85,6 +85,21 @@ public function testMassInActivatedRule()
         self::assertEquals(0, $afterActivateRule2->getIsActive());
     }
 
+    #[DataFixture(CatalogRuleFixture::class, ['is_active' => 1], 'cr1')]
+    #[DataFixture(CatalogRuleFixture::class, ['is_active' => 1], 'cr2')]
+    public function testMassDeleteRule()
+    {
+        $rule1 = FixtureManager::getStorage()->get('cr1');
+        $rule2 = FixtureManager::getStorage()->get('cr2');
+        $params = ['catalogpricerule' => [$rule1->getId(), $rule2->getId()]];
+        $request = $this->getRequest();
+        $request->setParams($params);
+        $request->setMethod(HttpRequest::METHOD_POST);
+        $url = 'backend/catalog_rule/promo_catalog/massDelete';
+        $this->dispatch($url);
+        self::assertEquals('A total of 2 record(s) were deleted.', $this->getSuccessMessage());
+    }
+
     /**
      * Gets success message after dispatching the controller.
      *