Skip to content

Commit 341a3e3

Browse files
committed
MAGETWO-44049: [GITHUB] data-bind i18n expressions with JavaScript function calls are used in the core but untranslatable due to regular expression and architectural limitations #1905
- replaced data-bind "i18n" with "text" for variables, method invokes, expressions - removed $t() for variables and expressions
1 parent 9d3c87a commit 341a3e3

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

app/code/Magento/Checkout/view/frontend/web/template/registration.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
</form>
1414
<!-- /ko -->
1515
<!-- ko if: accountCreated -->
16-
<p data-bind="i18n: $t('A letter with further instructions will be sent to your email.')"></p>
16+
<p data-bind="i18n: 'A letter with further instructions will be sent to your email.'"></p>
1717
<!-- /ko -->
1818
</div>

app/code/Magento/Checkout/view/frontend/web/template/shipping.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
<tr class="row row-error">
123123
<td class="col col-error" colspan="4">
124124
<div class="message error">
125-
<div data-bind="i18n: method.error_message"></div>
125+
<div data-bind="text: method.error_message"></div>
126126
</div>
127127
<span class="no-display">
128128
<input name="shipping_method" type="radio" data-bind="attr: {'value' : method.method_code, 'id': 's_method_' + method.method_code}"/>

app/code/Magento/Cms/view/frontend/templates/default/home.phtml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
* See COPYING.txt for license details.
55
*/
66
?>
7-
There was no Home CMS page configured or found.
8-
git
7+
There was no Home CMS page configured or found.

0 commit comments

Comments
 (0)