MAGETWO-90940: SEO-friendly URL for category page not working

Author: zakdma

app/code/Magento/Catalog/Controller/Adminhtml/Category.php

@@ -19,7 +19,6 @@
 use Magento\Framework\Controller\Result\Json;
 use Magento\Backend\Model\Auth\Session;
 use Magento\Framework\DataObject;
-use Zend_Filter_Input;
 
 /**
  * Catalog category controller
@@ -42,10 +41,8 @@ abstract class Category extends Action
      * @param Context $context
      * @param Date|null $dateFilter
      */
-    public function __construct(
-        Context $context,
-        Date $dateFilter = null
-    ) {
+    public function __construct(Context $context, Date $dateFilter = null)
+    {
         $this->dateFilter = $dateFilter;
         parent::__construct($context);
     }
@@ -117,7 +114,7 @@ private function resolveStoreId(): int
         return $storeId ?: (int)$this->getRequest()->getParam('store_id', Store::DEFAULT_STORE_ID);
     }
 
-    /**Zend_Filter_Input
+    /**
      * Build response for ajax request
      *
      * @param CategoryModel $category
@@ -127,10 +124,8 @@ private function resolveStoreId(): int
      *
      * @deprecated 101.0.0
      */
-    protected function ajaxRequestResponse(
-        CategoryModel $category,
-        Page $resultPage
-    ): Json {
+    protected function ajaxRequestResponse(CategoryModel $category, Page $resultPage): Json
+    {
         // prepare breadcrumbs of selected category, if any
         $breadcrumbsPath = $category->getPath();
         if (empty($breadcrumbsPath)) {
@@ -167,6 +162,7 @@ protected function ajaxRequestResponse(
         $resultJson = $this->_objectManager->get(Json::class);
         $resultJson->setHeader('Content-type', 'application/json', true);
         $resultJson->setData($eventResponse->getData());
+
         return $resultJson;
     }
 
@@ -189,7 +185,7 @@ protected function dateTimePreprocessing(CategoryModel $category, array $postDat
                 }
             }
         }
-        $inputFilter = new Zend_Filter_Input($dateFieldFilters, [], $postData);
+        $inputFilter = new \Zend_Filter_Input($dateFieldFilters, [], $postData);
         return $inputFilter->getUnescaped();
     }
 }

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/AdminUpdateCategoryStoreUrlKeyTest.xml

@@ -19,7 +19,7 @@
             <group value="category"/>
         </annotations>
         <before>
-            <!-- Create category, change store view to default -->
+            <!-- Create category -->
             <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
             <amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
             <waitForPageLoad stepKey="waitForPageLoad1"/>
@@ -57,7 +57,7 @@
         <see selector="{{StorefrontCategoryMainSection.CategoryTitle}}" userInput="{{_defaultCategory.name}}" stepKey="assertCategoryOnStorefront"/>
         <seeInTitle userInput="{{_defaultCategory.name}}" stepKey="seeCategoryNameInTitle"/>
         <seeInCurrentUrl stepKey="verifyUrlKey" url="{{_defaultCategory.name_lwr}}-hattest.html"/>
-        <!-- Update SEO key to original, uncheck "Create Redirect", confirm in frontend, delete category -->
+        <!-- Update SEO key to original, uncheck "Create Redirect", confirm in frontend -->
         <!--Switch to "Default Store View" scope-->
         <actionGroup ref="switchCategoryStoreView" stepKey="SwitchStoreView2">
             <argument name="store" value="_defaultStore.name"/>