CE#34569: Fix failed tests

Author: karyna-t

app/code/Magento/Catalog/Model/Product/Option/Type/Date.php

@@ -306,8 +306,9 @@ public function prepareOptionValueForRequest($optionValue)
         try {
             $value = $this->serializer->unserialize($infoBuyRequest->getValue());
 
-            if (
-                is_array($value) && isset($value['options']) && isset($value['options'][$this->getOption()->getId()])
+            if (is_array($value)
+                && isset($value['options'])
+                && isset($value['options'][$this->getOption()->getId()])
             ) {
                 return $value['options'][$this->getOption()->getId()];
             } else {

app/code/Magento/Catalog/Test/Unit/Ui/DataProvider/CatalogEavValidationRulesTest.php

@@ -50,8 +50,7 @@ public function testBuild($frontendInput, $frontendClass, array $eavConfig, arra
         $attribute->expects($this->once())
             ->method('getFrontendInput')
             ->willReturn($frontendInput);
-        $attribute->expects($this->once())
-            ->method('getFrontendClass')
+        $attribute->method('getFrontendClass')
             ->willReturn($frontendClass);
 
         $this->assertEquals($expectedResult, $this->catalogEavValidationRules->build($attribute, $eavConfig));

app/code/Magento/Catalog/Ui/DataProvider/CatalogEavValidationRules.php

@@ -39,10 +39,12 @@ public function build(ProductAttributeInterface $attribute, array $data)
 
         foreach ($validationClasses as $class) {
             if (preg_match('/^maximum-length-(\d+)$/', $class, $matches)) {
+                // phpcs:ignore Magento2.Performance.ForeachArrayMerge
                 $rules = array_merge($rules, ['max_text_length' => $matches[1]]);
                 continue;
             }
             if (preg_match('/^minimum-length-(\d+)$/', $class, $matches)) {
+                // phpcs:ignore Magento2.Performance.ForeachArrayMerge
                 $rules = array_merge($rules, ['min_text_length' => $matches[1]]);
                 continue;
             }

app/code/Magento/CatalogImportExport/Model/Import/Product/Option.php

@@ -1279,8 +1279,9 @@ protected function _importData()
                 $multiRowData = $this->_getMultiRowFormat($rowData);
                 if (!empty($rowData[self::COLUMN_SKU]) && isset($this->_productsSkuToId[$rowData[self::COLUMN_SKU]])) {
                     $this->_rowProductId = $this->_productsSkuToId[$rowData[self::COLUMN_SKU]];
-                    if (isset($rowData['custom_options'])
+                    if (array_key_exists('custom_options', $rowData)
                         && (
+                            $rowData['custom_options'] === null ||
                             trim($rowData['custom_options']) === '' ||
                             trim($rowData['custom_options']) === $this->_productEntity->getEmptyAttributeValueConstant()
                         )

app/code/Magento/Tax/Model/Calculation/RateRepository.php

@@ -110,7 +110,10 @@ public function __construct(
         $this->resourceModel = $rateResource;
         $this->joinProcessor = $joinProcessor;
         $this->collectionProcessor = $collectionProcessor
-            ?? ObjectManager::getInstance()->get(TaxRateCollectionProcessor::class);
+            ?? ObjectManager::getInstance()->get(
+                // phpcs:ignore Magento2.PHP.LiteralNamespaces
+                'Magento\Tax\Model\Api\SearchCriteria\TaxRateCollectionProcessor'
+            );
     }
 
     /**
@@ -238,10 +241,8 @@ private function validate(TaxRateInterface $taxRate)
         $exception = new InputException();
 
         $countryCode = $taxRate->getTaxCountryId();
-        /** @phpstan-ignore-next-line */
         if (!\Zend_Validate::is($countryCode, 'NotEmpty')) {
             $exception->addError(__('"%fieldName" is required. Enter and try again.', ['fieldName' => 'country_id']));
-            /** @phpstan-ignore-next-line */
         } elseif (!\Zend_Validate::is(
             $this->countryFactory->create()->loadByCode($countryCode)->getId(),
             'NotEmpty'
@@ -257,11 +258,9 @@ private function validate(TaxRateInterface $taxRate)
 
         $regionCode = $taxRate->getTaxRegionId();
         // if regionCode eq 0 (all regions *), do not validate with existing region list
-        /** @phpstan-ignore-next-line */
         if (\Zend_Validate::is($regionCode, 'NotEmpty')
             && $regionCode != "0"
-            /** @phpstan-ignore-next-line */
-            && !\Zend_Validate::is($this->regionFactory->create()->load($regionCode)->getId(),'NotEmpty')
+            && !\Zend_Validate::is($this->regionFactory->create()->load($regionCode)->getId(), 'NotEmpty')
         ) {
             $exception->addError(__(
                 'Invalid value of "%value" provided for the %fieldName field.',
@@ -279,7 +278,6 @@ private function validate(TaxRateInterface $taxRate)
         }
 
         if ($taxRate->getCode() === null
-            /** @phpstan-ignore-next-line */
             || !\Zend_Validate::is(trim($taxRate->getCode()), 'NotEmpty')
         ) {
             $exception->addError(__('"%fieldName" is required. Enter and try again.', ['fieldName' => 'code']));
@@ -305,7 +303,6 @@ private function validate(TaxRateInterface $taxRate)
             }
         } else {
             if ($taxRate->getTaxPostcode() === null
-                /** @phpstan-ignore-next-line */
                 || !\Zend_Validate::is(trim($taxRate->getTaxPostcode()), 'NotEmpty')
             ) {
                 $exception->addError(