ENGCOM-4177: Remove unwanted condition check #21046

magento-engcom-team · magento-engcom-team · commit 33db8bd3c6e2 · 2019-02-07T14:30:26.000-06:00
- Merge Pull Request #21046 from dominicfernando/magento2:remove-unwanted-condition-check - Merged commits: 1. 1fde486 2. 10fc55b
diff --git a/app/code/Magento/Cms/Helper/Page.php b/app/code/Magento/Cms/Helper/Page.php
@@ -187,7 +187,7 @@ public function getPageUrl($pageId = null)
     {
         /** @var \Magento\Cms\Model\Page $page */
         $page = $this->_pageFactory->create();
-        if ($pageId !== null && $pageId !== $page->getId()) {
+        if ($pageId !== null) {
             $page->setStoreId($this->_storeManager->getStore()->getId());
             $page->load($pageId);
         }

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ public function getPageUrl($pageId = null)`
`187`	`187`	`{`
`188`	`188`	`/** @var \Magento\Cms\Model\Page $page */`
`189`	`189`	`$page = $this->_pageFactory->create();`
`190`		`- if ($pageId !== null && $pageId !== $page->getId()) {`
	`190`	`+ if ($pageId !== null) {`
`191`	`191`	`$page->setStoreId($this->_storeManager->getStore()->getId());`
`192`	`192`	`$page->load($pageId);`
`193`	`193`	`}`