Skip to content

Commit 33aedcc

Browse files
committed
ACP2E-3506: GraphQL Response for Order placement is partially localised
1 parent 66b148a commit 33aedcc

File tree

3 files changed

+23
-41
lines changed

3 files changed

+23
-41
lines changed

dev/tests/api-functional/testsuite/Magento/QuoteGraphQl/Model/Resolver/PlaceOrderTest.php

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
*/
66
declare(strict_types=1);
77

8+
namespace Magento\QuoteGraphQl\Model\Resolver;
9+
810
use Magento\Catalog\Test\Fixture\Product as ProductFixture;
911
use Magento\Customer\Test\Fixture\Customer;
1012
use Magento\Indexer\Test\Fixture\Indexer;
@@ -15,9 +17,9 @@
1517
use Magento\TestFramework\Fixture\DataFixture;
1618
use Magento\TestFramework\Fixture\DataFixtureStorageManager;
1719
use Magento\TestFramework\Helper\Bootstrap;
18-
use Magento\TestFramework\Helper\CacheCleaner;
1920
use Magento\TestFramework\TestCase\GraphQl\ResponseContainsErrorsException;
2021
use Magento\TestFramework\TestCase\GraphQlAbstract;
22+
use Magento\Translation\Test\Fixture\Translation;
2123

2224
class PlaceOrderTest extends GraphQlAbstract
2325
{
@@ -41,10 +43,26 @@ protected function setUp(): void
4143
* Test translated error message in non default store
4244
*
4345
* @magentoApiDataFixture Magento/Store/_files/second_store.php
44-
* @magentoApiDataFixture Magento/Translation/_files/place_order_message_translate.php
4546
* @magentoConfigFixture fixture_second_store_store general/locale/code nl_NL
4647
*/
4748
#[
49+
DataFixture(
50+
Translation::class,
51+
[
52+
'string' => 'Unable to place order: %message',
53+
'translate' => 'Kan geen bestelling plaatsen: %message',
54+
'locale' => 'nl_NL',
55+
]
56+
),
57+
DataFixture(
58+
Translation::class,
59+
[
60+
'string' => 'Some addresses can\'t be used due to the configurations for specific countries.',
61+
'translate' => 'Sommige adressen kunnen niet worden ' .
62+
'gebruikt vanwege de configuraties van specifieke landen.',
63+
'locale' => 'nl_NL',
64+
]
65+
),
4866
DataFixture(ProductFixture::class, as: 'product'),
4967
DataFixture(Indexer::class, as: 'indexer'),
5068
DataFixture(Customer::class, ['email' => 'customer@example.com'], as: 'customer'),
@@ -61,7 +79,6 @@ protected function setUp(): void
6179
]
6280
public function testPlaceOrderErrorTranslation()
6381
{
64-
CacheCleaner::clean(['translate', 'config']);
6582
$storeCode = "fixture_second_store";
6683
$maskedQuoteId = DataFixtureStorageManager::getStorage()->get('quoteIdMask')->getMaskedId();
6784
$query = $this->placeOrderQuery($maskedQuoteId);
@@ -71,9 +88,9 @@ public function testPlaceOrderErrorTranslation()
7188
} catch (ResponseContainsErrorsException $exception) {
7289
$exceptionData = $exception->getResponseData();
7390
self::assertEquals(1, count($exceptionData['errors']));
74-
self::assertEquals(
75-
'Kan geen bestelling plaatsen: Sommige adressen kunnen niet worden gebruikt' .
76-
' vanwege de configuraties van specifieke landen.',
91+
self::assertStringContainsString('Kan geen bestelling plaatsen:', $exceptionData['errors'][0]['message']);
92+
self::assertStringContainsString(
93+
'Sommige adressen kunnen niet worden',
7794
$exceptionData['errors'][0]['message']
7895
);
7996
}

dev/tests/integration/testsuite/Magento/Translation/_files/place_order_message_translate.php

Lines changed: 0 additions & 23 deletions
This file was deleted.

dev/tests/integration/testsuite/Magento/Translation/_files/place_order_message_translate_rollback.php

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)