Skip to content

Commit 339d8cd

Browse files
committed
MAGETWO-52836: Enable EAV attributes caching
1 parent 693c66d commit 339d8cd

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

app/code/Magento/Catalog/Model/Product/Copier.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public function copy(\Magento\Catalog\Model\Product $product)
7575
: $urlKey . '-1';
7676
$duplicate->setUrlKey($urlKey);
7777
try {
78-
$duplicate->save($duplicate);
78+
$duplicate->save();
7979
$isDuplicateSaved = true;
8080
} catch (\Magento\Framework\Exception\AlreadyExistsException $e) {
8181
}

app/code/Magento/Customer/Model/Metadata/CachedMetadata.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function getCustomAttributesMetadata($dataObjectClassName = null)
102102
* @return AttributeCache
103103
* @deprecated
104104
*/
105-
protected function getCache()
105+
private function getCache()
106106
{
107107
if (!$this->cache) {
108108
$this->cache = ObjectManager::getInstance()->get(AttributeCache::class);

app/code/Magento/Eav/Test/Unit/Model/ResourceModel/Entity/AttributeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class AttributeTest extends \PHPUnit_Framework_TestCase
2222

2323
protected function setUp()
2424
{
25-
$this->markTestSkipped();
25+
$this->markTestSkipped('Unreliable implementation, MAGETWO-52857');
2626
$this->contextMock = $this->getMock(
2727
'\Magento\Framework\Model\Context',
2828
['getCacheManager', 'getEventDispatcher', 'getLogger', 'getAppState', 'getActionValidator'],

dev/tests/integration/testsuite/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/EavTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ public function testModifyMeta()
7575
*/
7676
public function testModifyData()
7777
{
78-
$this->markTestSkipped();
7978
/** @var \Magento\Catalog\Model\Product $product */
8079
$product = $this->objectManager->create(\Magento\Catalog\Model\Product::class);
8180
$product->load(1);

0 commit comments

Comments
 (0)