ACP2E-1347: Bundle product save slow

Author: o-iegorov

app/code/Magento/Bundle/Api/ProductAddChildrenInterface.php renamed to app/code/Magento/Bundle/Api/ProductLinkManagementAddChildrenInterface.php

@@ -11,7 +11,7 @@
 /**
  * Interface for Bulk children addition
  */
-interface ProductAddChildrenInterface
+interface ProductLinkManagementAddChildrenInterface
 {
     /**
      * Bulk add children operation

app/code/Magento/Bundle/Model/LinkManagement.php

@@ -10,7 +10,7 @@
 use Magento\Bundle\Api\Data\LinkInterface;
 use Magento\Bundle\Api\Data\LinkInterfaceFactory;
 use Magento\Bundle\Api\Data\OptionInterface;
-use Magento\Bundle\Api\ProductAddChildrenInterface;
+use Magento\Bundle\Api\ProductLinkManagementAddChildrenInterface;
 use Magento\Bundle\Api\ProductLinkManagementInterface;
 use Magento\Bundle\Model\Product\Type;
 use Magento\Bundle\Model\ResourceModel\Bundle;
@@ -31,7 +31,7 @@
  *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
-class LinkManagement implements ProductLinkManagementInterface, ProductAddChildrenInterface
+class LinkManagement implements ProductLinkManagementInterface, ProductLinkManagementAddChildrenInterface
 {
     /**
      * @var ProductRepositoryInterface

app/code/Magento/Bundle/Model/Option/SaveAction.php

@@ -11,7 +11,7 @@
 use Magento\Bundle\Api\Data\LinkInterface;
 use Magento\Bundle\Api\Data\OptionInterface;
 use Magento\Bundle\Api\ProductLinkManagementInterface;
-use Magento\Bundle\Api\ProductAddChildrenInterface;
+use Magento\Bundle\Api\ProductLinkManagementAddChildrenInterface;
 use Magento\Bundle\Model\Product\Type;
 use Magento\Bundle\Model\ResourceModel\Option;
 use Magento\Bundle\Model\ResourceModel\Option\Collection;
@@ -51,7 +51,7 @@ class SaveAction
     private $linkManagement;
 
     /**
-     * @var ProductAddChildrenInterface
+     * @var ProductLinkManagementAddChildrenInterface
      */
     private $addChildren;
 
@@ -61,7 +61,7 @@ class SaveAction
      * @param Type $type
      * @param ProductLinkManagementInterface $linkManagement
      * @param StoreManagerInterface|null $storeManager
-     * @param ProductAddChildrenInterface|null $addChildren
+     * @param ProductLinkManagementAddChildrenInterface|null $addChildren
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
@@ -70,14 +70,14 @@ public function __construct(
         Type $type,
         ProductLinkManagementInterface $linkManagement,
         ?StoreManagerInterface $storeManager = null,
-        ?ProductAddChildrenInterface $addChildren = null
+        ?ProductLinkManagementAddChildrenInterface $addChildren = null
     ) {
         $this->optionResource = $optionResource;
         $this->metadataPool = $metadataPool;
         $this->type = $type;
         $this->linkManagement = $linkManagement;
         $this->addChildren = $addChildren ?:
-            ObjectManager::getInstance()->get(ProductAddChildrenInterface::class);
+            ObjectManager::getInstance()->get(ProductLinkManagementAddChildrenInterface::class);
     }
 
     /**
@@ -153,10 +153,7 @@ private function saveOptionItem(
             throw new CouldNotSaveException(__("The option couldn't be saved."), $e);
         }
 
-        /** @var LinkInterface $linkedProduct */
-        foreach ($linksToAdd as $linkedProduct) {
-            $this->linkManagement->addChild($bundleProduct, $option->getOptionId(), $linkedProduct);
-        }
+        $this->addChildren->addChildren($bundleProduct, (int)$option->getOptionId(), $linksToAdd);
     }
 
     /**

app/code/Magento/Bundle/etc/di.xml

@@ -9,7 +9,7 @@
     <preference for="Magento\Bundle\Api\ProductOptionTypeListInterface" type="Magento\Bundle\Model\OptionTypeList" />
     <preference for="Magento\Bundle\Api\Data\OptionTypeInterface" type="Magento\Bundle\Model\Source\Option\Type" />
     <preference for="Magento\Bundle\Api\ProductLinkManagementInterface" type="Magento\Bundle\Model\LinkManagement" />
-    <preference for="Magento\Bundle\Api\ProductAddChildrenInterface" type="Magento\Bundle\Model\LinkManagement" />
+    <preference for="Magento\Bundle\Api\ProductLinkManagementAddChildrenInterface" type="Magento\Bundle\Model\LinkManagement" />
     <preference for="Magento\Bundle\Api\Data\LinkInterface" type="Magento\Bundle\Model\Link" />
     <preference for="Magento\Bundle\Api\ProductOptionRepositoryInterface" type="Magento\Bundle\Model\OptionRepository" />
     <preference for="Magento\Bundle\Api\ProductOptionManagementInterface" type="Magento\Bundle\Model\OptionManagement" />