MAGETWO-66100: Remove usages of unserialize in module Magento/Setup

Author: Mykola Palamar

setup/src/Magento/Setup/Model/AdminAccountFactory.php

@@ -8,6 +8,7 @@
 
 use Magento\Setup\Module\Setup;
 use Zend\ServiceManager\ServiceLocatorInterface;
+use Magento\Framework\Serialize\Serializer\Json;
 
 class AdminAccountFactory
 {
@@ -34,7 +35,8 @@ public function create(Setup $setup, $data)
         return new AdminAccount(
             $setup,
             $this->serviceLocator->get(\Magento\Framework\Encryption\Encryptor::class),
-            $data
+            $data,
+            new Json()
         );
     }
 }

setup/src/Magento/Setup/Test/Unit/Model/AdminAccountTest.php

@@ -7,6 +7,7 @@
 namespace Magento\Setup\Test\Unit\Model;
 
 use \Magento\Setup\Model\AdminAccount;
+use Magento\Framework\Serialize\Serializer\Json;
 
 class AdminAccountTest extends \PHPUnit_Framework_TestCase
 {
@@ -30,6 +31,11 @@ class AdminAccountTest extends \PHPUnit_Framework_TestCase
      */
     private $adminAccount;
 
+    /**
+     * @var Json|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $serializer;
+
     public function setUp()
     {
         $this->setUpMock = $this->getMock(\Magento\Setup\Module\Setup::class, [], [], '', false);
@@ -53,6 +59,12 @@ function ($table) {
         $this->encryptor = $this->getMockBuilder(\Magento\Framework\Encryption\EncryptorInterface::class)
             ->getMockForAbstractClass();
 
+        $this->serializer = $this->getMockBuilder(Json::class)
+            ->getMock();
+        $this->serializer->expects($this->any())->method('serialize')->willReturnCallback(function ($param) {
+            return json_encode($param);
+        });
+
         $data = [
             AdminAccount::KEY_FIRST_NAME => 'John',
             AdminAccount::KEY_LAST_NAME => 'Doe',
@@ -61,7 +73,12 @@ function ($table) {
             AdminAccount::KEY_USER => 'admin',
         ];
 
-        $this->adminAccount = new AdminAccount($this->setUpMock, $this->encryptor, $data);
+        $this->adminAccount = new AdminAccount(
+            $this->setUpMock,
+            $this->encryptor,
+            $data,
+            $this->serializer
+        );
     }
 
     public function testSaveUserExistsAdminRoleExists()